From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Jay Patel <jaypatel@linux.ibm.com>
Cc: linux-mm@kvack.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, vbabka@suse.cz,
aneesh.kumar@linux.ibm.com, tsahu@linux.ibm.com,
piyushs@linux.ibm.com, roman.gushchin@linux.dev
Subject: Re: [RFC PATCH ] mm/slub: Reducing slub memory wastage
Date: Mon, 19 Jun 2023 12:25:19 +0900 [thread overview]
Message-ID: <ZI/KeBgSEFObUnSy@fedora> (raw)
In-Reply-To: <51045addfd3ec7804bcc36daed5827bf51095b68.camel@linux.ibm.com>
On Tue, Jun 13, 2023 at 06:25:48PM +0530, Jay Patel wrote:
> > <...snip...>
> > > I conducted tests on systems with 160 CPUs and 16 CPUs, using 4K
> > > and
> > > 64K page sizes. Through these tests, it was observed that the patch
> > > successfully reduces the wastage of slab memory without any
> > > noticeable
> > > performance degradation in the hackbench test report. However, it
> > > should
> > > be noted that the patch also increases the total number of objects,
> > > leading to an overall increase in total slab memory usage.
> >
> > <...snip...>
> >
> > Then my question is that, why is this a useful change if total memory
> > usage is increased?
> >
> This patch aimed in reducing memory wastage can potentially lead to an
> increase in the slab order for a slab cache. Consequently, this
> increase in page order can result in a higher number of objects per
> slab, reducing wastage and leading to a more efficient utilization of
> memory.
if you define utilization as percentage of memory that is
being used out of total memory, utilization becomes worse... (based
on data you provided)
I think 'less memory wastage' is a useful feature only if the total
memory usage is reduced so that it could be used for other purposes.
I mean, if it consumes more memory on a same workload (in most cases),
who would like it?
> This enhancement is advantageous since the presence of unused
> objects can be leveraged in the future, depending on varying
> workloads.
At least we need to know when it is leveraged and what kinds of workloads
would benefit...
Thanks,
--
Hyeonggon Yoo
Undergraduate | Chungnam National University
next prev parent reply other threads:[~2023-06-19 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 8:55 Jay Patel
2023-06-12 10:17 ` Hyeonggon Yoo
2023-06-13 12:55 ` Jay Patel
2023-06-19 3:25 ` Hyeonggon Yoo [this message]
2023-06-28 10:27 ` Jay Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZI/KeBgSEFObUnSy@fedora \
--to=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jaypatel@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=piyushs@linux.ibm.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=tsahu@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox