From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28802C77B7C for ; Wed, 31 May 2023 06:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51C7B6B0075; Wed, 31 May 2023 02:01:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A58C6B0078; Wed, 31 May 2023 02:01:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 345B1900002; Wed, 31 May 2023 02:01:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 214876B0075 for ; Wed, 31 May 2023 02:01:09 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D6CE4401C1 for ; Wed, 31 May 2023 06:01:08 +0000 (UTC) X-FDA: 80849502216.02.E4487B5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id A1335180015 for ; Wed, 31 May 2023 06:01:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=TuRIxgkO; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+b81a8c9a6d22e8bb2302+7220+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b81a8c9a6d22e8bb2302+7220+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685512867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zXFbghN5Oa6JE4b5vk2VR/hhTLQNTSqD9OkNgOn3LKA=; b=d6u7vxAY76mPa9miutvN/mw0WPe0JdNL7516IncQ/px3ThPGJ1zlKmUePds0bU0JxDAhfC eri6p7jS+YNlIZoZnV85sttc+4xnS9nKYVjOHcetg1N5S4bffqwo4NcsJ3jcLYX4CMdKRI iEJVjJXftBlZzj6fvM1sj1Dt9ypZ7G0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=TuRIxgkO; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+b81a8c9a6d22e8bb2302+7220+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b81a8c9a6d22e8bb2302+7220+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685512867; a=rsa-sha256; cv=none; b=IzZwfjWQCd5L4kVIg/BBiGmN/JDKEpBdqzyeDyf08CVQ2Duy+Cbf8Nz2cKF4m/dF2cjbZ+ Xl8S+JF6nbiUEF8m1SCIf5KDI/bYamXBKi4ZjBPT0vCvv+mWUu7SX0/MQHCrcPKJ7/Ofp+ RFpLCnhrhnIm+CCz5WLV+5xBiPMDFaA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zXFbghN5Oa6JE4b5vk2VR/hhTLQNTSqD9OkNgOn3LKA=; b=TuRIxgkOysvpuskkTTblNke1x2 8kQW9AYsK0NPuQbEbOOlw6j28RDvPbSLKVv6fgtoIhZqiYkI2Sp7+Y8ftXPOgADBxvXRhKzk80M/n VLtY7uzaFNz4w+PVyQWNb21eB2qoKbU5/cWNoGRJeIaJDyNz2OpV1e3GD8pvAvWcvaoBQ1kMS/y6P pnasDNYMf4NBE9pgIeHwNMz0kLd5hnRbG0x5EY8Jcaj1kZbCZPHiMNZL1dGstf8juU42KYY6ptoew qM1JwRApgGprj1omrt876fMzRLZ9zEzOoVdY5W7mIOrSNAyn2PSDC7wZ3EEUb9GTKaKnJQcW05UfL WVjPlK1g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q4EtA-00GEeU-2m; Wed, 31 May 2023 06:00:52 +0000 Date: Tue, 30 May 2023 23:00:52 -0700 From: Christoph Hellwig To: Johannes Weiner Cc: Yosry Ahmed , Konrad Rzeszutek Wilk , Andrew Morton , Seth Jennings , Dan Streetman , Vitaly Wool , Nhat Pham , Domenico Cerasuolo , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: zswap: support exclusive loads Message-ID: References: <20230530210251.493194-1-yosryahmed@google.com> <20230530235447.GB102494@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530235447.GB102494@cmpxchg.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: g7mniq9h4odpikszdg7oz855tpm89nfb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A1335180015 X-HE-Tag: 1685512866-257224 X-HE-Meta: U2FsdGVkX1+VEmWRQDCRgkmnwLQPpovfUTYMH1I1fOwObVBeXFeA7ZoXiUum297j/rTzPWgDpwWc86RhYa0Bb0vMi372g1g1DwpSyXTkehIE9yTRqTOhEag/bfZZpFTf97yZqYng5ludfLbh0WO2q26U3dFIotdhwcoctpc3VfAHZifffJnEChpzJQydNzzndtshKMExUnKT4ntOa/f64mmfm58tsWDP1QTekTA/vNB8yfF5883EhI/GWv/HwXfu701cyiIq+K+HYh9yZ9rZJLFOFskXbAh5e4McMnzBW5KAxlr4G1R9WV8R140rwhyUrbHGRMy/tbMgx/FIAFHT6USRUhTmkLOPaCXXYI4T0lHSvduufNbjnnBkhL8iYxgjpKg0XrY2Z0JYu3ZvWdZdSa91njkt6tT/Ym/vASnNYmVJDym/XFBJl++nCVicdoayoN51BPUDI8emiR960swUdhaj5ISitV1tsBTNmZSKeki0RYFrGlN7BHLcLYvHJz/oIXJPXtuLYT0bVQFuDuoWTVcJ6jXJ43cZM9I5+RtTBJpVkFSV8zieOQ/KI3omJuXZs3zNhdL6fNbk7UjQsTwxcQZ/RjZCIJ8HXGqvKuGSlzABFNKfo6+0ZaDOLC2knn8HJfsphQ6I7Y9xpwWl3ol8ZL8OeXD1aWP5H6EQJfYfmQAYB2JMvS97KtBe/fH/kIRYd6VW35fsQ9vqS0bOKZlh6JZP0wbQMxYW8ExYFeG511qWFjoCQKCU7E8Rzn8c2rIXAfi9d4+krwFPYyc3CCmWiVSswqDmEEfyr29p97IZPMHwiAxnProI0ThZ5XwQExRIlPinN9XXEzEeL647FYkxIpwnIb8k2I5q7xeGn1rjm759+Mib8gryVpIO/gjampwmS5VZhnoNlGeCvOj3bECxytO5h91bZ95Kavo3jDxNEY9K1lWcpnHbcCKtkHbjiWcH2AHdcS6IiGUNGTJo0Yo O1iu4jOE 2M/AE9pRWlNlbaO2SuU/XM8SmJdPn0XK1KHtt2JQ3CoDo9J06VTrn9oTDG6oL7K3nrbQBKvf1jfABSvGTgiBaPmdu3CrXfA2x6UUcieo7MUGbps7MueFBHLl0yYMDXIoZV9Qp4KkBOOgjXPPJ/jNazQtZ3rMpOwROizJhmKz08yGIZ4D8WssI8YUjS+1/7c8d+bAXM28QLjEtL4Veh7naqA5Fsk6RL9eVtZBavEAsz3ZlS94Ar639lml0QFTBw7u8ywAw91tf62ZQqBKQ4QHyeTrtv2yKLWEGgn6FU8Y+c+RyjnuKgRlg3fVS6VISIV/WLIJ78qVRPXwLj+j1J0qlM8WNv5U/fnsUsDIB8IRxHXLi65S+uToeW/VKL6rsRqd+7x1oRiF5YVPggMs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30, 2023 at 07:54:47PM -0400, Johannes Weiner wrote: > Somewhat tangential, but is there still a point to the frontswap > layer? It seems usecases other than zswap have never materialized, at > least not in tree. Life would be a lot easier if we were to just > hardcode the zswap callbacks in the swap functions. I've been wanting to remove it for a while, as it really is rather pointless.