From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CACCFC7EE23 for ; Tue, 30 May 2023 16:10:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62F41280001; Tue, 30 May 2023 12:10:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DF29900002; Tue, 30 May 2023 12:10:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CEF2280001; Tue, 30 May 2023 12:10:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3B65B900002 for ; Tue, 30 May 2023 12:10:29 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F33B01202AC for ; Tue, 30 May 2023 16:10:28 +0000 (UTC) X-FDA: 80847408936.15.82CC4D7 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf17.hostedemail.com (Postfix) with ESMTP id 0ED2240014 for ; Tue, 30 May 2023 16:10:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of msnitzer@redhat.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=msnitzer@redhat.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685463018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Irk/8GUWmwLYWfm2Lio5fOal+y0GOgImfVphQa7iGfs=; b=f6Pwx4TpSX6YQZu2hAyVvqEWsFpfTIXdiuRahDRZ44QCDgjVb8sAiFzPTCTq4Pf2Sv4rUH s/c6EeRUbB2eTy5OKD6Q20Ad4d8H7YD89Td6r5EvdojHa1wCbBHs7QpT1M5rgrWNwsfWpI G9kfWW+QWo7NA6+1LomDP2ulR1Vrv6w= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of msnitzer@redhat.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=msnitzer@redhat.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685463018; a=rsa-sha256; cv=none; b=AI7NJQ92bwMRr8lgSeN0o5OD1/M2Lf4163zZmvuopT7j9drrW5j/Txpjo5b6dPacHwSeD4 GL9LW04GEKgdC6jOE2WgcypqiRgdQrDOs8f4nsFWOIbHrR+dJSFsgkgcCXhuA+4MoJZdnd Cmqpz2u6jeDNwFpEo+Hu/t5mlAfbRjM= Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-626117a8610so15885296d6.1 for ; Tue, 30 May 2023 09:10:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685463017; x=1688055017; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Irk/8GUWmwLYWfm2Lio5fOal+y0GOgImfVphQa7iGfs=; b=VgaGpVpMI+Hd+gcIC2GxopBaT+DcgFhvM/ypcSAvlwVJCv/DYPy7iacG1Li8WO9yQU 0qX0ICR0c2J6TkmZHLt/Afrt0O70Ocpa45K9VaawsaHiWlDLWD+dXvLqizZRNnXCmMH4 O5p0K1TNd5zTwHguYe0eEXOIJpvvCTRjJUcBcuc1URHuSQZniQlwVK0vSmI8MzKrJrq0 mHqAF9/Wg2t/EqahDoajObzbs4Mz+0aY+PvMtNBkffGcPReU0CJAp3cTmUU+sXCWdXtT p2P5jdbYDbXmaQ6V7JBL0sVtz+zu0ge2EO8d6buF1YhJkWTZTcYzcJ2U862a46SWG5h7 6BtA== X-Gm-Message-State: AC+VfDxmSx3ZVEm5q5BXRtVC6Tp8+DlTvlObCIT3louFMQaLn335qN3t +tqqzldGM4DSxdtd8Gjf954o X-Google-Smtp-Source: ACHHUZ56MECtsjcewLbFVxD7Rkez1npKixqOW82Zsid/kEpDsAmjiM2JZkfOYT0pMaVRxjwqyQggQQ== X-Received: by 2002:ad4:5b8d:0:b0:625:af4b:4162 with SMTP id 13-20020ad45b8d000000b00625af4b4162mr2721624qvp.14.1685463016980; Tue, 30 May 2023 09:10:16 -0700 (PDT) Received: from localhost (pool-68-160-166-30.bstnma.fios.verizon.net. [68.160.166.30]) by smtp.gmail.com with ESMTPSA id w20-20020a0562140b3400b0062381fa97c5sm898935qvj.92.2023.05.30.09.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 09:10:16 -0700 (PDT) Date: Tue, 30 May 2023 12:10:15 -0400 From: Mike Snitzer To: Johannes Thumshirn Cc: Jens Axboe , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Song Liu , dm-devel@redhat.com, Christoph Hellwig , Andreas Gruenbacher , Damien Le Moal , Matthew Wilcox , cluster-devel@redhat.com, Chaitanya Kulkarni , Ming Lei , linux-raid@vger.kernel.org, Bob Peterson , Mikulas Patocka , linux-block@vger.kernel.org, Damien Le Moal , gouhao@uniontech.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v6 16/20] dm-crypt: check if adding pages to clone bio fails Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0ED2240014 X-Rspam-User: X-Stat-Signature: aty5sfzae5epakjjysoup7hmfcws7cfc X-Rspamd-Server: rspam01 X-HE-Tag: 1685463017-452994 X-HE-Meta: U2FsdGVkX19bDyybjT+E2D0wTpoMJ1AK/AD9+PpdEVUdbV6smfKHyLGw08oWgxXX0X4CMp2xwTEMBALq8fKuFhIzyorBFzFp2PwDQD/bX1kTe+TT6474bXXeQCTux536PbcKsWdoa4shKrYvJmyISz5PfoafQ6R0KtaGXxj9iZzSqJFKmbX2u5f96dkIOtN4Wz8F1q5avlFE5NwtygXsavHKdmQOJMJ6pqij5zBuYp8ZHbV7DRCyADyesUevY6T0UaSC102X2EAIncyaEfko/QfZM6kXoTZvXesDvhEOjsNj91ecxNZX3TB3Sk2DWXWE0NIajYJyCkYeqOyuG2cmpTbclgqhH4d0zVkoMMIQWDN1vKX6rnw5f2pENKL8BSKITJLrqknAXsxSQxDEjGflA3Qvn6HwPjJecR8K7qQCmlDU/bp+jYg3pSmFuiTD+1+ECA48LZsooedz+XkZlIPw0gvavsd68/w/cm5XEBA0JQxXwzWqfdFckU2ow99s0X2TtXzzHtNbbipC9unnUFCy1M0wyakEaKEdFvzIQX0tsDPup5ssFtiorAIVVxFswaOrZ9ju5vyfEda2z8SiA2+ue6pnMlEH8PpEHGiuIJ6JN+weB0MXsO4jH5632Zwfbayr4F7C1OYnlUFXjT937YFoGhxY5/tvSkxd6X5WixU+33rJ4tUOmdVpDTU7IsgGMhYIaCOTBZXs7rtki2uPCSRCOulj/pdE/hs0Sh4kMwPkJcobQsPsaJnWKyFaPl+uXorJJalm2xWHAxbR1fRrxTT+C/f5GDArOGrLZjg+MEPrFL9PejhwCvZKr7STL6+1/nyUwOZZ8wJ+6HYZpr7EiPad0zAXF/qM+i60gf2sQiWhnkdTvP6tyAX5Mj2f9dV17g76nkZYDJkar7PQWSsQsB5gXbrurpLBShbJp9/xVd6fYMBKwu+DP2Gccx6qkWY0D2dbBts51htau9JvLp895xQ c9Nybmmu usjYQGEOZbX9yYsgyD/TpTw5yGBsG+wC/dngGAPsCY3YfQyZcwpgGYghKlV/HLXskk7QBacynZ9Ss1ySCreI0FzE4SvOuGaFkEpuKZ3CyfRT95NC1qeP/OrpYll8D2V8u4075zydHcvrWclxgH7e7meAcvOWuM02Yv4ehoM0Y+R73bg2/7RpDqDLuNuBvJxNeCn2I9fQP4AuyAjSsB3tYZEWkCGkiITzeScK/QJ1hufud/t0FpQ2ilROLi15DtndWqXTJA7dO9X/97pymw8eQ7VJATnJOWnCMiieTlOJO8if1C/j22BuOE2lV7wvPgvhctfnAr+lwWFXQxjBIWYQngOnxHaNmlnwHTHXhFKwSpna7TjTxazYW9rfdnhVwwGcffBv4BFTTNrOLuMNOx1mkbsDnxxAfIlXAhdqyXWgwjADrLAh7u6R2VrSmBv4dzCLFf5PCcUrT9unxlSzh6FmYGmgez87J4WvBkXTHEqbEf3X2MwRvtzkeBMUkbamoB6is/jJtXzAvbSbbHYk5QOuGVyD+XZC05rUc5l9S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30 2023 at 11:49P -0400, Johannes Thumshirn wrote: > Check if adding pages to clone bio fails and if it does retry with > reclaim. This mirrors the behaviour of page allocation in > crypt_alloc_buffer(). Nope. > This way we can mark bio_add_pages as __must_check. > > Reviewed-by: Damien Le Moal > Signed-off-by: Johannes Thumshirn The above patch header doesn't reflect the code. I also think __bio_add_page should be used, like my racey reply to Mikulas vs your v6 patchbomb said, please see: https://listman.redhat.com/archives/dm-devel/2023-May/054388.html Thanks, Mike > --- > drivers/md/dm-crypt.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c > index 8b47b913ee83..0dd231e61757 100644 > --- a/drivers/md/dm-crypt.c > +++ b/drivers/md/dm-crypt.c > @@ -1693,7 +1693,10 @@ static struct bio *crypt_alloc_buffer(struct dm_crypt_io *io, unsigned int size) > > len = (remaining_size > PAGE_SIZE) ? PAGE_SIZE : remaining_size; > > - bio_add_page(clone, page, len, 0); > + if (!bio_add_page(clone, page, len, 0)) { > + WARN_ONCE(1, "Adding page to bio failed\n"); > + return NULL; > + } > > remaining_size -= len; > } > -- > 2.40.1 > > -- > dm-devel mailing list > dm-devel@redhat.com > https://listman.redhat.com/mailman/listinfo/dm-devel >