From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB04BC77B73 for ; Tue, 30 May 2023 15:58:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BE8E280002; Tue, 30 May 2023 11:58:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56E98900002; Tue, 30 May 2023 11:58:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45D91280002; Tue, 30 May 2023 11:58:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 36690900002 for ; Tue, 30 May 2023 11:58:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1115012029C for ; Tue, 30 May 2023 15:58:42 +0000 (UTC) X-FDA: 80847379284.03.E4F73F0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 4758318000E for ; Tue, 30 May 2023 15:58:39 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="a/4wUBQB"; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685462320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xo+9YJqIlNX5CkXFPT9/tOeJlUpNZJWwJsWPiPRjO34=; b=8piGbcyfPQVxaQC8nYXR4xqAcIDMxaebP3FuwjWAjCPNfnRU41uKssHs7rn8NAlxcrj9ud +d//e4UvNPKP2L8lUkMjJM5g713K36PdpPAF2sLfrWcP9moQw6EWZkq9ilEWij9ZnudGLi hTBQAXL5R9YK3k0XxVW0CmEq+DsIaoA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="a/4wUBQB"; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685462320; a=rsa-sha256; cv=none; b=qe8mMdDnaAvZxSZumPl4DxYoybohTYU2rzQU8VGTkMuZI5l37GLOhEd30YquXGRspj65Eh DiWQO3L6T0GTATnEk8bNeGpSWKn4mb3DbC0NRPYjC5Yv2n6/P46d0bumMFD7tPGkx5+6hN kLEqY1QnViAqGgQBzWz1xjnzZOHZGv8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xo+9YJqIlNX5CkXFPT9/tOeJlUpNZJWwJsWPiPRjO34=; b=a/4wUBQBOA7ZKeL+US2Hb0UQ5B /uyae9/MztFBLT6xagj5Kj2uv4hUiq2xViYGiPyQzX5Dq1TrmE8j/2BmArhkvRNdZnoJKHuR3oGjT q70EOipgTCOr/gMVzEKY8Fld1WQ3d/Wei+V81fuf1wVcN0h4k+CwBCbTwkDA5byJ8rA+Q75oIpbuM iI75d5d8+/HxTAiGtolR57f7tauEk6fbSDNcy1G4kDvEbevNMhKYhPjvMkEn8KzgDS5lB3DBvpG4n vFNEkSG3LolLX4YWiZguakd3aNdyD1HVVpI5G4nS+PAQU4T04qEMPX+yl4QDrn2KolGB81WSxTBfA Ed6MfK9g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q41jm-006QJo-VH; Tue, 30 May 2023 15:58:19 +0000 Date: Tue, 30 May 2023 16:58:18 +0100 From: Matthew Wilcox To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com Subject: Re: [PATCH v6 19/20] fs: iomap: use __bio_add_folio where possible Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: omr8dcfpcag9xtb1675x9oyr8qakm1ra X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4758318000E X-HE-Tag: 1685462319-991233 X-HE-Meta: U2FsdGVkX1+fO0YrAx+XqUsbxB/el/t6g4aVAFOCqr6W0lqNZZZ7QwByElzgZmR0UqikuFe/X1RsNbSJnFG7Qr5UcddUtVFg8ijv3poV269t3ua/AEAP2SH3tNiRGHqFI0Wjdzg048oakh3o/znzHAXQckXYlRS0fNTUeBpxiCSM0kGzBaMpeDyySMmPjGaFWaeHeEiKKkiNHSZKaDiHCxLnT9g5XFPV/CCL5CQyZX6oXoXh/yg36o/Y1UrGYtzOtDDnUgc1ta/u0ThIGmhXccgMwzjAmjPT4h198mQhA0pIDYunBwCRIo4rZQvejDh6JSbwtH6PiWgI9CXEbZM0skOy80AK29UIDS+dCDrnunr6pdXSj2wti4KAGLx6TqZsKc+f05qCIpkSp2TAMx9z/8m4bDMbcDc7cMiumSToPyfkV0CTd4b2RDO5cHPxKfrlWnIZpxfOQCAaqsqomgSKyDN3XDM1OrtLWQw/Ip8K02fVsT6pSuaNrp0wGLgM4DGr/pi1Vio9JtikpqCVF7d5+B901K5PHMQSP4SPeQf10MD6Qx8cG9iRSqq9qZMCKe4IiHIfrDCeGemNZmDHeZZfWUHzoMOWCF27EDAVf3WlTUsUQTg0QiCYX4+WiTVsfT/iGKZhMEdNclIR4n0cnfzHy4WNacDPHSmGnBC1J9B1WUMqELZJNU4ocwAroRzjfXlaY7dUsLId7xOsNZYZqk1RaQNxhBOAa+dbtwXmp/K1AmsQbEShHW7fks4gtcdGzQ0B6+eUCFc305K+0R2tT5q4emK+FnVcD2XuzqWUlHLAu31kGuzNFTtmqJL+8Yn1Pagr/t31U0a6LUmbj8q4xWOb4hVjKwjcW+++CIDWvAwlT41QUyQs2MNVSz6yegYGdJlZjidEEal/OMg3O53/cbAJgQhqzqotJaPTE0evLLlWQO++slGpWDKI4a+dxPYVA8Oa86m2RVSj6gp1+IyvQ3o QwEO1SIi A7rZIPEm+JzFioHopSPwBdz+2AGC2KXF8kYX63aw7bjVjmLzmuaXftF1jv6Mr/DH/e+A0WCvgdehhEVCECYdrrijk1jWokvCDoES/LrfkPG4yGV+9Jfe1W+r5uZYvq+n3fNNm12Uc8n9Ht3tVELuLe4tBgTiLSK5eVGK4qrqlGfVrnUasutjD94cUVynhsAnm/DSyQZt9aVVWrJPYcd4UZo7EKIdgJNGjcWqTIfmoq1ReG73ZVb1Zv7N27PbBS1qLFd77zFACVIH1YLujzemQYUa1TyHAyniGdyrs5WiNIU9NAV0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30, 2023 at 08:49:22AM -0700, Johannes Thumshirn wrote: > When the iomap buffered-io code can't add a folio to a bio, it allocates a > new bio and adds the folio to that one. This is done using bio_add_folio(), > but doesn't check for errors. > > As adding a folio to a newly created bio can't fail, use the newly > introduced __bio_add_folio() function. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Matthew Wilcox (Oracle)