From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8758C7EE23 for ; Tue, 30 May 2023 09:25:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47AFB6B0072; Tue, 30 May 2023 05:25:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42B766B0074; Tue, 30 May 2023 05:25:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F33C900002; Tue, 30 May 2023 05:25:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1B10C6B0072 for ; Tue, 30 May 2023 05:25:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E014BC0191 for ; Tue, 30 May 2023 09:25:12 +0000 (UTC) X-FDA: 80846387664.20.A9B1F97 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 226E91C0017 for ; Tue, 30 May 2023 09:25:10 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Epahyvx0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685438711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5OSazfFhKBuzJDvth1f7Dqd7hERmV/6oE9F1R8Geijg=; b=oiUH2qA82lkHnSX/YUwri7RBnVKz5QGY6U2p/v72sNDPMwcAh/GEFoNAptltJvtgGnC7Fd ZExztkLqLzkJ2LA3JQx0jjBlgJXaUFit1Qp6CMrOHa/5QXLSD+zUCA5qduONqbau/9vYmU llThQvGUVYEPf9OTlN4ELDl6In7PLPA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Epahyvx0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685438711; a=rsa-sha256; cv=none; b=19Pf+eZLrPiRqLkz+mq9c86qyJ106ehDcb003K2yf/Gv9WAaF+B9nDUxnr4wwcK4tlgT4l 3v2mawIixod8Ejvaepyh9D9UBISqggp0xjzY39EwNjSEvE5mLyEv/SlEQw5ZcHpPCJtjKK xXidtW6EAohzrAbIQSDRh39Te4Y3TAM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685438710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5OSazfFhKBuzJDvth1f7Dqd7hERmV/6oE9F1R8Geijg=; b=Epahyvx0Igxu4sWW4glDC2Nb6NfJZF38aJ5a9aZ69YFORtecP8lfVrpZW1cjhokFs4bRTD VKUhyrtxMvW7pJnfCmUdLJpzzGTEmHKlSSJnND4xtXA3g9HZmkuV6xL9r6EjA4RUSpsp1y 8y0RryMkX3D2Ogc9yKnfX9g1nV8hURY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-S-hb1pRvMniLEpkD_s7AUg-1; Tue, 30 May 2023 05:25:07 -0400 X-MC-Unique: S-hb1pRvMniLEpkD_s7AUg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 372DF811E86; Tue, 30 May 2023 09:25:06 +0000 (UTC) Received: from localhost (ovpn-12-192.pek2.redhat.com [10.72.12.192]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47035492B0A; Tue, 30 May 2023 09:25:04 +0000 (UTC) Date: Tue, 30 May 2023 17:25:01 +0800 From: Baoquan He To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Vineet Gupta , linux-snps-arc@lists.infradead.org Subject: Re: [PATCH v5 RESEND 07/17] arc: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-8-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 226E91C0017 X-Stat-Signature: i8ohpzabh1ssr49ezegeozdyh4ss8ktx X-HE-Tag: 1685438710-656230 X-HE-Meta: U2FsdGVkX1+6xlcoBPvTVzAROguWwxJtNyh8V9Hk/Jfq3RCIqlQVa52DRPOrnwNewnSCWwpTiFOU8gb32Aah7xV59sPz780fmca+XC3Vg+HFD8gowjid+dmd4pXYIxFEhyQGiWHgYdtPJFsrbDPdlNyupfGIa9uq0IFf1+pb47DxpAPerPaegsEvRbARTE5+Oc/9a13hz1D14uf5ZeuiUnk7YIQaYclRdRZsCMOFB3V/blnZOXuDKRhNfp3M4IQCxgzk54SKr/fbAWG7zTIlezl201PWhdcwPCL3Aw63TqIWLKCpdy3iIvO6jKlspCVNmwTWFYzYjZsspb/OZIsSCTBbKS/rY+IigKsWcvwJOQSNl9ofDd7Zr1iV9wbt2wj+PGuJkB99OH2ixAlJabn4GUYaCAr8Y3dztI1rtdW6JcZcQJxb9irOEBMRfydDzgieVx4ArD06H/40YmU+8oAKKnru1dJgyT7320nlIcfvbVOYSp8Vf4+cK7LGMQ+tDAgxlj3rNHU+6cWm4j3iOPzZju6lgF93Xqmw9QPdCoA8szsiwCNGlO5g5LJUsCo0P6hp5BM4zZJ0TFOjefssBKqYtsGzA9nL+YfkEwZ+MGrNgyUx/tAmMiU0dhQFUFBR7aGiuDvuE5Tv+GrOs0Y8rVjdOJoDYsJqSfb24sWxBHEliI1NrE8sz/1utDAJiHk5gfzIKQyTTiqPAQlaRbktW7VXp0RFIMZbr9FT4gShHABhTikuPzAWorXuFaO8+1N7FpPkoChqkQKFUvvKhx/E8Uv9Jw62j23AuqqmObr3Nzq4f9qJYaPuic7/Uery1ycBrY9mvBO1IwSzlu34d+ho8NcBLKm1bUeyVx/cUzuTPW//Mj3w1vWTu9+0BC19LCDjhTOf7XDN9R6guqhpKtrixgMW910L4zbyUnQ0+EUEokeXhNeFODHGcWE0U7gmg85oEe47WFVMhugij7wkFx04txM HGuUsuti JTOVBln3AOYNkl0xwa7MBTj+GPqVo40FjnlmGoQ4LhEB9Lv8gJo1BtOCthnsHD/wzNkFRX+wOI7THqHWHKhK0d8m3xgu+PD2T06VDyoxz18C2Lg9hd8RlRIEcLB4IyY9AcNnnMlnjhDs1URMumyt4BiHoK/YvZOAix++8kFsZeR36qq00b4xs+NeAt5mhGrJwNyXpEems1/qPR6s+1ncJ/0B9rgJFZ2UYLVuE/+FlsFSBdSxzytEiOyJqnA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christoph, On 05/16/23 at 11:31pm, Christoph Hellwig wrote: > > +#define ioremap ioremap > > +#define ioremap_prot ioremap_prot > > +#define iounmap iounmap > > Nit: I think it's cleaner to have these #defines right next to the > function declaration. For this one, I didn't add function declaration of ioremap_prot and iounmap in arch/arc/include/asm/io.h and the same to other arch's asm/io.h. Because asm-generic/io.h already has those function declaration, then ARCH's asm/io.h includeasm-generic/io.h. I tried adding function declarations for ioremap_prot() and iounmap(), building passed too. Do you think we need add extra function declarations in ARCH's asm/io.h file? Thanks Baoquan