From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8DDC77B7A for ; Mon, 29 May 2023 17:55:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1E70900002; Mon, 29 May 2023 13:55:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE8A6B0074; Mon, 29 May 2023 13:55:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 895EA900002; Mon, 29 May 2023 13:55:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 79E286B0072 for ; Mon, 29 May 2023 13:55:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 43974140170 for ; Mon, 29 May 2023 17:55:54 +0000 (UTC) X-FDA: 80844045828.20.D72125B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 441E118000E for ; Mon, 29 May 2023 17:55:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eKO8XMAZ; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685382952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P/0tITYpTpGavafJMOkhwQed8uJTPSwLhyk8FXAUCS8=; b=HvsnFvaCkmBhy2aF8TDQbJP/z0+dN9aDLbHKW10ZLjQHqbNuDs7dGlff/Q8u4cngJh9FDb EjeheJLA4rjhSfm2oK1zhnADppHP48xWo/1ziVAW0xte5/AQkLvKOydq4DKj0T0H9Ww7KD w1qt8bJ59mDHFaHh0iH2FIk87gKC0Sw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685382952; a=rsa-sha256; cv=none; b=m0SVQIBIM7S77yUgxY2azMHR+PfughYXY50n47GgyyFlOHkC4obrgukZiCHsPz91ioS8vf x1CFWfNpmr5gLRHIhfsjhw7KCHJs0JEw8BB3o2OMaNEt3RBOeZzHeJyzWKfmMwXEpwzWiK fo6wV4o8z2/WV3sk2ZYxQVj45Cux/pk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eKO8XMAZ; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P/0tITYpTpGavafJMOkhwQed8uJTPSwLhyk8FXAUCS8=; b=eKO8XMAZv/UuArc8zlhV6qI5Z6 wwoXuHeWvPqvnNzPY/wAymufwuUnWz6wKtpLuVcY2fUy6dTJzBfU0e48o8MOFMgYVur0phcqyOtjQ B8uuZ0z3MfECNtVeWZtb7jk1d3JWxI06vtr++Xye1e3s0OWgYfbvkkVEAQdwtpPnb42rxUe36boqU QAJs/GKgHmXFxleNHO/XY8yy/fJdUY60TlvLHghmlDoRv2OnYwBHpLjRKgLoErWJY4qzKidFxkgX9 jIYWaGUnt1MoaJK9eTUHxwg+ta8SPNFmjHJ4elcGTHg/ztPEuFCYUoJMbDx1VrG5kHxGlbYz57PH2 ZhauUOmw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q3h5K-005bSP-AT; Mon, 29 May 2023 17:55:10 +0000 Date: Mon, 29 May 2023 18:55:10 +0100 From: Matthew Wilcox To: Nitesh Shetty Cc: Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , James Smart , Chaitanya Kulkarni , Alexander Viro , Christian Brauner , Andrew Morton , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, James.Bottomley@hansenpartnership.com, bvanassche@acm.org, hare@suse.de, ming.lei@redhat.com, dlemoal@kernel.org, anuj20.g@samsung.com, joshi.k@samsung.com, nitheshshetty@gmail.com, gost.dev@samsung.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v11 2/9] block: Add copy offload support infrastructure Message-ID: References: <20230522104146.2856-1-nj.shetty@samsung.com> <20230522104146.2856-3-nj.shetty@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522104146.2856-3-nj.shetty@samsung.com> X-Stat-Signature: mtytk48kk1s9k5myqb6num91hmp6qixq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 441E118000E X-Rspam-User: X-HE-Tag: 1685382951-517923 X-HE-Meta: U2FsdGVkX1+i29EA6JAeNsKQJsNeBH4WjId9TcQdgvwNNBtyeUKaVXX/2P6PS248esP6LN7wPBDsrMOhyXm0aLzIwFHJ80Fgo8YzNnSzFE5TOB8GV/jvuVW1t6D2TzKN35eC+eZ0dd1jD9ERLHbuwNql3Nk0P2wPzibEjod9Y5nj7l4rgof5i/xYe/5wHvIDL9LRWZzzka5z7ZdmhDocY+3Rort6l/AhqPZl966tUmnOJ92jkAUzjzW09z4/X6uOhEGXRRrxoSf5UtQskQJIAbuijxDNgM0/rzq1+LflmaXiwn/ibfL8q9FrW640eMOjwgh7/k+t/SxrAh73XUB5AGYKgX6/tXp14J7S/tvxH9z6bifH7VqBtpNBMrEycoq9j0hSmHfdp5NTEHZR13Zv2I65N68P6acZuJLLQljuQz4X1YTUd8edYPh/hW5IZtYKpjFXNKPf4MJXuYaf3pw8jsF3WoHBsAhmRTZpgxjUWHKTHVZZmddUVY3yWxQWi230+jwlad84C+8dVB1y8RyFYawXyJFg+3qIeWLMD75mpHnJStySCgkWKKWjPn4GH1sK+qcolpn+qOVGMgZFs2fHXZQnHea9LolLv0NGCjMnKCEAm1CAX0Q6aVIoz5dTSg0jjBHD3eYwIIyUHf/8KBg3dApioyaTdjorJAYV2gnK4pU+7h5E9HjHbbKYml6qOIgGte7b2emQ/NqKpa0a8DQV0y9JZ8Od7TdP8Ljt0DQ1K4hefPX4YAEgnFaiMc9bTx79n/jq5Cof2znQvDscZBSvNolsFSPyFfMs24WhY0zVradQB+btC9srOwOmuXovZ32cDacMFpTQp8pJgNP6+UG8ycZFpyFjaMqL3os00Ofkhhpfsuq+ObOwuV9JlyeKmHMwzzUUdVBJ/6Y6linnTGe5bCtZJqiQQlahcPXmvONsbXppMG/zp5t+bH/Fz2bLaqz0PTE+DGmAlqELONyxGj7 PO5an2M7 +IitWth/tjzvfiomfNkJ35ikT3ynEPJYxExmbi3/I90NjpbxihZGPkfgPLViqjD2jmdyGBqhYuUyNaeiwTUmUwgL2aVbvlvOELUb3JWwEY57Qn67lXO6cEjaVQbKQEcivhmj0dZwrEfvonO0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 04:11:33PM +0530, Nitesh Shetty wrote: > + token = alloc_page(gfp_mask); Why is PAGE_SIZE the right size for 'token'? That seems quite unlikely. I could understand it being SECTOR_SIZE or something that's dependent on the device, but I cannot fathom it being dependent on the host' page size.