From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28257C7EE29 for ; Mon, 29 May 2023 15:42:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52153900002; Mon, 29 May 2023 11:42:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D1226B0072; Mon, 29 May 2023 11:42:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C055900002; Mon, 29 May 2023 11:42:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2C9C66B0071 for ; Mon, 29 May 2023 11:42:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EB6CCA02B1 for ; Mon, 29 May 2023 15:42:17 +0000 (UTC) X-FDA: 80843709114.26.E6BF4CC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id EDC354001E for ; Mon, 29 May 2023 15:42:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YZu3rZ9P; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685374936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GEOc1tvp0WQrWVjAH8HPKM9MWiK07/vmRfcmqhsDPbA=; b=frEwKNLPKNJf/BhUD0vAUEOdCMM5W4QnGYx2LgqmIP/a9xTiPBc7zPVfL9RArhNala4eZI RWGMP21gHn36ALNhoz+x0uATXW4dQujKnOgt3+8ZWdxhTCxzvemFaVa6vfI2RNSP9FmwAk aVxijwp4FIiR5AxFtH8CaRC/njTtsYo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YZu3rZ9P; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685374936; a=rsa-sha256; cv=none; b=FgTIjfSnmse02t1ua3l0KJvvmBZUMh+HAUO9X83NK6ZAakHTS+hq5gCJ5Ibmnu5TI1CPY4 z2RsXTfaqRotCctooTAX0F0NvUk+Pr6CV+m+SrK1dT/H5d5WavtsCQxGli8Cf+b6GSUF2B z/1fsWoM/pwpNfL3uceZqyxZcdcUFeE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GEOc1tvp0WQrWVjAH8HPKM9MWiK07/vmRfcmqhsDPbA=; b=YZu3rZ9P5cxJ1ZIj/n3o5zJAFf e0elkSJvZLGS/8DaYOtsk0SOkgB3654HS9hpLt+jMh8G7XKqeYOtEQejOXzFznhyTw/7bNERaKjZD 0GUVSznk/mVPFrklZ9Mdc+zIgHL2d2f4vWuNiV7nWryYz2sMhwQTswRfQOT0FgcffVIazu/ML+bpe nstKnPGQJvjenMLrw82PpIGnhaY7egeShC8Eso36Qs8Js+UKatke0I+O8bM/g4rLOw76Qv2eTj3+N uVITu8/pOemJEdp9rzfLFy1r7/xNsGfTKfkwt8OSau3Hmyv3TqyHyReh76KyzT4Hp3RVX3MraizaN OqU0iGdw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q3f0b-005W3L-W4; Mon, 29 May 2023 15:42:10 +0000 Date: Mon, 29 May 2023 16:42:09 +0100 From: Matthew Wilcox To: Petr Mladek Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] Do not print page type when the page has no type Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: EDC354001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gtix69bhd8s8wmms986njuw9sb5jfut6 X-HE-Tag: 1685374935-621687 X-HE-Meta: U2FsdGVkX1/bG3e8Z5qjhgq8aM2+tz3ijhyHqfxoYkXkXefJC8fu0kIGkw2IgRkKQjm3gx+RLUbOsnEPkvodqFN3NgiqbiLtNsB0bWPlOV07iG3zCAheUVLT16aeTBQ5hwMN3I1KQtvyG9R5/2KIqO1tg7suLxi5F3fYlZ5kevRpkA6zsz0IGY/uVI89QBvn+OxHK1JovOi17xJIvxtbqyApgVMpNnq/O5mgAdICdb6ajKfZjDJRX2kazpSLu5Eo2DmbuNe220CEjy3pHmRQPBAEBDMf8XR6zWh9ysFuRY63RmXuKwB1pv0Q/sD6hE+qXCOUVTumvBY0Lrf20u0ozFzodcVlx4PNHik60omRAbza2bc2NinFv1osZEfJH3ctmm1HGjtDybEcxTkqy477ubSq38QqISO2/E0qaWhw0CSWeUY2MkVHFD7xDxmLVq5T37yZSAy78VpZAa2A90wBfm0ygq0+OlnAHPFOdqCDbAdENEWUknkkTxH47Kjl3t0omHxBcaM3F1TLlmBKIMYWHFBfDjjV8ouZ8UVFw5kqiYvdm0ALCg5p79JBMBKG6RoOMAX77jJucU3Pf4yXdtOVKbQkYzWjebOPtYresmYCHAIZ+jOyQ1gRScPuRBfrlVAI17aE2Um0a6WTge7M5moHFRBoq+GMHRG3cLCaLN21zMEBq8zIT0V2CVUvJsBFNKqAxgc2xRHuj95dsUdmyFaL0en76SbUAbZkBt78YrT6pCL+IVSL+EFuIcAuExprgxJzi83PRXh14d5ecZ1bVu7e4Ea9Gbr+cpfadgCL4YlDBl15MYizonNcDp4x2nu0Mmqf5mzywB4PA7i1xqjcqnX/NtwzQiOScw9JbscRRZIB94ShRLPtGjrePRxoi0AhDag5OQStQNficiY/+dnBAdJgHn4otjJSu9jhZ/yYZbu4O/OC/yxTpfZ89bRGXcdu+Qm9bqyDE2Pww8PBRJPRRdS GvvszaOT rVy+tDhPUl34pEm8uROhZ4bYcxgphF585p+uujMXq3EM7iPaxBbnRWWK2SDzBlyJcxJCZq87kjM78xqTOoN3FH02aoBbW5CClujW7cVrz3UvYZamy1S41xeE5c94CbD5Uttc5CQwoz9ki9ODKAhcX0cMFqjykGi6G26VjUEwSry/RER4kJp1Q4MI9kEVorPXpnklP7tR0s9RLtedQxCVGLV7DrUUjOU+Xy8R55yXW3cjkyff89Jm4IBExuQoXbvlx0TGSjblj0AL6rJY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 29, 2023 at 05:27:29PM +0200, Petr Mladek wrote: > On Sun 2023-05-28 17:01:59, Hyeonggon Yoo wrote: > > The code mostly looks fine and the patch makes sense to me. > > But I'm not sure if it's a nice behavior to print garbage when it does not > > have a page type, although I can hardly imagine users of this flag other > > than __dump_page(). I'd rather keep printk part unchanged and add > > page_has_type() check in __dump_page(). > > I agree with Hyeonggon. The change in __dump_page() makes sense. > But vsprintf() should stay clever and do not print garbage. The caller (and, let's face it, there's only ever going to be one caller) shouldn't pass garbage in the first place.