From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C74AC77B7E for ; Mon, 29 May 2023 15:27:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FF6C6B0071; Mon, 29 May 2023 11:27:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 488E4900003; Mon, 29 May 2023 11:27:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3290C900002; Mon, 29 May 2023 11:27:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1EE186B0071 for ; Mon, 29 May 2023 11:27:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DDECE1C6D54 for ; Mon, 29 May 2023 15:27:33 +0000 (UTC) X-FDA: 80843671986.20.6E08AC5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf14.hostedemail.com (Postfix) with ESMTP id EB63A100018 for ; Mon, 29 May 2023 15:27:31 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=EgPvG3TZ; spf=pass (imf14.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685374052; a=rsa-sha256; cv=none; b=UsQ6+kGVD4sH1CSmLA7RKDYjUXgJEHr+nKEVNE9k2vREG1+H0CFH2Uj0yP/ppyIx9Nb3eA u5uSX+Xr0CZ5Y073WOkY1CumUb7xHo1qEt8TojTuwp66vYN9ldpm1cE1ZYDUDiOf+9rHvD 2mv38JSb+13xtMTRRf4O/ugfii1p184= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=EgPvG3TZ; spf=pass (imf14.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685374052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tImjIrcXPNlBpwEc+STpQmekya1xGcVGZ+OxEAegkho=; b=S6hWOJhBPT6RNpGjRY8mzgitRHrNbZs4jPd8HsMtBrzJHQ2Tpljl56JGCZBSBxBZ8AhlXf kmUVBtevjwst85kHH0rCitJzld1Bmwgw+fn7xa7CYvxnjHwBacATJxzgRVEji3ipVqR2Fh vecmbszoUhndz62ziGw7cG+pfM6cZwU= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 5F2241F749; Mon, 29 May 2023 15:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1685374050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tImjIrcXPNlBpwEc+STpQmekya1xGcVGZ+OxEAegkho=; b=EgPvG3TZ3adWI2gZeV92f1zyphnt9QWRLQK68mJpCl1os4NMkaFEC3lJq/GRBcM+/+V8Y3 73P1XUynLWam49F4q4VCAbc4iCYS2MJ7OE7m4WTXMvTqL73D0rljYXQWex6xKds4xOzcjm Sjtk5wDEDjGqazrc5nyqRYC40CpFyZM= Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EE7702C141; Mon, 29 May 2023 15:27:29 +0000 (UTC) Date: Mon, 29 May 2023 17:27:29 +0200 From: Petr Mladek To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Matthew Wilcox , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] Do not print page type when the page has no type Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EB63A100018 X-Stat-Signature: pfmxfey4optcxro4hosgmd5wrjrthz6a X-Rspam-User: X-HE-Tag: 1685374051-783593 X-HE-Meta: U2FsdGVkX18JXUasYQipIMCbsthhd0hsA3BtOsDppXvVbyaBMb9Tx6+O8GQh4YkuATgLXZ42KOR7Ux303R9FQLk5IWTj0pAIUeVsRDquuY1MUim8+1g+PhPvRua45ea+nCJVcJKsRCmI3u5gYgh8R9c5UF0HsY9frrNL66tZCvY+6C6Nna0bnsBRF4cj2JfiBHCk5TDnXwuSLaxNybCwPCP6HkKaxNvbgSwBj7iYLXoHuVWtJMKcBFYVSw22mXibGye+M5YNGGkTMG07uVhgHlTm0zHMhUMLc21Z0oWhJGnBSzBo1VJ9twV68W9U3Rv8PRONiGbwyv7DJMd8RQqTHKIgBMAz7065cFKSF37zHMllLkP/WVoyC6a+0q66gKWIBvoxDTOKs+kzxxl7F4zi2lET/wHg0pYtnRWjjgQCUi1kzZXNQJ3EP2tFVX61BpuyuPo8BrqInOcmw43z8lvtRY/r4qJ0GLE8MWtqs9klmdzrHl//ac5eQ7m7bEmWx9pcMcmU9ATD1otmY8eS+WHcrVzs8LPBE4YGhaCH6SdmmBXHolP6MbYAgmZ9rLZ4jiCL3psya3v4Rry4vEhi7SpAx7rHpcziHWkp2XswKUBfnBKaC8lzzfmJOexp3m+J0tLuv2Tve4bpuq14F7W8f6SqavrSRaRrfUaiMyIo96K9f52P45XFygwUQ7Y7Zjy8cQq5qw+HPndLNGzE+1XJwcvp6jflVR/HAi9rVGvoX7zSzSUnoAlWsbTYHMbyG+XygoOWKhRtQ9oUqsQKXSlKfNH3bla8AosQagLVIio6ymDMl4u6RxiFBRd1BrFGsWq0cgZVKtnNrc66DYSixF02FcNY72cm7eg9P+u3RqxHyr1yXh1+s3qpnX9yCcXGVwb63xIz1T0zIXMplxe6HsC3zvBWiHRpTw+BNQHSXKtAyzKXme+SaDRP5UxXbae7WrrJ0XDN/MTJhZxZOVBURfUNVPw ov6XzkbS dAEuaCDhmZvAu5POugpEkwfXgmf0nBpyN3/sWGaTku11atS4U2NmVAsG/7g0EGc75d0XqvE25GEFNGAkNAD2ZAkUcYjEww/HOzdzaXa9vAww0I9Mh70IiTnYIAtK7sMYUI2U1lTCQNTQ1/0FONmYZS7ew3CfI0oDuW1tNo8HXt2av0IQeCjVzUR6D9EFC85mC7DK1b81NK2VT+zIfvtRtPjGhLmTi+vrwVq+K/MeEUu9cYuhIIaspXmTrrHA/eVBieov9oFsB+v2i4w9S733rp+qiSRVEyjZRGjuPoCqD57iGuRGbHctb1TO+t4gI+ZCG9LN+kT64K3QG+GI7JY/XU2BpgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 2023-05-28 17:01:59, Hyeonggon Yoo wrote: > On Sat, May 27, 2023 at 05:48:32PM +0100, Matthew Wilcox wrote: > > It is confusing and unnecessary to print the page type when the > > page has no type. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > > --- > > > > I did not run the test-suite. I'm in the middle of debugging something > > else and this is an unwelcome distraction. If this doesn't work quite > > right, please fix it. > > I ran the test suite, and a test case failed: > > [ 1.001641] test_printf: loaded. > [ 1.001736] test_printf: vsnprintf(buf, 256, "%pGt", ...) returned 41, expected 5 > [ 1.001738] test_printf: vsnprintf(buf, 2, "%pGt", ...) returned 41, expected 5 > [ 1.001738] test_printf: vsnprintf(buf, 0, "%pGt", ...) returned 41, expected 5 > [ 1.001739] test_printf: kvasprintf(..., "%pGt", ...) returned '0xa(offline|guard|table|buddy|0xfffff875)', expected '0xa()' > [ 1.001774] test_printf: failed 4 out of 432 tests > > The code mostly looks fine and the patch makes sense to me. > But I'm not sure if it's a nice behavior to print garbage when it does not > have a page type, although I can hardly imagine users of this flag other > than __dump_page(). I'd rather keep printk part unchanged and add > page_has_type() check in __dump_page(). I agree with Hyeonggon. The change in __dump_page() makes sense. But vsprintf() should stay clever and do not print garbage. Best Regards, Petr