From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6634DC7EE23 for ; Mon, 29 May 2023 15:18:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 773A16B0071; Mon, 29 May 2023 11:18:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FD3D900003; Mon, 29 May 2023 11:18:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59E9C900002; Mon, 29 May 2023 11:18:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 457FF6B0071 for ; Mon, 29 May 2023 11:18:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1D918ADDFF for ; Mon, 29 May 2023 15:18:10 +0000 (UTC) X-FDA: 80843648340.22.F00B2C2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id D7CDBA000C for ; Mon, 29 May 2023 15:18:07 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hTHsIbQq; spf=pass (imf25.hostedemail.com: domain of johan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=johan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685373488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pWCGbr/xo27bJqX4LJApNLsonMmZbRU5cf2sbkqIIqk=; b=6PQUZOi32cr6DImXUivkVXkzxcyv/3mpTBtH5wq0eRjJBKKXKhFjXk6M48Lqk5yAHgt3hQ 1ES5/zaURSoN9YlV616n/SIFq7t9oMeds/ujq+tSDj7sdqUMfvgvSAc75xRTW15YDxn56l +7OYsbYdKCCWPT9voyOhT74KtxzrjUM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685373488; a=rsa-sha256; cv=none; b=pADYXqk2cbKIF6cErim10VFHC/E0D6QSkUpwzXbOR5fIiqP3DJ35Or10hTtzDBpBgzUzPR ALhAWCIN6DC0RYtSRy75fJgsuMZZqepkpjQUYQUEdy0S5oelie8rCcFrt/t1tkV8fmfLDh T5f6WsMYUJf9Cl2XOL4X4SeJKoNctuM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hTHsIbQq; spf=pass (imf25.hostedemail.com: domain of johan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=johan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B544461C7B; Mon, 29 May 2023 15:18:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 179ECC4339B; Mon, 29 May 2023 15:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685373486; bh=pCyIkcfuOGLfoej499SDyjDDnNMS1kghnwZewYrliwE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hTHsIbQqENAiVjiPSoaIA0euFBF/SqcWn0yT1saGhHU024SyZPBV9CvWDVGKgGK11 Se9p61dpwbmP8da8vgz5zmzqkZWiOXRkq8wlBbgjundRwzrPtYgiaDiOmqHZRbeb79 W5DHRyicRTQA+Kw39q3bZEapSVKPmjRkOpp94+dFv/nSbUST/Kh7n3VUUfLu+j/ZCv hiU03hqIBR+vwaTw3wy8w9celjteMDZW3na21VbLy9oWMNfpAieILENOW8rOBAP+RP 95tTtyPeOmnAqRL0wy26q9frAWBhJuL7P77nVwu85rRFqA16Pu5n5v+shXTfihXT84 XhvkcbNgKpuDQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1q3edH-0007Qt-H8; Mon, 29 May 2023 17:18:04 +0200 Date: Mon, 29 May 2023 17:18:03 +0200 From: Johan Hovold To: Linus Torvalds Cc: Luis Chamberlain , Lucas De Marchi , Petr Pavlu , gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org, lucas.de.marchi@gmail.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com, david@redhat.com, tglx@linutronix.de, hch@lst.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, prarit@redhat.com, lennart@poettering.net Subject: Re: [PATCH 2/2] module: add support to avoid duplicates early on load Message-ID: References: <20230524213620.3509138-3-mcgrof@kernel.org> <8fc5b26b-d2f6-0c8f-34a1-af085dbef155@suse.com> <6gwjomw6sxxmlglxfoilelswv4hgygqelomevb4k4wrlrk3gtm@wrakbmwztgeu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D7CDBA000C X-Rspam-User: X-Stat-Signature: ntxjboiuy8k3du53j91sut8agz1gthhn X-Rspamd-Server: rspam03 X-HE-Tag: 1685373487-500085 X-HE-Meta: U2FsdGVkX18DLNjUUGWzkE59HqYqpwxyEUSF9z5QpH15+VMTMorYQAqqvTlKvlHu3vlRYe5IpS10wGLuU3GDzts2zuOkX10QB2I5MRp0pxws0EmSZAA9B8EwNTKo6MxHH29kKI0dUnDSAqX9zwLmI/xvX80W764JFegQn9pTN264MlsrvBKVzhS2FJVdGLCRPChKfWMr5DEwUTKkGY3UjkGRJHXHXS/gYEauCUSG3WKZkmeeMIvE0VKy9SJeqOLIE7SvKowxT8/AqK1JCxYafAeP0ouBmASyCZQ75j/Qww5QRG7Mf40Uep+7cV8g8xA0qhMDum0d9b2y0TB4gS1v3Dvgcpv7hB1vQhvQ54vn68/hwsfPXMu9DLqkazb/Q/Nfn6VieOIh5XBaYxc/CtRMoO23Axc5y9dx/ubtIUrHHZvpAzTPBvP5jcc+qb6RQceeO1+A7kzercqgVz5opOTfYX7EzNI2Ba3J/BhSlvk/JvrwxKOXllixRGgs155hoK0DVFaEO70m0B6/zqf6o6QwSu9PVR9Tjy4vFkv7rVGxTGj8ay+wCMWFCkZbgoc3dI/FFOCfn1bL/eWa9u/rdd4CW2/aQsTKav6ytt22dNca0kPXDuLp/0Ce5b5+93t9VsTmkbNuyMp76KM9D6WcpeuWwIJmIebE8fqEtW/lYe4gl+vKD7i6pqfde89dBLSZ8l1gCGHmtuKwyMLcmzT4hlAp3WSpJP1osYiYj9v0e+8jJJ4fs8VwkoeG8E7FZgyIm+oLIWNTcakRx7sMQCcUaHZFC6U94DMuFFPoV7T8RYA3xhu9y4T5fn8SIUlA5jL5lP22gHqLIMMuduVJq6d9iWukyAq4INukNdsCpeULkWwHPqmKkI9fIsot95vQ5EpoMRpgcI4r2E0xcD9MnfM6+nYJZ3goIScK5RxVp0ZXiWxvP4yN/NCxgYaf9zKFM2upLoSllLBOZQ6L5W9K2lfyJJl xue04gua AeeMASusl4/fcln9k5+sGESCw6yShqvvc0bY/1/8S5qsz3tSWfqcHUD7Iz4KGv84otqg3oRnqQkzzpRc1j3f4ehuCKX5IEvvtPdHzp0Cim5MgCWLKG4JjGhuuE3rBqM2Y10oG2+5AEKkjLHo+hAYk9/1F0F2g6YaD9BOTzIRYo0c5KgGMNTXRZnHbEiaE2weWI2wnJsq5vkkMNXP5ywLHB5w59ErbE2EdSTI78mDRw1NefF+Oge1sGT/BWtb1PRme2HwrHrkszoO/QnAgUCyb2HoOeM+ZFhz8RDKl4ugzSc9jEgvBzf0ik4hlD5/N18Zz4R8ToDcvw3qoVJerKCUK9RJrU3OtV8k7OLnRng5nNBN4lZz+ptFtzNYXWi2U94HyXihDdXcraSvIzCroWLETt9AcjOYuhU6DQFQzB/aiMnUvjvM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Mon, May 29, 2023 at 07:00:05AM -0400, Linus Torvalds wrote: > > I do wonder what it is that is different in your setup I took a closer look at some of the modules that failed to load and noticed a pattern in that they have dependencies that are needed by more than one device. If attempts to load the drivers for two such devices are made in parallel, only one of them may be successful in loading the shared dependency which means that module loading is now aborted for the other. I took a quick look at the kmod code https://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git/tree/libkmod/libkmod-module.c#n1305 and it does seem like this could happen if we start returning errors when a module is already in the process of being loaded. Johan