From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79838C7EE29 for ; Mon, 29 May 2023 11:58:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F858900003; Mon, 29 May 2023 07:58:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A6AB900002; Mon, 29 May 2023 07:58:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7471A900003; Mon, 29 May 2023 07:58:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 625E0900002 for ; Mon, 29 May 2023 07:58:12 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2BB13160260 for ; Mon, 29 May 2023 11:58:12 +0000 (UTC) X-FDA: 80843144424.04.768FFA6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf29.hostedemail.com (Postfix) with ESMTP id 4CC25120013 for ; Mon, 29 May 2023 11:58:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="T27v/pEs"; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685361489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=99OVFMsEI+o0NXFSIbSb74d8EXInXAXOzm6QHE6Z63E=; b=WUkO9g8a/eoak8wtrcLynl2JmVDdc048dVsxJJxjIkAfsOmGWIsi4GhpOxFx3Yetf+Fbtm RTKOzUIX6sSx2VMLjjJ0X74P6pwyknHR4fhnf/HUWEsedUFth1BSX8otUEUbskqxcjRRRX jyaGK9pgwqjoyJQosjju7O7Idf+Kp4I= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="T27v/pEs"; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685361489; a=rsa-sha256; cv=none; b=3obLP/ebduAYZX8z8fBv7tdmPWMRO1yJ3JrRxyeVheCbzZbUjz2iwg1ZQo2zbP05NNtv+6 H1VszhZuK6t/ZrJ08VlGhO9sl0UG3U1brWGCl3kv41veIBfXmRdtMcVWQlG3LW2bpnTEld BWIIEIDoHujRQ439U2a6PDs9kignzxM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9836B21A60; Mon, 29 May 2023 11:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1685361487; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=99OVFMsEI+o0NXFSIbSb74d8EXInXAXOzm6QHE6Z63E=; b=T27v/pEsSnQqvLlJimCp61zxMgPMFPwqsebiCg1QRJeC1XfEyq40S/LK9+aOtRxtmHdrqn ADMvoIUSLRGZJOJzS591R/R/xaqCVLsKE72QOERIwwZ7sURPaaRA0eaTnpztbrAzA+rJKa f/Pq04lBsaf4xkUdUFQXnhQEFMP4BrU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 767D91332D; Mon, 29 May 2023 11:58:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tScgGk+TdGQJEQAAMHmgww (envelope-from ); Mon, 29 May 2023 11:58:07 +0000 Date: Mon, 29 May 2023 13:58:06 +0200 From: Michal Hocko To: Mike Rapoport Cc: Haifeng Xu , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mm_init.c: remove free_area_init_memoryless_node() Message-ID: References: <20230528045720.4835-1-haifeng.xu@shopee.com> <20230529090446.GK4967@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230529090446.GK4967@kernel.org> X-Rspamd-Queue-Id: 4CC25120013 X-Rspam-User: X-Stat-Signature: 3ka65xd9t1w51h1pn4cm96qaxzb9d653 X-Rspamd-Server: rspam01 X-HE-Tag: 1685361488-313143 X-HE-Meta: U2FsdGVkX18/lcK+WdsuXI5c/OO3xgQQIJBL83fcwd4m8n6YztHTFKqHWzfZWnk5zsfKwSZWpisFEBurtLCv5SyVY+MUA18rKb65RGVYXimn/s+e+1ddNboxxVyzmYYxIPtE8vDZwchLDGMXZALMroxoCKHcI+U2/7QjsRJxSnfWN4vXkg9DzgbYivJ1lCmzbJHl9KajgekLh/ESiThg+gUarr2+ZpwbfERjzvMmcwwXEl0t+bKb5g7P1OwyqAvIfuXq39MjtoCyYBNlEzhHJs4ExyRkNotnJu8Wl8ykEDQL7bpMFReRCYBSZSIn06AlcWt6144mLvVu8j2VpkppGsW6z3KdRuT5FZgnurNMOhIqdnO+2PLaQzwx+7Dl7eABmmZ4K1/S0chkc+32I8psGz7Eg2jjE4VKHq0wWJQKx31/MPwehxQ0zoIiv2BgSTU9YWIt3NPtkLhMjQrFnORD6NFTdX06sZsa/tUzCQrn5lfTRf8Kai+Jin0b1Oshxp+ag01WTHttFjhpAZjLDslR5A587KHiNQOd+PhVuYZCD69yJr1/S+EgxVPxQ7+nSEloMxofsWUMh+zcWcBhj0XI3nuRimNYMS3ocjS/9x0tUxRUsSoZsAWwYMgTcb6tHa+N65TU+jLjK7rqJLV3O7SmMHJXyKofuHTwZDWn6207FP5FiMcMt1Yahff6YX1oWmuyOcVcRY3rfIMbzL/xwrpt9YJK3Zwgx0Kae0XtiSktQAXDb6NiYmfLzBIRr1ExCP16ZU/tZAi4nRaLEzsCpD3JY+jB9OmG5DKgiiWDHUZoNiZUQIh+CdD+Q334HQkESzzbo8OQ1JSJlguTfgh82gtWKWcp7GigKyit9r2/wGESDTe1t4JBJHk5MR7kYHGTIhOlh4fnsiSN3h3pd/EJGawwj8YE5Mc/iNyoB+G6a2tVx/HZjSB042J1Z7kY9sY3oq94rd4BMp+pxY0RnV4ZTm5 OAc5+D1p OnVSaiBDlMLsM0H975PJX3lixyXIg4binEBI7IhIpz3p/nEZb3hF+O2tUpdiK9s4hCMmekACqfUbd1uR2RphbgxzhhRYXWJuRdnHIQHUGFyDfjIIKJjKEo4P5wm/FKW+JKOepSVrDbUFSaR8gc0RDlOMjKy8tKavaUHbPXQA5rlV5RmY2jCTOg7DvUme+8CnrsfFQlolyOAIhSjaGUN6uPPveoqP0BBScLI9itMlY6wKVLvfzT+8wVhXRn0w9Vy2aLm96PquCrECv/1WUUU/FQsdOeTcHit87Er8pmfE7Qj2hXX5Etz+0TiE1VA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 29-05-23 12:04:46, Mike Rapoport wrote: > (added Michal) > > On Sun, May 28, 2023 at 04:57:20AM +0000, Haifeng Xu wrote: > > free_area_init_memoryless_node() is just a wrapper of > > free_area_init_node(), remove it to clean up. > > > > Signed-off-by: Haifeng Xu > > --- > > mm/mm_init.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > index 2d91bb52c619..93821824271a 100644 > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -1752,11 +1752,6 @@ void __init setup_nr_node_ids(void) > > } > > #endif > > > > -static void __init free_area_init_memoryless_node(int nid) > > -{ > > - free_area_init_node(nid); > > -} > > - > > /* > > * Some architectures, e.g. ARC may have ZONE_HIGHMEM below ZONE_NORMAL. For > > * such cases we allow max_zone_pfn sorted in the descending order > > @@ -1867,7 +1862,7 @@ void __init free_area_init(unsigned long *max_zone_pfn) > > panic("Cannot allocate %zuB for node %d.\n", > > sizeof(*pgdat), nid); > > arch_refresh_nodedata(nid, pgdat); > > - free_area_init_memoryless_node(nid); > > + free_area_init_node(nid); > > Using a dedicated free_area_init_memoryless_node() wrapper here emphasizes > that the node has no memory, but I don't have a strong feeling about > keeping it. Honestly, I do not think it has any added value anymore. Some time ago it was a list of special parameters and aliasing that made some sense at least. Maybe that could be carved into the changelog in some form. Acked-by: Michal Hocko > > > > > /* > > * We do not want to confuse userspace by sysfs > > -- > > 2.25.1 > > > > -- > Sincerely yours, > Mike. -- Michal Hocko SUSE Labs