From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52741C77B7E for ; Sun, 28 May 2023 20:02:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF77D6B0071; Sun, 28 May 2023 16:02:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA62D6B0072; Sun, 28 May 2023 16:02:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99593900002; Sun, 28 May 2023 16:02:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 89B366B0071 for ; Sun, 28 May 2023 16:02:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0C8D0A02D8 for ; Sun, 28 May 2023 20:02:57 +0000 (UTC) X-FDA: 80840737194.24.F2AB94C Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf17.hostedemail.com (Postfix) with ESMTP id 114A040020 for ; Sun, 28 May 2023 20:02:54 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=lmyAX8Yv; spf=pass (imf17.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685304175; a=rsa-sha256; cv=none; b=MnnhY+m62XFoFuJyCtRTxEQL6Y71/WhKHZWSPb9RoMoREy/bFok3nOlAEMtDnkcvcptTSD giKwbhMArCUtgb414vhLnFPijYl0pMMMhD10h8AoFTwqPsyHda4hcWr+rhpmSuT9jcrPsx JsrPQvd4rFNk7E1idT9BvL2VodbN9DM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=lmyAX8Yv; spf=pass (imf17.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=olsajiri@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685304175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zo6CAhX/gKpTGl7xNzss4y9YGs7PPZhQ0B+6ZO4rHpo=; b=j84EkBi3Al7f0DJ09N0ybgwPlTjZmy34QKJO6DuNtHhqcHC05DeLqI2rm50tUvxLglcJuE jzxbYMPYkIo3izh1D8KmCttE5s4i52TWXqLrgX5RbhH/oEctfhht2tnXDT5FpTFU+Uz6BJ C3gNkR6vMXk51Bna8iJzQoADj9j0B6E= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-96f850b32caso519104766b.3 for ; Sun, 28 May 2023 13:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685304173; x=1687896173; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Zo6CAhX/gKpTGl7xNzss4y9YGs7PPZhQ0B+6ZO4rHpo=; b=lmyAX8YvijPl9JTnu/+1ez+IEbz4YIX0RKM0OEzi8J793Xt/s9RCgCl7j/nm2Ge50J kKYDFBKL9WNE87XQdkgWWJiFktlw7XZpElXXGp/XQ9XBJ1EFmxgWgCHelRV1wqjbdrV4 AngIoQgk1xxWX/Cdw3tiTOu4g1ZI6pWpjvF8s2ckLO5giUYibQaVO+NC5FdWYE4nenO9 +FHom1aw+edwFW6s0Y+QaUhHtRAifMTuj2HGIyRgmUFrjwIv9iMAjEW6kuEYYnhFO9tY xyLM63K5Zzg92QWMHd2aO4qscr9I2wK/Q8PzFPeH4rybNacWDLqFBFrmnjhi9BxQ4hIr j2VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685304173; x=1687896173; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zo6CAhX/gKpTGl7xNzss4y9YGs7PPZhQ0B+6ZO4rHpo=; b=ImWiq5ww56YA5OU7yGCmFUTZmI5TR4EM5clrSnMh447eQwJ4wcyLHPsXT6L8YMiL4n LoAoiiCsPAeC/QjJ/EID6fdKVztcwmipxRH1J3gwQUcrckdVuK3uKYZH33+LD26064jR qpWjqbxMfepilmf51A7FuUzNb/YXu8sDYSVrIKObul2nIXkk2LtQNRgzMmhjfJgM0uz2 5rGz51wp4u4Sp0kGXrcIG25Z+qzBC2mgqRnjLettOqmNgQiHAb1ffcDvM2erY6Idryt5 W3jAMcbdlJ0jTktBqpwo3yZ9D9aRqizJQvdu9IrVJjp6IEk8eP2ztKbROsmosDCefAzw mUQg== X-Gm-Message-State: AC+VfDy0Tglgfsz6N84/MpTe55O56tUrMDsgVLPyk+sK5X3MbgpClOii HAgr2Vs4yjqvyN6XX4bpbeM= X-Google-Smtp-Source: ACHHUZ7amSCeEjsuTpePFIraYwQK5RrXHcbx6rWKwrU9eJeY6Nyzlnvs4W+vU8kdZC3CUytueRKAyw== X-Received: by 2002:a17:907:7251:b0:973:d953:4bf7 with SMTP id ds17-20020a170907725100b00973d9534bf7mr6095191ejc.48.1685304173207; Sun, 28 May 2023 13:02:53 -0700 (PDT) Received: from krava ([83.240.62.205]) by smtp.gmail.com with ESMTPSA id v19-20020a1709060b5300b0096621340285sm5027344ejg.198.2023.05.28.13.02.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 May 2023 13:02:52 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Sun, 28 May 2023 22:02:49 +0200 To: Greg KH Cc: stable@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Tsahee Zidenberg , Andrii Nakryiko , Christoph Hellwig , Daniel Borkmann , Thomas Gleixner , =?iso-8859-1?Q?Mah=E9?= Tardy , linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH stable 5.4 0/8] bpf: Fix bpf_probe_read/bpf_probe_read_str helpers Message-ID: References: <20230522203352.738576-1-jolsa@kernel.org> <2023052646-magnetize-equate-2b24@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023052646-magnetize-equate-2b24@gregkh> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 114A040020 X-Stat-Signature: m4wg51f71wogt4gffi45w1pmxpesqkng X-Rspam-User: X-HE-Tag: 1685304174-931277 X-HE-Meta: U2FsdGVkX1/8uGCSRk7C7tNpvtpTPKGOubnamN0+bJdLU9SsoN+qVW0CODB64akryK+sbfEl44IDJPXEMB2awbKYC24MnB46xDQrrqoQHeDK4vlPQ++rZ+AnURv25e0iGo8oybY32hVy7Ve0tgDJ5n77qrBtRNqnpyXnRd2Kru0Mh73GyO2arA8dxSKmJHIJZFNTHUrC1O7i53RkhsOFQ2jwDHRW9/8zKxU+DE22LQcAShmJYvMyH4rrEkXeh4arjElmx23LiPgddPxIRTUcBVdz7ZLi3MDzEI4u7SNg8Wg53wVWN+/y+A7x97sqkMODToin4snbqHQD+H5MuLXzAMfWe0Tw3gjAvRWzeFlv90iRYkZcQdJR6h6N2mnZwiwJGsuz18voMw6CQJm9qTeN9kM7yRrdkOPxQsfAEJsRpgjimY4Hy0Mp7u1aOjM4+psN6YYCqGBG9DXlgwH3IdiSDINTZYcYDmya9PEolwmhiNymsbJW/2AF3QXli/yhKhHVd/QNILG3g9Uaw7CGH3Ss7yFkBr+lV/N53BYbbSsba+IscdJK6GD9jkXVInafHQbQf2iuUGJGsCzzVcQiTuuJhnVq+buQOSGfy+Lh055IkhUUSr4bJVCTOx/KRAhz8bHJI+s1elwI8DpBuPKS92MVFCU2pk82Tf+RV42NdwB3T6OhkXm9UiJ6BZBQMRVw6FDsEREWahPqnNYx9W7uKAtyJ2tDJwzBvdwvigp0UPIfVPICAGNEb2JCHklKT0qYEm41UwnZAGqyQwsBQlKTToIzDiX+4QveB9DXvgS7n/U6M5jlDMjPseW9WtQcKOlbZZ3XIGnL9GEDp0znFlpkZoYtyBA3JtgvAD1iygpxYhJFpHIwdofmbuOPLb3OXwtepJHVPmXexYRCmLkWRN4KfB9+6ndU14BR2xbK4pZWE7Db4y7mf8oYCvO9+3RgIoe/hBZHIL92Jj1C+GmNiHQRmdo 91Mjh8pQ YVWE5GtYHeOqlhE4+gY98/2KZ8+xhRpxXyGdXZC5nlUFDsXwig9hbAf8JQOC11TgT2QZqEVOm+T4y7bxEvyR2KIjasPsP4Ll9SJgn6fzmPpeI/zSvln9LmQOm9Kvt6IWINLFdtZN6A8yt2ohbVQFap1r4J4FBd0tr0kcwj7owvps6sheLyj5ceweOBw3j/+yW/Cos2a61I1HPQq9Rgx67mgfPB9mAhYqSAtIdTlcQS5DceJg84c5a6/y3n1z5mr/Yo8HCjQjl5E4Q2PeXuat6uNy0hcKXPF4Vjq+LY+qiGLdXcqsmZXnGFoH2h2BY4m39dg1v3E59V8nA/2gt19xM4Til6qTVdYqZEYpxrQm5eBq2ovlqUJQQUBs1FWoUxiaH4+G7iWgZWRwt0Js4Ll7tGH2tGAOcL0QEKXQL0llG24SzS9r2qtwR2lAWFYPBC5yrlYLiO9WjjVwFleOlCC9Z6YbQkJ4vr7L1kdeM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 07:54:17PM +0100, Greg KH wrote: > On Mon, May 22, 2023 at 10:33:44PM +0200, Jiri Olsa wrote: > > hi, > > we see broken access to user space with bpf_probe_read/bpf_probe_read_str > > helpers on arm64 with 5.4 kernel. The problem is that both helpers try to > > read user memory by calling probe_kernel_read, which seems to work on x86 > > but fails on arm64. > > Has this ever worked on arm64 for the 5.4 kernel tree? If not, it's not > really a regression, and so, why not use a newer kernel that has this > new feature added to it there? > > In other words, what requires you to use the 5.4.y tree and requires > feature parity across architectures? we have a customer running ok on x86 v5.4, but arm64 is broken with the same bpf/user space code upgrade is an option of course, but it's not a big change and we can have 5.4 working on arm64 as well I can send out the change that will be closer to upstream changes, if that's a concern.. with adding the new probe helpers, which I guess is not a problem, because it does not change current API jirka