From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A2DC77B7E for ; Sun, 28 May 2023 08:01:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 884EC900003; Sun, 28 May 2023 04:01:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80D00900002; Sun, 28 May 2023 04:01:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AE2D900003; Sun, 28 May 2023 04:01:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 56D59900002 for ; Sun, 28 May 2023 04:01:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 084B01A0158 for ; Sun, 28 May 2023 08:01:43 +0000 (UTC) X-FDA: 80838919686.16.9D94EDC Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf17.hostedemail.com (Postfix) with ESMTP id 2CA8C40008 for ; Sun, 28 May 2023 08:01:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=aB6AUVem; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685260901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nnk7TlTM/Wbfy2rV0HTVA/14uFq8iFlDRl192AP+Xlo=; b=ypqrE531LGl/+YQFGL25XR6sNVQOFBeQ6BiI/SwXMubhDBavRBMMSMGX7ow3V0j/yBnNNz ljSamsoJj1q6KmoIMMUFDR9+OvHoYsXJ+Ja0JIXIRr2vnZNwJ1CukOULVoYdo9sPvGXhIe CFQqE6LZ2jupyu+R0gnbSGENpRB07eo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=aB6AUVem; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685260901; a=rsa-sha256; cv=none; b=cST/DK6pxZuXRSEOSf/qgehjikGUi5PcjORZvl+rpJz0XyIGLChSQ4+XhXhwsQr3Z9qfpv WDnDlOjZeOSAdpIxUSZurxqZW/HAx9AybWdP0uZ0ppgX8Z2ut9wxKtKFlI8PiElNnrLDA7 HCljnziZDnI1S1xMvFMyIGItyCEJpDo= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-64d30ab1ef2so1751940b3a.2 for ; Sun, 28 May 2023 01:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685260900; x=1687852900; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Nnk7TlTM/Wbfy2rV0HTVA/14uFq8iFlDRl192AP+Xlo=; b=aB6AUVemBMjAbWbmB5Q28+VBsDUlMBjBv8koVgm+/bPfGIQmy8KdgsYl4w89EIItha L5JQljWFug/z3cc8pdv8Y3ibmtuAeEOu70ART8/FrGsJZ0npfkeA4IHQyBYpKT0ROuSQ 3UckbR4h9SMnHvNHe7Z+yDrCuPn7Q6BYpNMYui32O+QZf/F+Ro4qZX6kbyOG6bMIC67g BzxSAj5Lwf/SmlyM3MprmAL7lI/awYseIJinGnA8xLdPhUG+9RNpUlUeTIaN68EkiQlo UC4DNjwk3HkvbHfQECX65nU0Rr72cTDeDrQdmE8diPFpn0vlWJVoJqJu4mGFq8hgadeU PEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685260900; x=1687852900; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Nnk7TlTM/Wbfy2rV0HTVA/14uFq8iFlDRl192AP+Xlo=; b=GaB+V0jcaaDPkRTxLa7Q/rN5O3RR5TqX1DWOCqyBypRt69VlMhuK7tZmuUX5VyAV9h g1p8hVLnFDMJwQ/xcY7fHoEGAUmMEEDOC0jyzTleiMJ9eIlz2agy+VKOqxjeWnl8WROT SAIx7LTZopGvmnM21Jgyq0h09jyIYhw+dgkP8+2z0b+eIBVtAiT9UQOY9dDnMGoV2tgK 48FPxmwyZhnHL1/PP8szcxpRv1H0oBSulXGKmkyxYAKnLBSLtzGgKp24Pnd+tx3L/UM2 ZZuTbcM+vyfFcjosH50cXMgmugIXzJWM3O4Kb9dgQV+s1vP1WUQQ2l+RyGQvpgewzrOB 82MA== X-Gm-Message-State: AC+VfDwl7Z3u20PeaEPr/j/XmYpfaCLAiRQyauhJF6QAYcRri91OI2Vw wvM111TDcSfEiAoAztDq8oM= X-Google-Smtp-Source: ACHHUZ7n1M4+Q+QSkEpvFd9wVAWB1Ani4gB8NW6jSOhXYNNoO+WvA6qn4f4TsuSlLEzGgSYjfg42wQ== X-Received: by 2002:a05:6a00:181d:b0:64f:3fc8:5d26 with SMTP id y29-20020a056a00181d00b0064f3fc85d26mr11868166pfa.9.1685260899540; Sun, 28 May 2023 01:01:39 -0700 (PDT) Received: from debian-BULLSEYE-live-builder-AMD64 ([2001:2d8:671e:2ff9:fac8:1735:2e11:d6f8]) by smtp.gmail.com with ESMTPSA id x19-20020aa793b3000000b0064f97ff4506sm3900137pff.68.2023.05.28.01.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 May 2023 01:01:38 -0700 (PDT) Date: Sun, 28 May 2023 17:01:59 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Matthew Wilcox Cc: Andrew Morton , Petr Mladek , linux-mm@kvack.org Subject: Re: [PATCH] Do not print page type when the page has no type Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2CA8C40008 X-Stat-Signature: zait7uygsxkruzsqk56g9kuuj9qwzdy7 X-Rspam-User: X-HE-Tag: 1685260900-191164 X-HE-Meta: U2FsdGVkX18iHvGzBLcD30RmTcaptPdyUX6qO9fiGUNQjoPAnCThwnNwEYf3nm+9tMQzjUY9rmabM0eG13/6qTa6lFsFxAok6pzFHu4OupDDL/Vnaktj/O2gb7VItcw9mEoHs6w6RaVg7bmtM0A+tQQ5+jtkiM4Qy1pNx9aKJ/WXM9IP1K8T7M4EU1SRe9xsA1ZTHMEycP32PxWTlr/jEF2G7pbpZQr/0PgXOq8E4ee40BqEvsSLIhpf9Fbk71gsvCOo5+4GvEH1e2FSQ8HtSKreEqC8qrqI1uAq0XkNysdBhwg7dAMUUXhs2RpnKzocAyjQqv5fSjZB6eb3KqsujTcIHvTei/0H/NDlVAKeK23HdJS6Co7TwGL54LiTHH7xmBqxubE3jRaL0RdH1ZeACaf+EkzJ4Wfzx4vpnHKNbIaoTiDvymS+B8guwgHw20rlul42K4IW/8eoy50a7Dp5qthhj5ZjOh4vtvr3DNheylIJ//hXg72+sUP+1t+VPi7SyXpQbWj+JilTELTnuGPP9eK4imKOVXTWeOfsgqqi1DOBxX4JsQFDtEFDFwb0eUBklSkFpNHaPuGu15kNqwstZPfNsddfjuYEu3l/4/BKn7PIntDjB5kZzMnXzxSiFLDe+qr0DkiT9baELZW4jypZv6/NYmMpIOYgKlB2LgspAYPsPzwfDf2tI7ua1QaBe7Sq9wk6Zl3Za33wYUAZ3D0PIjEatwGP1n1ni9F7xSaRFEY9sDo9VXzmdPphzdtuNBUf9EWjI8ey+faWZA7nlGivA9AXOP8kcmuGQsaYxR54J6OweEcqK2CelwXMy2C2jEom8EkeRblYPny4ja5TC5u/UUJM2o+6sYpiEYl9zhJJ/VsT+JcyD3LR9+3MTKGvy4hWNoTs7BiKqxtCvWJT4rvk9VVP41aSFGvEAJbMfNq6GOzFO7y55EZpT4VsGGMr0tz4UItky9VlcS0EmhCi1Nw YgfEofJp Na2uhbQ9tkqHTfWLEvnqYEvmEnK89+efeIZC1OKA637raEztZ80jaHqG8oGSccavy+nsGVVJlyGgSLQBceBh4Nfy5sniblk+A5MuxRMMZ1MsuhL7YJZoWmLkF1LpJddiDP3slRQ6iOk6JpXaFu755Z6QJieaxb0C7EtvQQPzHDyScc3O9NGR7TRLSGa6vGTTk6c2Mtp2H4xCDkzP6aDaWaRECEFxWRsuK19EPjJtTU3b1G0ro+/AppEe0chB3IwQw7NJW4u6Jfm+2TH1HMVuNwnI4Vbo7EN2FiOPE3RvMEYP+XFC13h30rqzil1WjMV+ANk8WbuHttHEdvWcbEyc4EcqUwCIzwLz/XaoDxJcDWhi8FfipRYk0RH+kJBMpxXVjmI0W9c4/lUTWi/xhCEUr5kz62FD6M1zQk3JRMnfByoaOtB7FH3/Xc7qZTOsjZ2/2UEHF+Gzx6zatzRu+CUzqa9dodvog3Fvml+QySCDT1fbdCK7onfkX+R7n+ha9vFRPmIaqApMobwvZWYLem9fVESpqopgk9Kuezvxscs8Ggmxtn3hcLR93WN0cCdcsISBrvdJ+0BlqbItZfiKlkwVE2TKRIjIQZaYDNNhOKQjGN4dlaMfdkixZYTFQ1/nPz7d/Idpy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 27, 2023 at 05:48:32PM +0100, Matthew Wilcox wrote: > It is confusing and unnecessary to print the page type when the > page has no type. > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > I did not run the test-suite. I'm in the middle of debugging something > else and this is an unwelcome distraction. If this doesn't work quite > right, please fix it. I ran the test suite, and a test case failed: [ 1.001641] test_printf: loaded. [ 1.001736] test_printf: vsnprintf(buf, 256, "%pGt", ...) returned 41, expected 5 [ 1.001738] test_printf: vsnprintf(buf, 2, "%pGt", ...) returned 41, expected 5 [ 1.001738] test_printf: vsnprintf(buf, 0, "%pGt", ...) returned 41, expected 5 [ 1.001739] test_printf: kvasprintf(..., "%pGt", ...) returned '0xa(offline|guard|table|buddy|0xfffff875)', expected '0xa()' [ 1.001774] test_printf: failed 4 out of 432 tests The code mostly looks fine and the patch makes sense to me. But I'm not sure if it's a nice behavior to print garbage when it does not have a page type, although I can hardly imagine users of this flag other than __dump_page(). I'd rather keep printk part unchanged and add page_has_type() check in __dump_page(). Thanks! -- Hyeonggon Yoo Doing kernel stuff as a hobby Undergraduate | Chungnam National University Dept. Computer Science & Engineering