From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B71CC77B7C for ; Sat, 27 May 2023 10:22:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00B32900002; Sat, 27 May 2023 06:22:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFDA36B0072; Sat, 27 May 2023 06:22:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC678900002; Sat, 27 May 2023 06:22:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CD0E66B0071 for ; Sat, 27 May 2023 06:22:11 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 606B91A0224 for ; Sat, 27 May 2023 10:22:11 +0000 (UTC) X-FDA: 80835644862.19.38F2BD8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 3FB4840015 for ; Sat, 27 May 2023 10:22:08 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PwYRDrw7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685182928; a=rsa-sha256; cv=none; b=qArf/d8suMu76yzGfHzch8ADejbaSKftMBcoV8gSuH/D9A/Q27o34gZrvEG2ynJ1cLGqVS hYGV0zgla6PwKJYC6QyeckSqNuM8tsuBAmOfZpD1ffxZN9ACyNgo/WxdL/GxeiYfHetwQS o9XFx4qKJbHYqwkHbxLbVwrYAvj6O3I= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PwYRDrw7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685182928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m6Gi8gvZQrJcgF5Hk8FfCIBk4UGIsvNtfxUifLZyxl0=; b=7DdWdkOeKHa4338V5ZRB1HwmZW3Feh0s1/xzdwLEpkYMnjAX1H1nj+38JHluOQeqSJ1eUM vC0s+OctVI22a73w/TGVg+d+fer091v6J3H76Pd5YIL+UzYz2XpKQXKUC/bEndNwWvYH66 xTPSaAlQR9w3d1VmPkLOZfFIIvp4WZg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685182927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m6Gi8gvZQrJcgF5Hk8FfCIBk4UGIsvNtfxUifLZyxl0=; b=PwYRDrw7wmRqtfnsnwMijZhsgCyQGlXoYVc6jYlWARsQxDPjroJYgQPg2K7Q/Y+yXIa1Wu LoArR2P5YhyodvXIYEHEhLCICVDAx6M77GeBIKQjYEKiuJbmNFZyFekpLKdoc4+Rhy73a5 aMm2ptK4uSLaihhRbKhCfQG45ljj31o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-317-fS6IKMVQM8OPTFFrrvgTGQ-1; Sat, 27 May 2023 06:22:04 -0400 X-MC-Unique: fS6IKMVQM8OPTFFrrvgTGQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CAF8B8007D9; Sat, 27 May 2023 10:22:03 +0000 (UTC) Received: from localhost (ovpn-12-70.pek2.redhat.com [10.72.12.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A67D53BB; Sat, 27 May 2023 10:22:02 +0000 (UTC) Date: Sat, 27 May 2023 18:21:59 +0800 From: Baoquan He To: Thomas Gleixner Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra Subject: Re: [V2 patch 0/6] mm/vmalloc: Assorted fixes and improvements Message-ID: References: <20230525122342.109672430@linutronix.de> MIME-Version: 1.0 In-Reply-To: <20230525122342.109672430@linutronix.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3FB4840015 X-Stat-Signature: ffs8tjg1x9c9rgd34axy1dr7d8u5c1pk X-HE-Tag: 1685182928-291553 X-HE-Meta: U2FsdGVkX1/jSx8uFgX+Fp6UxGegfQKqo0h3/u090M5YPXyp7Ia/v5x0LjU/P51eUs8ebHwaS1wEDB4/ib9RDAGg65vfXZVVfYqPZ0q+IPrn3utvDNsvBmy+z9wIWP1h0icAX+z2eDU7z+50q4h9R0vONj8vQn56P0FwvlUWWyvLVAzhvX71bUHyMOqKx16R37qRQsfTkrQiLqG5fFGW76dP7SlEf+19NpBBBvI1+ZR4y2yexoCLZTSbq5sAvSrkoPwcWsS39bmQpgBFa2qi/T81LHUaBM0L9Hew7McAZ7gzO+B69PAgw5/cj0ZseVvNj1udbWeyJN7LBlfbmGFf+IeXhLRDFGwwZYqHnueAqW5IjEl1Bf3ejBEr+5st5vrCrQc+iDPz1KyWXYIsv7v2m0gpElYDx8pS9lBQTzL1Lsdxnzgbw07K6DnzD+02JhX22EaMT/aia0A162v+uD5eTXXUzu1M+rkoURG4D9plOx/kSwHnr40+54wXhNhp2k3eAD6gQMes+vMPxby8dNGrzU0SfEZjxcQns4jLZRQC47Sz+FjOZ3yX86+7OvgYMIh4iPr+s8MW5g25BZXUC/a/y6y9AdTspWqHU55DJ5FQsSMjIbyq+Wcs/SxBBnhoDFfNXyPtpR+8AAArd1av0p4QbldSNEbvJbRdeAQ0nhJFP1Ze6I52ihWKAhWZ1tR8LzrgZ2QBZtl6odAAVZSoQYKvs8fhh5bIs5ftA32prJFCyVZSIT4oNAt3k4hSnSLqUmOHY6izx8IWe8yefTCm+SklpX09HA6M2ZzYbKcaRm1NQ13BNWrvKECbQACLYUoU8QcAkwhQiIyXoo7q6OE0CsHJZGsO5WIM9EYYgLyP3hzxoDCjOyY4NLar2HsPoD5KBtJEH5xsVRMbW7GzMgzlsKDlY1emq5ehe4h8FcDjpChaDcCqsAeVSQKQKnPT0kMnuKydtX/boOHhn1SwuNJpEg1 CQvHEu66 NsOhnT9RHXm4mWJmdr4ozNCH8rzgKVbkOSWGd23P0HCr5+QmrNT9sL1t3Zg0NOp8OV4eaR89OLyJRXW4jDymNj6eg1bL5tUCr6HdzuhmjV+Z2tcv+ZOD7ZIsuu5rO9YZXANxLjzmCE/dR4BccyncIVsYsUJ3XeH2zC2/bxiuHH0CEYluMWeJJTVz/pP9PRGHD7CO+2LfmYppth8qPDqfmnLKDgu59TxlKfiQmA3Pv8vwDb0Or5mV3JEZHkwXd+OL1ql9QTbK1I/9kNcENizD5EzsgSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/25/23 at 02:57pm, Thomas Gleixner wrote: > This an update of version 1 which can be found here: > > https://lore.kernel.org/mm/20230523135902.517032811@linutronix.de > > Following up to the discussion about excessive TLB flushes > > https://lore.kernel.org/all/87a5y5a6kj.ffs@tglx > > this series addresses the following issues: > > 1) Prevent the stale TLB problem related to fully utilized vmap blocks > > 2) Avoid the double per CPU list walk in _vm_unmap_aliases() > > 3) Avoid flushing dirty space over and over > > 4) Add a lockless quickcheck in vb_alloc() and add missing > READ/WRITE_ONCE() annotations > > 5) Prevent overeager purging of usable vmap_blocks if > not under memory/address space pressure. > > Changes vs. version 1: > > - Coding style issues > - Remove unneccesary force_purge arguments > - Amend changelog of 1/6 > - Pick up Reviewed-by tags where applicable The series looks good to me, thx. Reviewed-by: Baoquan He