From: Baoquan He <bhe@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Uladzislau Rezki <urezki@gmail.com>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [V2 patch 0/6] mm/vmalloc: Assorted fixes and improvements
Date: Sat, 27 May 2023 18:21:59 +0800 [thread overview]
Message-ID: <ZHHZx34tNAOwakxo@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20230525122342.109672430@linutronix.de>
On 05/25/23 at 02:57pm, Thomas Gleixner wrote:
> This an update of version 1 which can be found here:
>
> https://lore.kernel.org/mm/20230523135902.517032811@linutronix.de
>
> Following up to the discussion about excessive TLB flushes
>
> https://lore.kernel.org/all/87a5y5a6kj.ffs@tglx
>
> this series addresses the following issues:
>
> 1) Prevent the stale TLB problem related to fully utilized vmap blocks
>
> 2) Avoid the double per CPU list walk in _vm_unmap_aliases()
>
> 3) Avoid flushing dirty space over and over
>
> 4) Add a lockless quickcheck in vb_alloc() and add missing
> READ/WRITE_ONCE() annotations
>
> 5) Prevent overeager purging of usable vmap_blocks if
> not under memory/address space pressure.
>
> Changes vs. version 1:
>
> - Coding style issues
> - Remove unneccesary force_purge arguments
> - Amend changelog of 1/6
> - Pick up Reviewed-by tags where applicable
The series looks good to me, thx.
Reviewed-by: Baoquan He <bhe@redhat.com>
prev parent reply other threads:[~2023-05-27 10:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 12:57 Thomas Gleixner
2023-05-25 12:57 ` [V2 patch 1/6] mm/vmalloc: Prevent stale TLBs in fully utilized blocks Thomas Gleixner
2023-05-25 12:57 ` [V2 patch 2/6] mm/vmalloc: Avoid iterating over per CPU vmap blocks twice Thomas Gleixner
2023-05-26 7:55 ` Christoph Hellwig
2023-05-27 17:38 ` Lorenzo Stoakes
2023-05-25 12:57 ` [V2 patch 3/6] mm/vmalloc: Prevent flushing dirty space over and over Thomas Gleixner
2023-05-26 7:56 ` Christoph Hellwig
2023-05-27 18:19 ` Lorenzo Stoakes
2023-05-25 12:57 ` [V2 patch 4/6] mm/vmalloc: Check free space in vmap_block lockless Thomas Gleixner
2023-05-26 7:56 ` Christoph Hellwig
2023-05-27 18:27 ` Lorenzo Stoakes
2023-05-25 12:57 ` [V2 patch 5/6] mm/vmalloc: Add missing READ/WRITE_ONCE() annotations Thomas Gleixner
2023-05-26 7:56 ` Christoph Hellwig
2023-05-27 19:06 ` Lorenzo Stoakes
2023-05-25 12:57 ` [V2 patch 6/6] mm/vmalloc: Dont purge usable blocks unnecessarily Thomas Gleixner
2023-05-27 19:28 ` Lorenzo Stoakes
2023-05-27 10:21 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHHZx34tNAOwakxo@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox