From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C50C77B7E for ; Sat, 27 May 2023 04:01:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B96AF6B0074; Sat, 27 May 2023 00:01:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B47946B0075; Sat, 27 May 2023 00:01:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3569900002; Sat, 27 May 2023 00:01:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 93B516B0074 for ; Sat, 27 May 2023 00:01:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 541451C819E for ; Sat, 27 May 2023 04:01:09 +0000 (UTC) X-FDA: 80834684658.18.50E9CED Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id AE5F5140006 for ; Sat, 27 May 2023 04:01:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vtTBlbTi; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685160067; a=rsa-sha256; cv=none; b=qWQWeBLdgOPcHofEpIX2YVNrSrYfbhzJgllOWWEQI0Z84Cgx7F4WBI1gmVIoKP9iIvlaKc 3ULQzWm56XYjml50IBJDlxd+qlwWqDg74dNHOZHbnV8gEJ7nGpg5+J+6AiFwEMqXsX17Jb 9uhShVNXuvD84sq6sL1oFSj7c83JdKw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vtTBlbTi; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685160067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a2xCe7O7+yP7S2jBW94Ky2TVFSCOtAAD8aGSKVZyuo8=; b=ZfIesBwXRV2tslw3H5jvINEYGPLZoVBiqy4cpK3O41r3j0go61K7NteEhJjIWh0K65qvzm IWirIIfsmByJTocVK7ckS5yQapF7jiBhaCcY/aPtExYPzmgwXvFHwAueZs1/PO/DWyn5LQ HIlUenDSWG+hWfNjGp3g4GkPE/qrE+k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a2xCe7O7+yP7S2jBW94Ky2TVFSCOtAAD8aGSKVZyuo8=; b=vtTBlbTiGVU/kW7m0r2iZikpWF uHBfF2vaPo90m14jsnj8E/gfDUNom13R2UQzaU9KK8HjdYfF+YfzCOsLAD/7giYmZfBf4Opg6+RpV kopdXnQtBJdG+sH/CJDrY0A5IYTbRoxymJVHlmEZVHQtSxyJ8cc6dwVIPuxkQkjfhyir+UY1GB9/3 Bm1GXtLYPJhxL55jGH4HFVOO3u2Wm4u1QKsr2ZZs+hp4LQTCttR4KEecxjjypBV7hyDknRnrVIL0O 7c8ufJqP4v2QyS/LZtTwwYojlqhYIBiX84U0Rf40AjON56IPWAfOj8X1EL8J2xsQCulIkFRstpunW 1qhvegUg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q2l6n-003VTr-DT; Sat, 27 May 2023 04:00:49 +0000 Date: Sat, 27 May 2023 05:00:49 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: Vasily Averin , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: remove unused mem_cgroup_from_obj() Message-ID: References: <20230527103126.398267-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230527103126.398267-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AE5F5140006 X-Stat-Signature: tg447spqybnuutaab1kz8nwba64spx6u X-Rspam-User: X-HE-Tag: 1685160067-835949 X-HE-Meta: U2FsdGVkX1+iCy3M15yfIRozVBL1JyT/dJuQSwZm4POiDS3CKZ2/RyeCW7lsKoS7WKSldF22etinQ5cfynB/fcZIKh/t7+TCR/B+D+XOH++8Vj7DMIb/6xT27EXIAGBIAhA1wHA1daCD7nHW95E5PT/zWCqis1W2hgWSgic6FIa0AXvj3TSoPjE00WvnrU//5SbVARTML2co39xyNy/3a3aRRo0OH18KrfZuWz7zha3m+o7RyyUYtAPAoBfr0r+yWcZ0zC3PAZ5cI0JKH02q4yBZU+47B57h59fGKi27WBNwoFfsAdXSTVU9LSQItcXywLxTLcZeEypK2aKLyGf3qGXBbiKUmlJ+TRfCEcyjxsaoaOtJJZYsGK+rzcpznKEZsNYD2EOrskKSO1q7ytYvCKJGNn/vrq3V4c6rD35aUm8pp99tpanxGOWZeTztPc/k+UTIABHT2hoyrTh+DU6xya7ceWrF6OMUXeK5qWthyGJkGmoeR2tW2+wE9cY+JqLTYhVOxOCEDIDQqpRVgHMgUZHCH7Rp6WTReWL9A9Emm0FtPEX+jQG7oxkt7NE9abCbl4oQNRvkbqztIsMPxJWYwEV1/hGmSgGd0XuUDlOJpOZGLYRDlFsXlqxJmlyVN0hAu2FiRzlzTBH5VAG0oVJ7Y/CH5JiEY35O9mGL6CXle0W3xnAf0BESN9FU8AF2czDFW7I9HuBqpW9W6Nbaq2Z63aQkEsfXrk+ogzuA9Mk3I2bTqm8oRy+u5XwGnLUVd9uAxX2P8cTkCO5dqScSR0rWiavI1u4Ah8mQQcaLlEJHK7lKfEuk923gRRQEYYg4fcwmPtukToygvm3R+iHrihC5kWIuL/tYQqIO18JHsaltV5F4eVatDv2DxYjQ2pPGlNAQvGWkBZzUILimFET2RTxa1jv19Ougox6J7KpMQ93rXsQNo/2J6W298NU2Ow/ZLyMb54wjglS2mlyWnJ5B5Lw SbmMj+hO wfI94oFYv80Nho9yf7sOunmYyhrQStIUGIVN0PsQIUF65RAC5yWOh3K5JBlq5PtCKWxGVypwILlcSIaH8wGjY/XrAbxp1NR1WId9KtkUxCuUCDvg7GWPz5/VPr5HfZw0ht02/u5otVNT0dU61ZZ9y6qMOPZ2TOwvah2r0/QaL2zytIsdw7n5hmiyrQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 27, 2023 at 06:31:26PM +0800, Miaohe Lin wrote: > The function mem_cgroup_from_obj() is not used anymore. Remove it and > clean up relevant comments. You should have looked at the git history to see why it was created and who used it. Shakeel, Vasily, are you going to retry adding commit 1d0403d20f6c?