From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87D2C77B73 for ; Fri, 26 May 2023 23:03:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09379900002; Fri, 26 May 2023 19:03:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 043B06B0075; Fri, 26 May 2023 19:03:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4E02900002; Fri, 26 May 2023 19:03:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D145A6B0074 for ; Fri, 26 May 2023 19:03:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A312EC02C3 for ; Fri, 26 May 2023 23:03:28 +0000 (UTC) X-FDA: 80833934496.25.8CC0B77 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf03.hostedemail.com (Postfix) with ESMTP id CC32D2001B for ; Fri, 26 May 2023 23:03:25 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=FCDdoQ9T; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685142205; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LfueZcPSyhu8TUF72Af0Wy3gIHyGRRQDvcS9MbJqSWg=; b=sb7KRnZjQ7wNj7tVxCApsg1j8kMWTT3VaqwvKUBKCHyUdSVTWkwnrymooXKFw/P5cC20jv gXRPB+SXpzmd0xsWeZMwS8Q3keVpCHm5Jfk0u52gj52GQfb/BdxlLCanTEwpGLAi9RoysX C2Rr53mjiP8QNXKsDUqnxE3IrzcFRgE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=FCDdoQ9T; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685142205; a=rsa-sha256; cv=none; b=p9dIb4RWoxiU3hIh5UooVgIdmrFXG6yy8F2t8O+ntsMAH/LV+3dbr3FaWP23xyoXZsoCtU h4hOQ8jMM0IWK38qIVD9lUOF3oPCWUoRQsMS47RwmPFd0snNcqwlSbytnhNL6H9rtEevE8 eMhSWLg1Cu1wP8Cw1+S2aQZ2uXv21ko= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1b01d7b3ee8so5565335ad.0 for ; Fri, 26 May 2023 16:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685142204; x=1687734204; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=LfueZcPSyhu8TUF72Af0Wy3gIHyGRRQDvcS9MbJqSWg=; b=FCDdoQ9T8cOC+RkskAGYsQtH7vWGpY6mvdDgDRWXSznwYAzGQeArsJ0h4TD9ZRfuUv yVQAVvSxZtaMsIpBbNFo13x2jWrt77QIk1HpIN8gVaJeoRzLNg0THfazoRNrF8whNF+n YsssqI+tYp3DwHvFnl0m3ZxArQM+WNitB5eilp++plop6Np0NiEWgJbK4D1OsgORBaHL VQh1JlnWwIrJgEyE0wViwe6uw1zNXJWf1dFvsOBkTEGiHnW3yIRdc2wg/GbszCFDfV2r lFE/ujraQDyD1rCrJT9l3mNy4RrGBzy1QJ5DT2IWuUvf9uO1BRvMaJt6BwUBU+cVQFIz DEiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685142204; x=1687734204; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LfueZcPSyhu8TUF72Af0Wy3gIHyGRRQDvcS9MbJqSWg=; b=anatqNCmZOLn77n/dmHFtX46z5DRWDcbihlpT8ZABHrmF1DJDyx30AiRoGiZBu4ToK it1Uewd/eBXCrNHGyNpzUJNJ+JxdCXDRv8l82HTXefp7jUIU6ipIHjGIlxFSKnN+6bR7 RtNxd0jcSHLOpZrUnAVNtp8pduCVL3KtqdY19UMVNyYxfTJ0GqJFYTX8XR4qAa0J5opZ rDlk1yh8JNUc5ozENeXV1xC82S88xN/jwT6CV2wQBrkjq1va+DD+fprRmWAT68leEaoC RsutT2eA76rdrxjSwegOmpG6cHHFLNzwWMqRT/MoKVmmbcaL601hP1ApVCxi7s+D6xc9 8FlQ== X-Gm-Message-State: AC+VfDyfsiVNJOxFoIVLH+1Vdt0O975OxBxqG7E53eguwM/TrD4uwT2q 20r16I7eFMiTQ2917JETDfo= X-Google-Smtp-Source: ACHHUZ78TNaOLqLX0ixU7AqAVQaXmPIDSeHFWpC76lP5bkJGQVTH2iMH//nx9dUMBRPpUX9H5ep8GA== X-Received: by 2002:a17:902:b18f:b0:1ad:fc06:d7c0 with SMTP id s15-20020a170902b18f00b001adfc06d7c0mr3813622plr.1.1685142204347; Fri, 26 May 2023 16:03:24 -0700 (PDT) Received: from google.com ([2620:15c:211:201:730f:f44f:d34b:ecf6]) by smtp.gmail.com with ESMTPSA id x1-20020a170902820100b001a5260a6e6csm3724191pln.206.2023.05.26.16.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 16:03:23 -0700 (PDT) Date: Fri, 26 May 2023 16:03:21 -0700 From: Minchan Kim To: "zhaoyang.huang" Cc: Andrew Morton , Matthew Wilcox , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCHv4] mm: skip CMA pages when they are not available Message-ID: References: <1684737363-31554-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1684737363-31554-1-git-send-email-zhaoyang.huang@unisoc.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CC32D2001B X-Stat-Signature: sygpzkwimnh1tnz1tx89sm348yk7syqs X-HE-Tag: 1685142205-590080 X-HE-Meta: U2FsdGVkX1/MrocIzCgo7j38Krq4jVduArZ2GiGwwTKDS3yeTQDy09PErRkBUHlwmOcQ/sskA8n+rh0veyKtlQAOz6i0JL8JkbyIb00WzcziTvCd06GrBAiMwPsM4RdkrCg9WzcfayAxIuOfhJu/CvnyuTB5Srw8DZrYGN00+mhQfUJrZbRl5jeQjdHwa52ljlT9p4kLqFKzo3dfQG1XAwjnBE5CG3qpHPqry4Spd2VfYsnT/zHVBGPnU7NhDLC6/Dd88WrrLF8C/JsP+rvkyL5KgKnv62DfUo2rnRSkMwYhjSEiaax/72L9hOmcSAeX/QTClM7KxjItDp3Mv3utK2FxXE6KKbCd5QmbCTOmOaEw6Ejf7QVIVx3TYf2tQqxBWa53t55764cNA1JUk34RzD7GSJsD9x85BnzFL+T2BUgUKM6sPDZeiO21FkpoVOvdLGftw0Aslh8CuelWStLa4l2PxrORGibkZcESxuLqYTOmg/D8J7CV+TGAYXW6r4oxRQcaQ3HRPxv4n7HbWH7Tern6aMGOMUoJD62VdAFPkqF1gxBHfk5U4GNpYk2E4n3SjhcBxc0+GuP+00OLFhBahw8h02blUGYARhnAyjbKzhHfAutnAUT5ed4SJRoNDAu3WqkAUnPFLuOafjIBuEpm8YKwdeG21d2eF4sO0KvdjXDc6FndsygSBNPXxoilzKyKA/iu3APiDwPe20oAPQNc2N+EvOadfKTIi40c4iVSaA8oScjUuC7tl4hwbC1OullwvYOaYu0Qo/R+BJv4gXedwLvIXfWOcms21fV2kTBRj5fcIg/ScvFf995V+XjKuyE6V2GACmRr5nUz05ks6JPJYhc/HUtEeZdvt3d+0LdjkjeyrbMym7q3/UFWWM6rKnxyimSjBtjWTc1h6JfqWd6B6Z9IzKh+sIyav1gBGnMTxakKOskjK7E2HCpwvWYNY9dGP99z86AvDUCR+5T98is DnUff6CJ CkSqtA5u9jhZdOZV0mDjwnk3L9OFUjUTDZzcGdwti1A4JZ1eg7RQyZgeDz/9QYmodiTugeK+0LKmPbAAJ4Zz6PzXbhE6qynJ80e6KnjTZhQgUxTOge7Rjn94UzVktKnxhcZgEEvB3Uy3ZSE0P/rKle1STwbc9fbLeeH+3pgPdbS4lnXKwkJyR06ZE4xUkn3qfuswvbmPuHg+vU/qtsLKLpajg9pYkUv0QMK2McArghVKzrdR47dujxrU+noOItPatOr7BymLWzibbB+/+e2zM6VI7xqAWOZWVs8M2T0h3+y8khIvBs728AEMH6DQ2NbUgCIADGOJRnQJkt9ZusiZGq+nQFxpSgjekbbYHc5GLDV6NR+W9KAhcUmnyAfluS6K0jnSOiqECMOHg4L8Z1rzpmP0eSa2ploLujeb0+1drAnwySC1E6h0iSY+JJq7p7FapZEMfnaqg4YgWT8gHDrxD/ZB5maiBv4tYtPeGyl2xoEwt1ffX2HFovHKVyia6jvBalM5cLUuFTmuOjf84f6otJN6OBbILZtcP03czop3fPhLe8wtm3X7oP7A9uY9OJum6sen3UUTGCzKDJLvv8C3qPT01KFpEL+ldr6bXqyVHOkkyFGYXkrocLrrEZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 02:36:03PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > This patch fixes unproductive reclaiming of CMA pages by skipping them when they > are not available for current context. It is arise from bellowing OOM issue, which > caused by large proportion of MIGRATE_CMA pages among free pages. > > [ 36.172486] [03-19 10:05:52.172] ActivityManager: page allocation failure: order:0, mode:0xc00(GFP_NOIO), nodemask=(null),cpuset=foreground,mems_allowed=0 > [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C) 217*16kB (C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB (C) 0*1024kB 0*2048kB 0*4096kB = 35848kB > [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) 49*8kB (MEH) 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB (H) 0*1024kB 0*2048kB 0*4096kB = 3236kB > ... > [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocate memory on node -1, gfp=0xa20(GFP_ATOMIC) > [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, object size: 64, buffer size: 64, default order: 0, min order: 0 > [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs: 3392, free: 0 > > Signed-off-by: Zhaoyang Huang > --- > v2: update commit message and fix build error when CONFIG_CMA is not set > v3,v4: update code and comments > --- > --- > mm/vmscan.c | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index bd6637f..20facec 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2193,6 +2193,26 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec, > > } > > +#ifdef CONFIG_CMA > +/* > + * It is waste of effort to scan and reclaim CMA pages if it is not available > + * for current allocation context > + */ > +static bool skip_cma(struct folio *folio, struct scan_control *sc) > +{ > + if (!current_is_kswapd() && The function is called by isolate_lru_folios which is used by both background and direct reclaims at the same time. And sc->reclaim_idx below to filter unproductive reclaim out is used for both cases but why does the cma is considering only direct reclaim path? > + gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE && > + get_pageblock_migratetype(&folio->page) == MIGRATE_CMA) > + return true; > + return false; > +} > +#else > +static bool skip_cma(struct folio *folio, struct scan_control *sc) > +{ > + return false; > +} > +#endif > + > /* > * Isolating page from the lruvec to fill in @dst list by nr_to_scan times. > * > @@ -2239,7 +2259,8 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > nr_pages = folio_nr_pages(folio); > total_scan += nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx) { > + if (folio_zonenum(folio) > sc->reclaim_idx || > + skip_cma(folio, sc)) { > nr_skipped[folio_zonenum(folio)] += nr_pages; > move_to = &folios_skipped; > goto move; > -- > 1.9.1 >