From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B31C77B73 for ; Fri, 26 May 2023 18:42:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFF6C900004; Fri, 26 May 2023 14:42:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAF32900002; Fri, 26 May 2023 14:42:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9E74900004; Fri, 26 May 2023 14:42:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CE446900002 for ; Fri, 26 May 2023 14:42:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A01F5A0202 for ; Fri, 26 May 2023 18:42:03 +0000 (UTC) X-FDA: 80833275726.11.06A58AA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id F168C2000A for ; Fri, 26 May 2023 18:42:00 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ltD/wwR9"; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685126522; a=rsa-sha256; cv=none; b=tAj3s44nw/yeMo9jN9lrSHZbVS/bH1anRFiEVmecimnV3PxlaxrjyKOAcjOUQ2QDUfHiNE zARlFfSd6aW+g/TZSX5mxpSGtzEvFe3GLrnimALKjYBFo38VNUTc1aZRDsIxlJ0EDPxzIk cEhzWje+CsQ9Gmg7BiCoDJrLYI54tck= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ltD/wwR9"; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685126522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mSsoE+0p2sc9kGpcn+WU5AUctLzpkgWUGD8f1AoBzvo=; b=kBveClNFHlNjQcERlwtl2pGHEkEF5rcrdVxTM+/neM4JKaMbAxe/nJl3YbgDziHHW/eun9 o7TeIjfh8YwqtcSb4MbdTW/nWGbaH0V+zaO+WwpjIrFDjCaLJJHJZz2kPkrWnJpwxpqnlW RaBqIiLyVgUVTh6BAg93H30GTn/YIk0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mSsoE+0p2sc9kGpcn+WU5AUctLzpkgWUGD8f1AoBzvo=; b=ltD/wwR9voMJdzOfZ705IzKtCB eZA7RNSbiHcpZdR1w/wBRURZPc/ijS/ori312B41S0Xufrmw922txQtPZmPY5+qP7FUIDuM4hr1ug 8d8UfgpK2eQOcxlveydCE6bMK2cbIXaKTL2pTOCI+ZAwJz2C2e8g7WFv21oqk8rYJaMQzBL2vqCsT /FPZsbcufMQFKMJoeBRxZMGJQv8E5b41Ajp9qlQLTNUnWkA07uvkkW0OZ1+PePVtaAvQqQSBO8N0T 0raE2IBPXMiOsqaWqfVKuHy/9DDEOR8NyExErim0sjxvhnMKn/DdO77faDX89uXK5n7vdl26kjTRW hATqoiAA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q2cNe-0032Q1-F3; Fri, 26 May 2023 18:41:38 +0000 Date: Fri, 26 May 2023 19:41:38 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, rohan.puri@samsung.com, rpuri.linux@gmail.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 2/8] shmem: convert to use is_folio_hwpoison() Message-ID: References: <20230526075552.363524-1-mcgrof@kernel.org> <20230526075552.363524-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F168C2000A X-Stat-Signature: myre7britapdjwkjkyi8tbms7zd1ekak X-Rspam-User: X-HE-Tag: 1685126520-421382 X-HE-Meta: U2FsdGVkX1+kwYWUbmEqVVwSRXOiyV1jKh90t4WoCmKDGViNHfBDwHD0VItFkBHqst0SU2Kimhw4ABnWyxRZwYEuq00MrDeT3RfoNDUzMXvjVn0ZB7SFnSj20PU9+PmWrWcv8vk+HtN1oc4O1MDjLf+O0CY0FVXavs5+/yUr/Ee4ROFAlXtEBRZNYbhKfWZ/Cm4DjJ3MtvBdQOM7JWaXx4FF3AoJGIi5j/1p5P+NC6xY4TwofehxSVZ2gX5cMK1Cl65y5XZQfAd3X33sn9yjTSjF46XeC0GP1x8uIB62SH3YVK1VBeS3G8hEqUF1NCHHuIAQZJjihRp4+yN340GPcRIvswQ3xFI4vStDNPj7gsXaiyTyNVFwxdIByxPZ1eqpSSTKEB5UkwZVewt250AHHnP4oJl5Kb2wP3trl9GOpsb3FHT02kJU0vPm/PyHBw1XRDJX2UI3Latupwu6EO9exAIHEqYJlsF5YJWVhb2oUuLQ/RqqlBtK2Wtazny8IEaJJY+270g96Kdlw82zxnrMg90KUFVGMXhkkV3VBMywBuagKRSEn7zDVsmuOqrAfEL4gu3luqzTlLiJcbBebSRSgcsbMC2JPnFLj3mY0LlpaOIDYMim0y4M6pQBOwbn6mR1Les8Laog7wdFEosuuabyzFPa0jySueXBbQeI3S49d9ZidbgRBMKo+di0ThVqtOMwYQDYG3T6mlpfzrsYf8MnAWjuP0vE4Mne66K2hVcryI1YnlAPqOZzkaKvZTHMzMPAa1AzsRHBliHE2vnAnCWkdBfYR9HrN/2ShkgzmIg7/1WTdUChnaRjScwcQYimDptx3YfQLQ1RkPLzr6mqoSk5iPIz8PWZLYf9Xb1wlLrOt7b69NQ9bMBSsR+az0CxNLEsnYFCpy0L1UJG4VGDM7E+gSAt489dQw6haZqrx1TDWsfMpUlHWQUHXvK0NRdrJJNyO25XPBNCAbpz4zn+652 dnBPxzN6 sTfrQR3m5oFamFQQfyhsjApbQy72qQxdvuF5lXq8FuaTff8Vr4ZAkLNjkAd4uvgby7qzCWNowWjFzOCzXIFkUOPDwdLxJNjXG/HHRVPpD1kv7v6EcJRpSoV5pSvXzjnszySQ18YMZe6FgOKQkaeFcxXk6mGKGTTpfSbzRCZcteMPfjUxFJCf9K98EmkAQ2vvUTVkWgR7koTcd1xOc2P3edEVf7sDIqGsfu3lHNlvykYDObRjMOwOBi/Bvnt5ErsiMoq9z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000075, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 10:41:00AM -0700, Luis Chamberlain wrote: > On Fri, May 26, 2023 at 03:32:54PM +0100, Matthew Wilcox wrote: > > On Fri, May 26, 2023 at 12:55:46AM -0700, Luis Chamberlain wrote: > > > The PageHWPoison() call can be converted over to the respective folio > > > call is_folio_hwpoison(). This introduces no functional changes. > > > > Yes, it very much does! > > > > > @@ -4548,7 +4548,7 @@ struct page *shmem_read_mapping_page_gfp(struct address_space *mapping, > > > return &folio->page; > > > > > > page = folio_file_page(folio, index); > > > - if (PageHWPoison(page)) { > > > + if (is_folio_hwpoison(folio)) { > > > folio_put(folio); > > > > Imagine you have an order-9 folio and one of the pages in it gets > > HWPoison. Before, you can read the other 511 pages in the folio. > > But before we didn't use high order folios for reads on tmpfs? Sure we did! If SHMEM_HUGE_ALWAYS is set, we can see reads of THPs (order-9 folios) in this path.