From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC895C7EE23 for ; Fri, 26 May 2023 14:10:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37FF36B0075; Fri, 26 May 2023 10:10:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33078900003; Fri, 26 May 2023 10:10:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F07900002; Fri, 26 May 2023 10:10:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0A2726B0075 for ; Fri, 26 May 2023 10:10:33 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B8317120F43 for ; Fri, 26 May 2023 14:10:32 +0000 (UTC) X-FDA: 80832591504.05.8384572 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 12CD52054F for ; Fri, 26 May 2023 14:08:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bBJBufxA; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685110091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nSls6WusMV9eQbjvX1nCjw7apPoMaxbxishaTjsFxOM=; b=S08+GGs0hVW/9NuXgVKAIXsDy0ynZttBT34UFl3qDCjFzW6wP5jH0UtyNkYLaqi98BOHyI yVirEu9igbmmsyEESdjGeLBIIw2qM/I/H6KBCylZT7UKwHEjr2hxdNet2X5gyhYrmBQvU5 o9CrDiM9NSw1RaygfjDE6hHI/aqvazk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685110091; a=rsa-sha256; cv=none; b=H5541gViIHtAIArWSRD3UwIOXhOvaH30NaP3+E+XRrsA2q5w8q/nlrKUXpjUD2H+ZvoSrc tNsMIzq/kGZsd6yAkyErNfXSkviKqvMS0QylyJSP859zKFyigNp1o79klQwwjQ0fbCSS1J 5A3P4SblVgOculqizgIJqNpBgQHX+zk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bBJBufxA; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nSls6WusMV9eQbjvX1nCjw7apPoMaxbxishaTjsFxOM=; b=bBJBufxAR9x9jTqNFgBH/fC/sr 1c55op1s+UENnoiFSRVxyiyVZ3ztMKHPzMHZ373cklRIEeNrqd5YKKmqqq1Qs8OFJU/1s245F8Evu 1tKlPkf6HE6HBq2XiDoJvM7eSDPRyGzF5FK9EoZl8FDCoYqcBYvQRZKFK0DgIBe9B3Cn730Jht7Rn 6+CAD9b90GWr+oF7vwsE0lk00kDGYsNxWl/GmW3RD67uA+Ovi9R8lada5SNzsPFT80COFYSo0vLDA nPvzqSsJVG+YLEEzNw+n3nIRzF9eef2gUtPjzUNwO0ZGPvae152HbnGsb1D217t5kl0fw/MvTK6vQ rgTEuG4A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q2Y6j-002rlh-Bv; Fri, 26 May 2023 14:07:53 +0000 Date: Fri, 26 May 2023 15:07:53 +0100 From: Matthew Wilcox To: Damien Le Moal Cc: David Howells , Naohiro Aota , Johannes Thumshirn , Christoph Hellwig , Al Viro , Jens Axboe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@kvack.org Subject: Re: [PATCH] zonefs: Call zonefs_io_error() on any error from filemap_splice_read() Message-ID: References: <3788353.1685003937@warthog.procyon.org.uk> <9d1a3d1a-b726-5144-4911-de6b77d9bf02@kernel.org> <8b803ab8-f8ee-259f-8d30-1d14d34dc1e4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b803ab8-f8ee-259f-8d30-1d14d34dc1e4@kernel.org> X-Rspamd-Queue-Id: 12CD52054F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7a8zhnfrdofte7s7crcyk4d66pfthqg5 X-HE-Tag: 1685110090-959620 X-HE-Meta: U2FsdGVkX18vai1tR/XgpW/y4xLMkPW6pyjddZQzDvn4BvcA22HCQ0ebR3CMMY+EUSxmsxheNr/8OgWkK1dSP6TJE2+fw8cGBbEjTcAp1LQezK0fv041nFmqRY/dAzyF2LH57TwIbLufJwh9TINA0Po5ChBVZ1AvGpQG/rHwkhtDLCTM0cjRy2TqvhS5yAO4Y3jhZTtA9uOhM9PMHI9KiU2AiN3M/hUyLADeNcoc8WidOkSiSBvxfXtbvHkhOe1u2cqFx/JD9vGvgz8bTR5pmAvyBIQKG7Az3CMrFdfyv7RTjFDIPcYHTgkI75UVKhIbwo98a1USVq7eJBSwB6/jmunqh083GO7w+S/M9O3ZacOON3lcOByF9fF6Lq1qDfVo6PSwm+9JTeOxGAdHXjVqmzLnZE4jbyUjQQ/8rs6MtA1t+RXcYVUmy4I+jMBwAn3Z7FT3pMuGsI9x1IWMzrDADLccMPHCfGx5D884wd4TX2tnUFT1EUTacvkOividZDWN9nZJwnQyP2YV0HOTn9GPZglnGH/wUqkuQU8C8p6kINsl3LOzc0g+gVhNcx7YyyrM64O+Ru0OxSVAAYjMlbe7wXY/9wrzpXcWemcOd17DoBo3Wvb9LbRsRbM3+l0U3GGtZ0i5yTV/AM8hbFI05EpUK8FrV5z+gc86mFFCPD2hcO6aqYN3YsgELyIk9wKqcLz5KeXEAMXWc5IMAqHYUlWb29beqQ0ZdfZhNAOaKcGUMkJL8mbxyb+1D38uNmcx5pUmnhNk/5Prs+TpiK3a+07pXDBivtw+6gtETrOsiFbOQZOJTA4Pjjn553K2T59G4lAj8pVxzEeL2WEq1JvnpQalAZCqdqV0Zq+T6sCT57PzkTNjEOT+PuXrI9venS0wWj8bO3PEQLio+pzrPEyDhHTzproEgzSEUeiqyT70hQo9frGm0hAQyTXvkmmEdJCp1DJBjv+P9T1rKJZ1OJlr1kD 5mtR+hKE lxf0zJ9oojZeKUs7FAmOUZSRT8C23F1ecP406snkxp7gl8rI6mgYujcBwM4XN/Aj7BXJd04BLGjTB9yTmfmwZ1h/ZQ60v4IV8ymcWeyvhoU2vPpQRY9kU8bTXavQ40V1MwCx+LAoqCAE1W/0m5C8Yo32oqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 08:46:44AM +0900, Damien Le Moal wrote: > iomap_read_folio() or iomap_finish_folio_read() -> folio_set_error(), which sets > PG_error. Then filemap_read_folio() will see !folio_test_uptodate(folio) and end > up returning -EIO. So if there was an IO and it failed, we always get EIO, > regardless of the actual reason for the IO failure. Right ? Don't rely on that. I have plans for returning the correct error. Really we need a function that knows whether an errno is transient or reportable.