From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E770C77B73 for ; Fri, 26 May 2023 13:54:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 534836B0074; Fri, 26 May 2023 09:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 509FA6B0075; Fri, 26 May 2023 09:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D221900002; Fri, 26 May 2023 09:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2F8D86B0074 for ; Fri, 26 May 2023 09:54:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D4FF8A0F09 for ; Fri, 26 May 2023 13:54:26 +0000 (UTC) X-FDA: 80832550932.19.F486743 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id B4F7A20016 for ; Fri, 26 May 2023 13:54:24 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ojX1a7ro; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685109264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MVg67d6tqd4lwkRaTe+6MM98KoWSEd2dKs7M6jq9Edk=; b=4W9W59jb2HHic2eyUP5dWv9cxpYXlQvUBnuS4Sc3dJZYMSIDaTOs63fnkJL0DThQxyGbAk QX7av95+4ROmTwAcIp0FRDFQinyMD2DsOcaC5MV56tHozzvKSmTwOOWNHlfb12vXcDOhRA P+rR59dxphk7FZnh6SC/Bm781vkHpFM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685109264; a=rsa-sha256; cv=none; b=ufvN1oaHGr3j9IPF4kYZmaQVux6mHyC/7OeVrGS8P9InxMVpJ657kFvEHPS+gPNDaVx0TR RQ2KRIk8sMC8xeqtu9I4wopDOEhEjACGL9qn1C41EZiqK8TXhaN90BprdMdFZoKBn99t1s DQgVX+r3AlQ4B03BLLzjlpw7MsYEkIw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ojX1a7ro; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MVg67d6tqd4lwkRaTe+6MM98KoWSEd2dKs7M6jq9Edk=; b=ojX1a7ro2uIIFc9IZPCrb7T1P/ t98E3papAcFBLMw6gNNkOqjJbTbgzGnPaubXEi20RLHCoNArWLZ6Z01g9JQ+d1E1jT8D5Ty91i+fM NkL2Zdb7Ir4BiD4zZlwg3T0Fl2LjFrZz6TkWE0F8EkWR+1sOHib00qqhITphgLPVzDKqn8Q+SNutN C1yAvozRrYQNiQLmJ6pt+w0SJgjs0v7bImmpDUSwrqVFNY4aLYr7X7U6my8u8/k731yjsyJ2rf7is zTHjmuR0s9CdWwdc70Rl7VBuw3TtNHG/rT6e8LB9xjPBSCjPy0M2RUS2N2wYn4hWGUD4lT8HBUK4y BIIEXmmA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q2XtU-002pxk-64; Fri, 26 May 2023 13:54:12 +0000 Date: Fri, 26 May 2023 14:54:12 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, rohan.puri@samsung.com, rpuri.linux@gmail.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 0/8] add support for blocksize > PAGE_SIZE Message-ID: References: <20230526075552.363524-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526075552.363524-1-mcgrof@kernel.org> X-Rspamd-Queue-Id: B4F7A20016 X-Rspam-User: X-Stat-Signature: in76cr7tu988f3nqdcqjqrdes473n1x3 X-Rspamd-Server: rspam03 X-HE-Tag: 1685109264-229184 X-HE-Meta: U2FsdGVkX18YnrbaVQJvGmb/t3wfpB8Q4r7UemGo1H+4slK72ERvn+6M/AyLBosFPW5lbSiYAmT6FSHtETO021UNxLxF5iEWGXzOBQKSqJd1fRT/g8NYMyUmHXaLXUuAjPecy23gzisfgN3ixT7U1CDcEQ/wwC7kzIAqhE3R3LIBqHvJubP532LipnbNmTWdfn5QF3ZQlKaVdEprN4j50sjaq3seoU7WYgDHg1XWiG9beGX6vYTk2uEF1DAF67tqLzT9/KrVwHLTP1QkmQ+aVTZkD8bvGu+RwCvepO0VgkZeDik0wvvtAkHdIWeQ2OyEzTJC89z16iBh0Qxt9AEhcq++pf1Pzi4Flk+mt1WvIQno11+prUVnO3zHH/7aI/K0eW+OCzrtcaPqpcUJxrjXV510HGQDx61db9SiPNUfkdreYy/g9OBvf6qvzpctNp6j7ig8agl0j0+392YnZux6iLF4vCaMT6/aY9TDb8pvungYVRBfArQguhOmc6xfnkC8uNSxbOd5i5wqubogoygswW5xwa74eARDljRYoqhoCrWGHZhtz+ci7R/PSUkx78FikYBsdBcyEfahLfeuqlpIri+CtWZO/WiKXhpv2NrgwucuglcLEJk54FWBnxb/N4g7Ww/z9z0rc4VG0kbKoIIIWwZwhUnhiKd8gda8O1QdCEquSg+Ih33w9liTPvl0tPLFo1gWWQyHxOIARkE6B0pHgCOJjg+SBRNkNAsmEv91bDKZjxZQb51kR8jXGt368/t3I9qUiDH8DfhK1D7WA84Vq+DUtzzE592NQYg8VLH8+vn1F3gSPmduUliFm4a8FprFc89Ef3dyiveYyKSKIZRAM3VreMblSZ43nRfG5i92qHajwMX7KYcFn7nR20h+kZoR67MOhqP+GGxiq/9Fus3j66tyTHBjbsQhVnPdfc9E/ZC2fLDuql4kG27fnfjXClDB/kIzbDe0UhtdRHpcsAY gVljew2y vktAeZfgjD6BvHehZrcvCoFRY7N4F+yKfq0e7rm7jnlGwyDELkzV/ZoK83tpufIllrvTfP/yP0+u3O3ZPb93xQwKYQGWME08f3RoQKfTg8G/IhL+6gf7v+5aHC35jbv95go5HO0vowmTbj9RvXRvDjfvUHIMeB4shtrfkXKFXDHSjzNEuCWLKTm6DcAVJkfrOvMOXmL7doo4FsE4/O91+PdStJ/73c0wYuLVWWgJ4UnEw6KJmj4tdTlO4Z7kNGqUX/PY9o97ma4KBtIMCKZsNFLwC/IBfGaaOGun5ajXzNKgQSUx3Nzx5g+ON66bcHSaqsZUveHfhpZUMbyo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 12:55:44AM -0700, Luis Chamberlain wrote: > This is an initial attempt to add support for block size > PAGE_SIZE for tmpfs. > Why would you want this? It helps us experiment with higher order folio uses > with fs APIS and helps us test out corner cases which would likely need > to be accounted for sooner or later if and when filesystems enable support > for this. Better review early and burn early than continue on in the wrong > direction so looking for early feedback. I think this is entirely the wrong direction to go in. You're coming at this from a block layer perspective, and we have two ways of doing large block devices -- qemu nvme and brd. tmpfs should be like other filesystems and opportunistically use folios of whatever size makes sense. Don't add a mount option to specify what size folios to use.