From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 297C1C77B73 for ; Fri, 26 May 2023 13:52:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 470936B0074; Fri, 26 May 2023 09:52:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 420786B0075; Fri, 26 May 2023 09:52:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 336AD900002; Fri, 26 May 2023 09:52:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 203096B0074 for ; Fri, 26 May 2023 09:52:05 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0ABF240EF0 for ; Fri, 26 May 2023 13:52:03 +0000 (UTC) X-FDA: 80832544968.27.01CE59D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 1EF2C1C0019 for ; Fri, 26 May 2023 13:51:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QOq0dPba; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685109122; a=rsa-sha256; cv=none; b=dbnCvz4gQ6c1v/ycq9VIOdTrCTgV8ttfP+uV/tG4grLBfDeVtaEyQV5P+SRcZJDh4guY1F bYR4k1UwYhJ8s8ujitseWyYB2lAVbFp+lLJVlONjJgFtS0yb6ZB+tc7tlMdVSG6ieQlHZC MEYuSj1e9vPhCFaArFexNBauWEDqQx8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QOq0dPba; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685109122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SvwLBZQXX5ZrheXLYNiefWyXW2iP0Eez24uoDSHmJys=; b=edOKm8HwiqAfAOsUl/RG0sOMMVET5hDm3GKFt14t98CeCUh2V91hbv534E0yGPndyOrzph BFeq5LANblXRHkibqIcehxGf98RiatjmQJP1BM4Pze0gx0zXTmnW+oklHWX604iY9MLpeE LWJJX3bvS1yinfUDvSZbydMYCN35mLA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SvwLBZQXX5ZrheXLYNiefWyXW2iP0Eez24uoDSHmJys=; b=QOq0dPbaF4MbrSU0IR5MCnSpIN 9ZgsKioa5yhKusHYaazZDNfy/HtaOcyxYylWmeU1/BGztXN5VeRcD4Hrl9pdcoMP4wEDG3Cq43xQ+ RRSETT/cpkyKvtemimG7kSJO3lD5avg/GklZtHjmi6bi5AOYi0XNIoP3vk8sY3bzbfwYdnDgnHbLF myfa808HnvK2gd2yFScHuENe+yuFKglhe5svuRYn76FglwDNsK97NQ62KWFh3mZHWBBu9aH1EmDkc xwa8yHbERCtYmogfbt6+fuQOnwNTxdJ+BxJHsDoZF8Z2AwV422el39CTJSgH0pZOYTNkI+eUq0OLs GwAtmfDQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q2Xqw-002pbc-AG; Fri, 26 May 2023 13:51:34 +0000 Date: Fri, 26 May 2023 14:51:34 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: hughd@google.com, akpm@linux-foundation.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, rohan.puri@samsung.com, rpuri.linux@gmail.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 1/8] page_flags: add is_folio_hwpoison() Message-ID: References: <20230526075552.363524-1-mcgrof@kernel.org> <20230526075552.363524-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526075552.363524-2-mcgrof@kernel.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1EF2C1C0019 X-Stat-Signature: jq87rcfhgc5xf19braj36tr1z1kx51y6 X-Rspam-User: X-HE-Tag: 1685109119-756419 X-HE-Meta: U2FsdGVkX1+smqzTrO3VXEehDXkBI8LLd6VBGFUt6YYQU4xPmvZXOVd4gwnPeDZiOpSyVknnlq+usAx9+7shYnM5p0Q3cqhh2rlwYsQ/axnK2ZVkafFoDASrBLqXZVETy5Rbx3jrEhR68vC9303pZFjmgh4kwCoCmYmJxw36LxjgCnKXvZQ7+Lh3FFCgWpEfp4jHF5DhLw6aOn/6IIMquYRtj0EAZdKu7Rp9+GR9tHbBgjd3naL14Zvnbtk0gfHR0ZTXRXB0yhYzrWJiZD2hN6RQp5ittIEPKSm/QwGySW0hgD6x8p5gNumXD7qPwQ4SEGm4lPoaDzvJJAcPNbtUSl6zKA/4NWgXOkRegaXYfii8Xoi0RCVOJimMSv2KvMvwDuV7II8Budo0zFauPmLRMQKVrmPb7wr9e983Lufd0NClrGqozZ70ZOvfjWdvAKzegRHyGDM0PYQ5pfYwpmnJ4mIStIv6jjKodiicEgsodJEzQq2OyqABecIpxrWb7ZNApS//XofItLpdX3zz+zcGrIrmpS/jWwURPm+nz+yxiMP8cYiaKjhtnbUj83nwFMp+pUAWQcIyAkzELbraRB7udUb+/nUqWJqzK/hdUl69NF9ClWLAnwPSr0anwjjCcrgpHQd6s450jgnTD+dGUzm5tbyqnsCP3/bA5q9Ma2xUBfoYDJvJiiq653LjmqHC3bsWkfzk6BEkJn+TzpIeqZ6zPucEIF13awv7OV8X+6AflpK/dSIgCqss7bGFny+nhCSRgJVAsKvnGu0H9LrQ2EuZoaZ6YC3S6fdnZTNS4OR4hxWsI9h21J05nFeT4t29IgEAj8e4WanihMKA+eaUEqBAhHU1/IBV4ETXS5nnSg5q6uq0KiI8W4tMRrn7S5/a93BauaPuUvEV4GYAmjHgzMVKd0aVnot+d50o6ayinyP1fPOldl+1YoSYe3Hs45AaNtVXV+YfgC/f0+uCy/JnyWa NbQOSKnR M3KKk5CTEyD4aKqaTX42T4gVyWnE8I8C2Vj92jKE5firZrNxfjUbJAbqkiHxHrklc/EXYIoGk+FqsgixwbO1ocCya7WfQzcT532mp3hec1qWS6mKFih4kBVS4j9S0gQKvUpAeTmzEHEkDbrz5c3fFxE74wJW/OvyD4i1q7REpYWYWpGE4nUb24YtjLpvYhAtZAIPcHJP5SSMV2CqGR1DcYS+hvQ14ZE66fdp31PF+/IJ9IVxd3FKX2bvfHmJY830M+EKe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000356, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 12:55:45AM -0700, Luis Chamberlain wrote: > Provide a helper similar to is_page_hwpoison() for folios > which tests the first head and if the folio is large any page in > the folio is tested for the poison flag. But it's not "is poison". it's "contains poison". So how about folio_contains_hwpoison() as a name? But what do you really want to know here? In the Glorious Future, individual pages get their memdesc pointer set to be a hwpoison pointer. Are we going to need to retain a bit in every memdesc to say whether one of the pages in the memdesc has been poisoned? Or can we get away with just testing individual pages as we look at them?