From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08DAEC77B7A for ; Fri, 26 May 2023 08:35:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 845A76B0072; Fri, 26 May 2023 04:35:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F5096B0074; Fri, 26 May 2023 04:35:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BD73900002; Fri, 26 May 2023 04:35:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 586156B0072 for ; Fri, 26 May 2023 04:35:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 21C17160DE8 for ; Fri, 26 May 2023 08:35:44 +0000 (UTC) X-FDA: 80831747808.25.5E556E7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 6A7AF20005 for ; Fri, 26 May 2023 08:35:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NbqKOjNG; spf=none (imf13.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685090140; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cU4HbZ0Ihk69KMRkjUWIN8WBPWiQau/75Wx/UKV6Xy8=; b=y6XyxeiwBV7qHEA72r/mt5qpcj7dB6Qt4wrwdTUm5bzYwk5UKU1pIA9JmjbfN7WBM+2JPt QMfhVuo4kecxx6iYyvQvOvhQ8ZVEO9KGBiSWvqXpHqr4I4LrRLHD/ZxYSbQbh+tI2zRlBH kOwHaqT5mleww8EuC6H3iRg/8OsBfas= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NbqKOjNG; spf=none (imf13.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685090140; a=rsa-sha256; cv=none; b=s8o1Kp2eGakb8sDir5EtsyQ8DMdV45/D58Xyt2gVB6hc8HPDfcKttTHKExIuMm+JA3hqla Gh6JE8eyrIY4pBe60rPxyuzP/eC+q/Bhd0eGb0c0MR2Wavr/LpcVu5a8smW019LQOjSotu XZ2ylHwxrTcl3+CJ4puwbNuzUn5vO9c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cU4HbZ0Ihk69KMRkjUWIN8WBPWiQau/75Wx/UKV6Xy8=; b=NbqKOjNGXmKVkdSnQezuWV1eT5 shzgQn36kaoEabnbYb/Jyz3Rdfyo4i9Gt9NcFEgBW4SxCR9JG+o+jSKnUKh34k8rrj8nhlDQulx6y 6VreloRZ4j6ECTgnH6aVsJIOwYtIqjD5EVkDYaakhcl9aFDyVUPVL/7qPbXwjDPiuKZjBAJ0h2p/c AeN+fmkiyu4Cusz7HUAP0Hz6pvjMNSt5HsMgL8MBhbG43QEg+Ri3e8GndeuvIjNy1idYUYW6cxIiL jsCIs6TkJFVD5KST6G7qRiRVkM5o6ra1UpwTs2oEuwtb9GLGqQOM7RcaspSqneNmqabaORhr7WwZy Stg1KBDw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q2Sv2-001cm2-0Z; Fri, 26 May 2023 08:35:28 +0000 Date: Fri, 26 May 2023 01:35:28 -0700 From: Luis Chamberlain To: Christoph Hellwig Cc: hughd@google.com, akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org, djwong@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, rohan.puri@samsung.com, rpuri.linux@gmail.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, hare@suse.de, kbusch@kernel.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 0/8] add support for blocksize > PAGE_SIZE Message-ID: References: <20230526075552.363524-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6A7AF20005 X-Rspam-User: X-Stat-Signature: zf3sb5qc4a6xrjbhdgs11hriqz64o1qj X-Rspamd-Server: rspam01 X-HE-Tag: 1685090140-516999 X-HE-Meta: U2FsdGVkX1/F7rdjKG5ktY9GK/YYRklmipYHYJe7scbvm8p434sb3YvlhpzqesCk+C06iFvaPqipizx6llUbVc3MFzzSh4QiMiASdXWFQlDtkIyfJjjxmmDT9gb7JCw3KINlJdrwHNiJUu5llY/0n+zmHehC34XAyjxZ/d5RAgay0oHeGvEybnXbxbNlDaCOfu//kvcZFJ3RNEURrwEMJY6FDUE7SzMo9N3IIhZKpBogRhMk1dBd3vm0UATSIURyJcBIf4dJeTwhjM2m7DPGZqlwGOKfk8F4hJuFp4ryn4LCj//H9irmH1MXj6sRXhtZUgDYIhTCH1K16bYCNvXeA1nCPT9nGqKCYZ/+5GoUZVDzjSQ1BszH5gimtRfeeGICBCe5xQOGfXp8Slrl1V7zyFnXqqcpIt60Ry5C0ZyYfpGnO/XoX8bkNwDOXVBGvNc7xfaGbooyOAtapAGlHLapIqWqyey31Xgj7A5/AhPwPKgn44njZLbhEepa7bXHUqq3s0zUjBVqtr5QyD/R79ONTeP3x+qy8h/1yXelYqn/JTJut4vLBMuM4VnjQCLkIgM8dMI+6lEoK8FQpIcKDXb2FUsiB8T9DmffjTqAGJUI2s/QQZIsXFItfX6Xt4KjjZ1qFgNihk6cVq7eS3F6ocNymtoNJXexVfREHaYcGOgf9WwdHCnSr6yxHnOtrtahiGC/JX8TvY/1Hb87P47fnOJyK/gAuZK3bk7eLw0ciU21Yz2OEF1jVsmc/l60+sPMTo1RPHl0Qt0M7dNIeEfkLG6HOhz28Rzj1iSPo5or7jeKKLawRDztcsCmP6AdaTJvHx/tG+ZMGT+vMQRZeQM+nrVH/uQtGO5yF3GNLHNFzpMkzUE66JecmLf1vqm7+jnHn+dSA0xmAQh+61D9oLEvA1RZOYRcUw4lvhj6NKH7Qm+Mc3BVxrkK0qNBj0vEW1QW9XUjtsiR0UqzPKJ6/+R6VPU 0zhQpLcy TkoF49ng5tlReHnorWMJJt7JFAob/fLAuKFZo5YR8O6eti3E+VKdkT2Jt6FF5qBJ+cQsyvlbvmfleZ1SenmjEPXUSCv7AdLlG8muc4k+gISLO2fja8LqtxENMhp0NQBawu7TfA6onCDGU5+HTxv5LCmX8tsqGMgTvemSi6KAWah9aPxXBum9CF7sdDFv0ELTKEHELpBq3TsG6tv0cqT1A/cXw7gNt5MBTBu6RPy5Y7Q1nna2lh+80h5VnuIMqkvKiJTzZhMtVjEi7mBJVBBdALkIo+SfFOetgT5bKUyCGX1lLWOl4U9SFw8NtIzACdVzJn8aRso2LoGzxGI5DbQ8DnxJNjKl8U59DfnLcbksmCYSNkT4Z+WtC0dHe0BjZ00LVAu2Yk93lFxfGUSt6xVPGafXI0sXVsTV7hVVGOi1iDznUXmo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 01:28:03AM -0700, Christoph Hellwig wrote: > On Fri, May 26, 2023 at 01:18:19AM -0700, Luis Chamberlain wrote: > > On Fri, May 26, 2023 at 01:14:55AM -0700, Christoph Hellwig wrote: > > > On Fri, May 26, 2023 at 12:55:44AM -0700, Luis Chamberlain wrote: > > > > This is an initial attempt to add support for block size > PAGE_SIZE for tmpfs. > > > > > > The concept of a block size doesn't make any sense for tmpfs. What > > > are you actually trying to do here? > > > > More of helping to test high order folios for tmpfs. Swap for instance > > would be one thing we could use to test. > > I'm still not sure where the concept of a block size would come in here. >From a filesystem perspective that's what we call it as well today, and tmpfs implements a simple one, just that indeed this just a high order folio support. The languge for blocksize was used before my patches for the sb->s_blocksize and sb->s_blocksize_bits. Even for shmem_statfs() buf->f_bsize. I understand we should move the sb->s_blocksize to the block_device and use the page order for address_space, but we can't negate the existing stuff there immediately. Luis