From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A4AC77B7C for ; Fri, 26 May 2023 08:20:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AAF16B0074; Fri, 26 May 2023 04:20:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95A3A900002; Fri, 26 May 2023 04:20:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821DF6B0078; Fri, 26 May 2023 04:20:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6C21C6B0074 for ; Fri, 26 May 2023 04:20:32 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 335D680D54 for ; Fri, 26 May 2023 08:20:32 +0000 (UTC) X-FDA: 80831709504.04.273DCAF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id 8280740007 for ; Fri, 26 May 2023 08:20:30 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=crkjvMq2; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+42f74f58005807ba5154+7215+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+42f74f58005807ba5154+7215+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685089230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/kSO5Pkxt0E1wD1vZlEErFGpQ+uRM9cO+R3QIlyHQFY=; b=AZIE/QdnayXPrM/X155cD0StgjmPtHVqdt0ClkDorN+MDW9PAhgJS1Vrd5Xos88BjiI5jv D6Pa2TWMT2M1mp7Yr9Q+YMDhTiel/IG4+577RH9VRpg0YoZL0Hcq/Zr1JwvDegwLmJVbFg cHmLtv2QmFBKkAO/SjwG+j37cFX7NY4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=crkjvMq2; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+42f74f58005807ba5154+7215+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+42f74f58005807ba5154+7215+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685089230; a=rsa-sha256; cv=none; b=N7LZWxqlLnVF3wELMapku8MNKfGE+Ur2nQXsEgOfBhGtoLZ6Vi57lz6/9Q86gPS7f1fDd+ 7tWHF7HClM0ubouvzBsx6MGDYU3tYDqKEfAMJTjQsLR4/G9YRrG8TC+d/4rlwjGqimpIkJ bHfDl10YSNZzqBSWrQecMjFARNmmZdk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/kSO5Pkxt0E1wD1vZlEErFGpQ+uRM9cO+R3QIlyHQFY=; b=crkjvMq2tLgxbnjWR9kR7dwfpE GtXCYDoFhrWEDM+sHwPIbkB2KTnY2DDbHu0ZpcqcJ0kUqsGYKZh77RZNRVgZg2LpB8YesgJ4mwpZN tNMNGy4/OD6aJkZMnzH0hDuaJyl2np80bw2T6pW7o8ZNt72BxXxZfozkmUYWvOp0pRQ9ezxAKuBm+ 8EzfBCiqXA02MMDeTrRhrW0matlCtUjSs4BRv3DBvFifVMFpgI/2GSrH99OgnykuF2kSdKPMKrvk1 +GMR7XGaugmsaLQJgwcRAunM1XZ1kQs3YNCQpBbCL6Ut03QRJcCA8qMpeQ6PKAqAtPK1XFLI3yCdg oITZ/JQA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q2SgM-001aIt-1k; Fri, 26 May 2023 08:20:18 +0000 Date: Fri, 26 May 2023 01:20:18 -0700 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , David Hildenbrand , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page Message-ID: References: <20230525223953.225496-1-dhowells@redhat.com> <20230525223953.225496-3-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230525223953.225496-3-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: 1tktbmk56jxc84xfwta3zoaratptoo1w X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8280740007 X-HE-Tag: 1685089230-832362 X-HE-Meta: U2FsdGVkX19A9HdWHZHEGwCmeefjAQNa9n/kpP82TZ5aman7aKwHEIAplCo4eY0M+evqaXjEsxsZB/vov+fNxu2jj9mP/bfGWXOFuANxw47PqdWNleGlVKMlFkx9cXS5XGWwp0imbjXka0MICohwCMr90kk/bYw6EchgZ9uIqLcqiKHsNBvYpk0QV+hA+KnDQT5l8IiQ4H2MW24AidKWvOqgiTmW+rQAz/qa6aD+2riX7cdbR5rbOJBd7VL/1iilSapG4Il+N1n66wU62sn7CnwIe53vxFy0+2poon+MFkthNnmXGb1dP5+y+prh4itlaIq2wyNChYkiOaHdq9sBmW4zCFBODWZIm2G2nC+1cs/hyP6/O31lSdsFwD4wd2O0a5qBN5zU9P0rjEFvD3Amt3iQhDBJ2fU8umOCq1u/UeE+gHfK7nP4ATa8nESFu4+ZgTClCcLULunqY8/9dX18VmXCeCuqMeOXOjJak6SYBcqSb1ss/2vJfMK8+XGTNo2Wp9axoogDL7z31dYihbytE8Io9gLu+Z88Vd3uKcmClgL0AgCb5YrmxZ55YYXZ/CO+UD4H39zRh88BrAkWz5h9TlYNe5jHcT8YFQ1IlhwFgSNZCahXNwGj5yimUYUYPLFW9KEc4Mq7mAoDFEqH9d6V3svfTFCnJKH9xAZwCq7uSHDvrvQIz/p/4YrbcfgRF93Y4Pwurs2VauE5OSaMACocE22smuIBNa3kz54epxSOCmh08i313EUllG7sTyizJB/hGdajsAqbOHfuInM0GjgV9Lxp+/whlqVHoToSxa/ID+lPaW0UuVeIXpAmo0fAbWYzucgNF9osjxFvymJPFZ+AQvehGgSPXYK8eLdakpaLsVaCSjwqgRiAEXPEjv+n/OGKG9RSuIRLfO7bVsR/JWMH0eBsVAkF19gYdeFhJVPOA+F68Hir3yIPeY/t5q16qxJIYwOnm9xHNV3o3WuCqTH wph6RkH7 UVXi535CpHrF2Lc4UPQMqp4MyBEHl0aen8o03+kGDlWPR+bN7g5WikpAv+T37pXhF3bmZFRDbOll5fRxqmJdQmWNgjB4xAgBMFRKRz5vejdU9pZa2vXtGTXBXs+RsF3BoiA1h8AfhvuifQIMZf/Dmwhh+ZTItH50B3WEPZOQIvNvjPKkDZ7vkPw/0h5mMtTGHSAHEt4SjcPgLWlVzvhfVZEce2o9Uepbh8r+lZ++cF0827pwgYbnM47cVKiUCW1QPBK5vLDcwdVEotNj9c+06k3FZgdRX5ye3wRkr7WGsbW1gykYXMiJmfIquZxoTMLoGOfQS4GQyuOP7et/qC0TwDSb1UOPKptoJA2qjLodXXjyPWoGnRChjEUF+SNQGeCQOqCnerk4LM0GNuL+KTFPSggnY4n4yEiq91mhgPx0GPVuDg4UH8oleZCfF/6nGfRBfBUoqooFr9oShsVs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 11:39:52PM +0100, David Howells wrote: > +/** > + * page_get_additional_pin - Try to get an additional pin on a pinned page > + * @page: The page to be pinned > + * > + * Get an additional pin on a page we already have a pin on. Makes no change > + * if the page is the zero_page. > + */ > +void page_get_additional_pin(struct page *page) page_get_additional_pin seems like an odd name, mixing the get and pin terminologies. What about repin_page? Or move to a folio interface from the start can call it folio_repin?