From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA9C6C77B7A for ; Fri, 26 May 2023 08:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89BD8900004; Fri, 26 May 2023 04:13:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 872E5900003; Fri, 26 May 2023 04:13:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 761FB900004; Fri, 26 May 2023 04:13:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 666FF900003 for ; Fri, 26 May 2023 04:13:33 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 326DF1C7E07 for ; Fri, 26 May 2023 08:13:33 +0000 (UTC) X-FDA: 80831691906.03.E7B2743 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 25DD914000C for ; Fri, 26 May 2023 08:13:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="L1M/wOjE"; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+42f74f58005807ba5154+7215+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+42f74f58005807ba5154+7215+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685088808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DgTgBMZWINXOuoCZBI2L8FK+k2n3IGa7ukNMwg/DhYc=; b=vCMARem8G6XVrYBn6YuX5yGm9DZBJdGEk1ngq6m/DwbX68qY2G+lZm4pOeiklxu21dXA44 IZxwf3yQd8crNslFv8WuQQdHkuvZkKIOyKEqGa2gRqxnUowO4igHv6MKAcN25VgZXeO8re CYP7e9fVrUorCIsaj5JvzyYFcfacbIA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="L1M/wOjE"; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+42f74f58005807ba5154+7215+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+42f74f58005807ba5154+7215+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685088808; a=rsa-sha256; cv=none; b=zOfyuqmsJahp/Di7L8vLmIvrgKHpXceMej1oZxxNi48bmcmRgafGqclvW2WQbAOHp6iqBo i34dbMUA0msLqv/Ex05TWR19CxjAuxAC2HvJWm2H69TynEneRmKIwRJ2v58jTVJUV0NgMS xtmsgLVLepEmVCwuXFSVefaqFLI5tFQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DgTgBMZWINXOuoCZBI2L8FK+k2n3IGa7ukNMwg/DhYc=; b=L1M/wOjEJS+hbGb0Ek6blzw3yA nabgFkkkKy+DTSss8/1GulWyfdXqHHVYNAzFWT5mbVwZAjUGHZXHuEQfl0e+6/OtF12MpNy4YLP80 VEIFzvlb4aVe0P7pRCuYc3yIdqxzO6y1Zsavs8rcRkdM9/4mz4siRmfuqn+sIDoKXdA46+bkVCwm5 aiixFMuyKgI/5ocaWt6B9ZqX+HUkoXOZlXs8Z6gefmi2wlMxbafMZW818soeWjD1oBROq9uXous9u y1HEaBkTCpK3nsAM9uz9T5N1fw3+CMx5JirbVy1uboijoXvhGmyTqNkB3f7GvUjESGORDZCBAgPdX NkZvUbmg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q2SZW-001Z7f-3C; Fri, 26 May 2023 08:13:14 +0000 Date: Fri, 26 May 2023 01:13:14 -0700 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, willy@infradead.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, rohan.puri@samsung.com, rpuri.linux@gmail.com, kbusch@kernel.org Subject: Re: [PATCH v2 1/5] block: annotate bdev_disk_changed() deprecation with a symbol namespace Message-ID: References: <20230526073336.344543-1-mcgrof@kernel.org> <20230526073336.344543-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526073336.344543-2-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 25DD914000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6795i3duzpzso5fcwsfu5o5m3ebe5spb X-HE-Tag: 1685088807-380117 X-HE-Meta: U2FsdGVkX19ksvDesaLjVPYN/RaS+v29DXk49N4Wkt+pGS6yyqphJERkL/20hbIWi71Zs3smnz9x1yMPyIXp6lnITSq7s494YojUtHGh3TNyTR5ZxM4lfqGuX178XUE4fW7d+RHV1iF3A+QctdoILk1xN69WSA4pRcfSQD1GyLE0Wd2/ZHTdJ3bCDLK78ZsqYahteKusDGLf36ORAEhGGfe3ziv7zs5QSWPIg6kIeco40QDFnCnLfLbOhv3U7Ymj5pgPAFqWnf4ResFY9cDUv91z37J9bDkwap4jtw9EVkg4EMzW6vMSJJmH7W2/yWwk9XbcE8J4Assh4XV7ajrI6RFU+T2bRLYJ7KzWIPnvTq7JSLLqfESxEZ5Q3ek6MMC3U2fJT273CfhCbcqE73to+8eABAI8H9zDZiScfpqEHh3R6Vpq0ugQ8ilXYzKFdah38FUXZH6Nxun3BqULvc3aOBZBHlBGp/fMekY8btvbbjTszYn7OICPMviwyRaQ9BtoSbeV98NghtwOD6ZM9A5bhx7jYjeMepaS7Vc7jDc0/lfuo8xKCdLm6Ny9edFcrF4Y91bTkQaALSCZBY7VqunkHH2Kr/QcxDG7HIIM9qJTo7Qx3z4ey0vs7tNwFAJVMVJBV6fzuoRZiteOiqVf6gB44AKik4MXGIhhVBaH2OYd8mqJHxf4M3FhB5wHhNq26SrLrLvlw0dVQScNtgTMD+5Y9HECEs+GpFNQq3dCL+dHa9Yruxk9zoUc3rXEZIpO2UONW0IPGmnVtrbaPfYJubrLtwY1tADjXaESdI25Fw2Jodw11uUqCKqzO9s0i1/vHQu3pw9mSnxQCizhfSZ/A49qjySBXvKC5N9yQByqzlJBycIJ09za6FaF1aaHipE8SS++hLLDzfe5e1oxUFX/rQs0sHrbKDZoJQVmv01rJpV/h2DQ1lrIK6kWCK0n+xelzPjmcHyQKYOaCKmvzawXXjR vlr06705 QNp9W9TkyMOOj57pD36RzOX2NQf1T7UgSKYl79R9pHbm/Wljku37bTxPX9STnuZ0XHj7IHETWbPA8vRNRXyACnlqgAzOJ713EJnUAkfOIQEz/Nqr+/nIT3wV+8R5hsEjp1f09uXB6DAjqCx2RERQt55/tmL3UUgWGGkLUz961W4jyBDwQ1Zruxg678a5NNUq5NGFIRX1S1fwzQgkWeEm2fzb9e8YUGjya2O7CrspasJph+ZtS4A9b8GLbU14PSaxIVX/6o2+wOQnMrdLm1vcRa2dnt/vYR7yck7Hj9TZy1+rlBNMCybB8pwJJxnJ6oGwfbxF/6oZnMOL0MFCqJSmqVLWf7fHZwnTLPSQTEi1Cuj0jBgrC7yPfIJBYHIqFNPkdKQa9GVlaqOCac9VsatNC3WKsUEGeP18AX/nTUcSKCYEppnJLnJMEruz//xSLI4KFfuVbPms3Zi8YMMZHXogAGKZW6u2Ep29Wq+t1ITDz3A0U+fyBt3o4wVlcI0l3bk6QQ711 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 12:33:32AM -0700, Luis Chamberlain wrote: > This ensures no other users pop up by mistake easily and provides > us a with an easy vehicle to do the same with other routines should > we need it later. I don't see how this is related to the rest of the seris. I also don't think it's a good idea. The APIs isn't deprecated per se. It just should not be called by drivers. The right thing would be an interface like EXPORT_SYMBOL_GPL_FOR(bdev_disk_changed, loop.ko, CONFIG_BLK_DEV_LOOP); EXPORT_SYMBOL_GPL_FOR(bdev_disk_changed, dasd_mod.ko, CONFIG_DASD); with the modulo code enforcing that no one but the module this is explicitly exorted for can use the symbol.