From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810AAC7EE26 for ; Tue, 23 May 2023 16:24:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16246900004; Tue, 23 May 2023 12:24:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 113D1900002; Tue, 23 May 2023 12:24:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1D54900004; Tue, 23 May 2023 12:24:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E6717900002 for ; Tue, 23 May 2023 12:24:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B63CC1405A5 for ; Tue, 23 May 2023 16:24:24 +0000 (UTC) X-FDA: 80822042448.02.4075EAA Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf05.hostedemail.com (Postfix) with ESMTP id 9EB4610000A for ; Tue, 23 May 2023 16:24:21 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Cy5S37oM; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684859061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2DQjjXojwej8++QZclcgRKrad+swrYEWwvGMdMxRag4=; b=eZCD4Ta0yTv+EdD2SORpCgXa2UDMIpIleHv67/CO2Ylud9QaBo99MISovLbQ9FCv0yGudJ hDG6NOyUzvpmNkLpqiKbkOXdmHYjgNW3mtGB6ldNO+BRZvzJAs2s/XpN2ygqvLTjUaPNWQ BRlyakpdFi1DSXPO7mLioDx3Ebof9HA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Cy5S37oM; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684859061; a=rsa-sha256; cv=none; b=u1igqOcbKTAYjIl2kFwlTByTysR2ZXME0/GM4RPBF10fbJJXeS5O2KVTtgG2adrp7MPgc0 /1IGEp6O7rSxmGVFo252hpygNfnDapPi0Rz9wNBMYw3NAEzKeeQ4XzclIUGSHhN8aVyyxD xwMr33u5oT4posOJCTkrg7LMUIB1TNo= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2af2958db45so880201fa.1 for ; Tue, 23 May 2023 09:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684859059; x=1687451059; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=2DQjjXojwej8++QZclcgRKrad+swrYEWwvGMdMxRag4=; b=Cy5S37oM6lazn1Wvi6pSDGyKWa2i3YuY7lLllesECLNtYhYQkyth+//byX/MocyVh1 jzOcCc+i+0RSTWy/ASD3whp0s5NgqujjxnBQtkDNhXzoZeAAVcwyNfssoKXrhS1Eitb+ wGgs12XhHk5J998kuOOdc0EKhMrwVZvbfYs/31ImuJsXkCYbz4QK80t7iq8eEdwDidQq SSlXSXeYGEnjaVKNmskS7HkSZFo8Bf6AdfsjdzICZyo8EXv85nXfbIMKzXm42EFlhG/I lsff3nsr7d4arel+HC56WIcVEURuS6YAH0ilUFom5dVa3++AXtyILgAAUkq1Un7PWZ6E 0NvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684859059; x=1687451059; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2DQjjXojwej8++QZclcgRKrad+swrYEWwvGMdMxRag4=; b=ggRm8e21KMJXd5b+jzqIVVGebf65X65iS5lF+7zd3TzT8P4uds8luc2is+sNfMoJpS 529oB0q6DqfqHF8U9/4xcvI8LrOS9JozH+283it8Gc6Rd6t6FIfiMapScLyE5Id4rGLb ISe0U2NkpDYpxMdmXlmeQwAmdHB6WBEYZrmJhWa29D/Djc4Ursz6fEx4YGrWhKC8eFmb UyMwloD6NFSs7ZCkPAJjYHu9QIw14HZ9UhiDl/ishlqVED6reiPndOQ88lgaOQFLgZuK yaJa3d1PGg921Ag7xtnIhztAxy+XGYHvssctTc5B0dlVWp50POLX/jBHLvS/BPksvdB/ 9evw== X-Gm-Message-State: AC+VfDyUDKIA/SZLYu1UY/wk5ode1VKCHMCSb4OP7MP+/qQSQIFTFxIR EY/pcC1lApl5iYJj9eI7XcM= X-Google-Smtp-Source: ACHHUZ5L1zomaGmOdRO5UEF5d8NA1e78TGM6p8t/XyAl74Ph6wmbMmyLtQq8a3agGyMDwpfWcBRDqg== X-Received: by 2002:a2e:8845:0:b0:2af:228a:a277 with SMTP id z5-20020a2e8845000000b002af228aa277mr6478305ljj.21.1684859059320; Tue, 23 May 2023 09:24:19 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id d11-20020a2eb04b000000b002a7e9e4e9dcsm1670703ljl.114.2023.05.23.09.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 09:24:19 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 18:24:16 +0200 To: Thomas Gleixner Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , Baoquan He Subject: Re: [patch 0/6] mm/vmalloc: Assorted fixes and improvements Message-ID: References: <20230523135902.517032811@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230523135902.517032811@linutronix.de> X-Rspamd-Queue-Id: 9EB4610000A X-Rspam-User: X-Stat-Signature: hbe6xbfnim3i8egxia5rgmewky8bhpeb X-Rspamd-Server: rspam01 X-HE-Tag: 1684859061-683767 X-HE-Meta: U2FsdGVkX19dRvgHEzS7NYNRUvvJrATadQxLqUd+mYnrNHDZPPJw77fHfE2cd/XtrGeXzc+rhEycQHcI14Gep0p4/t8KofVi7arFdhuJK29IX2JvQ+NQYq+fPpXX+C8bbfOCMB/0L2tm9djJs8txv17lx2mDU1b2F/7eebLUodhpg6gDwyNhG9jrqq6FKQl8HKoYvuQkJNv/Cjqk1bk+PkpsLIZ/vOJOps8utfLCJISJLCwT3drLR84nhbkyDpXPJxuWzXxSP8FRdoDOJJ4x5fNviI9BAkNEgFHhhGXNW6t82AfVqh1z4HMJDls3mTuCX3LaXia29ew4NyHuqJCggftn6kLjrwNX04HpikLhnIAIsv+SkGEtz4PqbIOjMDTXYc58CV2vY6kuzkUhDxux8+ig6huzeW11+/WTmXT4XNJffIlK9XGGvtz+sw9JAHGgP8uXdJ+cbeRxUyif4RhPBIwULjwTjRz1TH0E48RgyFaElqQRazE8+TKWsco2c1/CDvcRCk7BIyl71OZYnztMmPEoVH94BVHFN7JyzJhRhaOMqIuR3HosxAOLo3UbnQL9fb8RtiBOf6LcyKLv+/J43z3DD3n4tJ6zV6W4qDHVOc5APBEPIsdKZOfU1knUPzESpAxUiKPiF7CkPxvSc08Vv5W55x8pRf4bR6JxXOKrw7JDRYIuKPHcEMhS7zLgnTFsXAMD+qOb0Gzh/8hozcnFten5BvpCJQn8R0MgTxjnAUt7Bsi85jpa7GL51yVWnAwhcsRgtjIbA1eu/flkFduFTi1i2N+OkS7NKCEKNMqB4JpOZ4kjcZZDnmcn0/wGnr+lVjKYlSf75kh0qaUqQIkCZDadUWbzCqdJjvSPfx+7WPhyAa6aYG3dwSDCJYpIro7ta/xL7td+tZUbepJ6O4oDQ/WnJBrQZ5cakCagxhhlggEs/ngbVjOD3xwYMRLxu7hthFyd/i8Kuxu7aaOrMfS VhZ0rMq0 SFWcexfnzHYv5U70i925z13Hrsghe4La05NYBPKzJPg4C9L+A7VP3FEf5fSXJRWER1gDdJI6YY4aabwA5IyVYT0b/y+Am1kPGitJxJuzONiaC5wZcJvMrI8lVfv2jUAXJ7rC+9d1bnJCRfZDutQanqvljUu440Z7604FesK28VtboNU1wPaXybtzABEcCpThM4XLXLdE+s7MHw1BflZ9LesrEykI/icbuTuTDLDKR8aTYhAAUa0DFB1+gzCZy3fNvb8yA3eEaz8bN8O7+8OE1latifklkrVeKz9XIRJTta2eTFHFc92OBGueliMLZ58wQ/r1bdCxh/YPf5/lMaBhsLxaYwuXpgBc7aiWlPLrmAfG8qt7lgtfTyJOg5ruYYQ3mja2eEx/U1Q/QRJINo8Ak1MVUSsHvmeum1UZBZZl52R/znt9ElCLhMaG7IiLdOZML9oEls+CKsOFNZOaSV+Z/NL+FILKPVS0fFckIUZxuEFeJoAw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 04:02:09PM +0200, Thomas Gleixner wrote: > Following up to the discussion about excessive TLB flushes > > https://lore.kernel.org/all/87a5y5a6kj.ffs@tglx > > this series addresses the following issues: > > > 1) Prevent the stale TLB problem related to fully utilized vmap blocks > > > 2) Avoid the double per CPU list walk in _vm_unmap_aliases() > > > 3) Avoid flushing dirty space over and over > > > 4) Add a lockless quickcheck in vb_alloc() and add missing > READ/WRITE_ONCE() annotations > > 5) Prevent overeager purging of usable vmap_blocks if > not under memory/address space pressure. > > Thanks, > > tglx Thank you for fixing it! urezki@pc638:~/data/raid0/coding/linux.git$ make -j64 bzImage DESCEND objtool INSTALL libsubcmd_headers CALL scripts/checksyscalls.sh CC mm/vmalloc.o In file included from ./include/linux/list_lru.h:14, from ./include/linux/fs.h:13, from ./include/linux/huge_mm.h:8, from ./include/linux/mm.h:855, from mm/vmalloc.c:12: mm/vmalloc.c: In function ‘_vm_unmap_aliases’: mm/vmalloc.c:2220:19: error: ‘struct vmap_block_queue’ has no member named ‘vmap_blocks’ 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { | ^~ ./include/linux/xarray.h:449:23: note: in definition of macro ‘xa_for_each_range’ 449 | entry = xa_find(xa, &index, last, XA_PRESENT); \ | ^~ ./include/linux/xarray.h:501:2: note: in expansion of macro ‘xa_for_each_start’ 501 | xa_for_each_start(xa, index, entry, 0) | ^~~~~~~~~~~~~~~~~ mm/vmalloc.c:2220:3: note: in expansion of macro ‘xa_for_each’ 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { | ^~~~~~~~~~~ mm/vmalloc.c:2220:19: error: ‘struct vmap_block_queue’ has no member named ‘vmap_blocks’ 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { | ^~ ./include/linux/xarray.h:451:29: note: in definition of macro ‘xa_for_each_range’ 451 | entry = xa_find_after(xa, &index, last, XA_PRESENT)) | ^~ ./include/linux/xarray.h:501:2: note: in expansion of macro ‘xa_for_each_start’ 501 | xa_for_each_start(xa, index, entry, 0) | ^~~~~~~~~~~~~~~~~ mm/vmalloc.c:2220:3: note: in expansion of macro ‘xa_for_each’ 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { | ^~~~~~~~~~~ mm/vmalloc.c:2228:9: error: too few arguments to function ‘purge_fragmented_block’ 2228 | if (!purge_fragmented_block(vb, vbq, &purge_list) && | ^~~~~~~~~~~~~~~~~~~~~~ mm/vmalloc.c:2047:13: note: declared here 2047 | static bool purge_fragmented_block(struct vmap_block *vb, struct vmap_block_queue *vbq, | ^~~~~~~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:252: mm/vmalloc.o] Error 1 make[1]: *** [scripts/Makefile.build:494: mm] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:2025: .] Error 2 urezki@pc638:~/data/raid0/coding/linux.git$ ^C Could please fix it? :) -- Uladzislau Rezki