From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65536C7EE26 for ; Tue, 23 May 2023 15:32:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B62E06B0075; Tue, 23 May 2023 11:32:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B13466B0078; Tue, 23 May 2023 11:32:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DB80900002; Tue, 23 May 2023 11:32:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8B4D76B0075 for ; Tue, 23 May 2023 11:32:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5E51B806DB for ; Tue, 23 May 2023 15:32:53 +0000 (UTC) X-FDA: 80821912626.08.2DA2221 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 0A8D7C006D for ; Tue, 23 May 2023 15:32:33 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cwqo3MNB; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684855954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IA+o4TYzj/wUc+bKRC5VylEuRukqJEtvNsD6FrfEKbI=; b=t8zxOUKYn1E9qqRp2NMdTGGdHezqPlmbkJ7NXXBo1sMHK6sR/VrEpB9NJbu2piZs0oPOMX NcR6pdIHIV/skdy8iNyhArAOt0uiKvZzROnKaSmjc1EOYjgc6iRInQlUOK3nk75hIZo8y+ vAwuZxzRiF5KhMIK0Phi3w18lpultus= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684855954; a=rsa-sha256; cv=none; b=AaIxvx8tHmMl8fT+TBunLmRDRSqlTnH9kOFOkiUgWasd1ruDQDIA+/6RkfvQRgjs2bx9w0 pvrzhRewZGm1FuYxZgQPJxqtdrCq74Rnlqd8hWTYVq6t424LVTsd5uoQ9VC65Yknd15phD N5jx3wF5DlGiXMoJgaaaONbPh9cRMg8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cwqo3MNB; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-4f4ba3e0b98so1350547e87.2 for ; Tue, 23 May 2023 08:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684855952; x=1687447952; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=IA+o4TYzj/wUc+bKRC5VylEuRukqJEtvNsD6FrfEKbI=; b=cwqo3MNBzGhzZAH/q9y2Torq7BU6ej3XDe25GqHo4ZTpcitBLrK4o+abJzqFs/yka4 3trzSTSfZih1vWNe5PBVRb9qk0M7ZfyZdP911n5jfFYG6rR5gY9vWITNUjpMoHOIvADF OsYOKbxghZQfuzkdmrx3GGlGEgLdpis5K+SV3lNnbYohemoVAnqupFttSq2/TOHblf4k zyrNc74ie+s3j9lXG116zfwRUj/PYAHJDgfCS5HfZwfU94hJgb2PrQSCs1C4WF1aTmz+ hri6fTVTZvYPSY3rTHtj/f70XFkXzXzZOowZWLnO5yEkyuZTq2xFH7g4Wsg4pP5UoHcm c/AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684855952; x=1687447952; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IA+o4TYzj/wUc+bKRC5VylEuRukqJEtvNsD6FrfEKbI=; b=Ja+NqBHij7QKIe+ShLOtt9WoHzUixzM/DifHgsrOVxjf0QlTR3Uhur8bZlH/XJxmoe sBAOOfYs0pw+jZ+QDehcq7JdI8fsCBqkw6aiGLF6AGLqF6uLIFrGRmIpqzSRDeQ4skf7 T6Hb+4/kp+1hmyrcioW1TkO/NuodWKEAgiiDYq61qTVikjs9SlqdkW92a4tclcNYf9ie 6DHlPh4MSYfuQ2rnzm/C4y5aZMKcEwM9GAh5ys/Wxg8tpxSj6JrVMC+vFZx2zoYkQEeV Cu/IaY/Bw3bVGB7pt4C/JabLHXuSRhoy6JbJToBF+x3S+COU98/IYXsrxTNwYyXvlnCo MPxA== X-Gm-Message-State: AC+VfDwIrL7V4IrWqtKnV7Ff3JjnYKck3s3esK0UY8Zq1zuYG28iKHuf H1iNu25oSUX1/HG+tUNIQYo= X-Google-Smtp-Source: ACHHUZ4qQXNc5zVZIoSn00zDoKQbllQw4NAyB1PI6m5/K4VTNEo/Mk/CgptF1aF1BQy5Kg1SKVgUFA== X-Received: by 2002:ac2:491a:0:b0:4ef:ec33:9155 with SMTP id n26-20020ac2491a000000b004efec339155mr4417410lfi.28.1684855951824; Tue, 23 May 2023 08:32:31 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id t15-20020ac243af000000b004f3b4a9a60esm1374593lfl.106.2023.05.23.08.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 08:32:31 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 17:32:28 +0200 To: Christoph Hellwig Cc: Uladzislau Rezki , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 4/9] mm: vmalloc: Add a per-CPU-zone infrastructure Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-5-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: beymfsf9tgx8mifpxbbcfotmxxkkijpa X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0A8D7C006D X-Rspam-User: X-HE-Tag: 1684855953-279518 X-HE-Meta: U2FsdGVkX19HrBClqHJv79YqLod9Lus2+HkHLDh8zK4P6BNfw1p+HOc5brKRyok8iHLJaYWt7d4nag6833B8O9ZnAx55ZATriYWYw1fJSHoMDrRrkcUWOSaAiTB7j70OaD1x8Cb2SLZq6ct19YSIEw3DmWbMYBFoCJfsgydG4nPZu+f69BUYDu8YcQojBmt1RNcWwYtPmR+Bzj+FcppDAuMT4bcoQbpV0FOBjLRoJmpDs7JwYzlzQ839eB2mR9rTKBUnjA1EkCq7/xYuR8AncosoR7Ql4KLojQwbVWxqXblFXSaerzz/aUtqWk2ueiFMVWYTgbxuB4YLWeqNqZBBwzIo73I/OcZBP83fOrasoHlXx6A9M/h8jJ0VqdK1dRSuVBzlgYlE8s5OAffcB3SGq9pIpNvIePmzX3NiljO4kI9eWOSCpoRbb+iup3KF5/YgYvqiF0tcxyvM/m4A+s4JGx3Idq3PrR+3tu2pcj7Y1X1nMks8TOyIKgKXW1ATArV31TNBeN4w3DleekPedIMjE/NOhffXCU8Cb2nCkif5dgbF8AKQ5iqKLZiOpQ5gTtA7lPo4uDUzA5useOMfi1kVAy7jH30nsx10yZZ7gd1pr4RzIrd4zeCfBfikmOjukQ15KtpsiUwZWcKdOCuex5qIU+zy0Oo2KUrn5lYTxAO3QB5YdYRTK2JKns+bnipDvS6lyKZCni5SKaoNY0CuB+fxEe1ZeqmwbCdyQYPgsZtu5cmwOsQUO5y9wbWhQmscDnNehBuQowgxb0thayPvNrL1TKsMANWhJ6wmVzoELpeW64afyqB7y8uD+344fLppFL2qj9hugLpzwBQtquE4tgC4L/3AsS0Kw6Tufzg/4uu2uoZpTscGVwEzREyrhD294PzFzD5xs3xS/qAp4sGFR+HD220IT8ZfiL15zO0l+LrcXaQTx4g9H7Vdb8kigOhLe/YefE97yGRiWvUjw+Z3MSV waNgUJjo XobKg9/wamV2OPKCJmp1SCQ+sSIRpRRmr2OkeI/U6w2e1sb5usb6HGdLJyJrM+DT3IrpSaKWelxeZNjP3F4eXumEAuZ4BuaZm94h7b+MQq57f98T21BJnf0yUhetgvVz0KIcOGuL1i5T8aqSjJIBUIl2lwQ6y1DD/PVziI0sVh7SvVny2mRpOvmy11fBeHXLuMW/vOxFeRP/gqHRkTJAqLeQRUglTDQx57+XSc56MlgtVW/abdvsYtTv1EN5jBcgUd6Uy0fnSdfhSPWykeewK1euvIu/eOFyrWh1xRC8LJkJEi6qAHictMel3mTju9TFLBBrvlHmGNgLVPG7giJOVUQTE0FVJmZBrjz73rLvv9zuX6kVvIQ1aLlAqcT7B0jbp/opBZobkuaUY4SMlzBw4a/DCD7Z9kv29GtH+f+sNNZ224Aw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 08:13:47AM -0700, Christoph Hellwig wrote: > On Tue, May 23, 2023 at 04:53:25PM +0200, Uladzislau Rezki wrote: > > > > +#define fbl_lock(z, i) spin_lock(&fbl(z, i, lock)) > > > > +#define fbl_unlock(z, i) spin_unlock(&fbl(z, i, lock)) > > > > > > Even if it is just temporary, I don't think adding these wrappers > > > make much sense. > > > > > If open-coded, it looks like: > > > > spin_lock(&z->fbl[BUSY].lock); > > Give the fbl structure a name and you can have a local variable for it, > which will make all this a lot more readable. And then unless there is > a really good reason to iterate over this as an array just have three > of these structs embedded named free, busy and lazy. > OK. I can go that way. -- Uladzislau Rezki