From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA97C7EE26 for ; Tue, 23 May 2023 15:14:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 269FA6B0074; Tue, 23 May 2023 11:14:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2194C6B0075; Tue, 23 May 2023 11:14:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10978900002; Tue, 23 May 2023 11:14:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F418F6B0074 for ; Tue, 23 May 2023 11:14:53 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AFDB540608 for ; Tue, 23 May 2023 15:14:53 +0000 (UTC) X-FDA: 80821867266.29.8E214C5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 0B0691C0047 for ; Tue, 23 May 2023 15:13:50 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EmF0pl3G; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684854831; a=rsa-sha256; cv=none; b=mEqIuUqTdKIW7sN4hy+gjfPJoqI6DEDf5FB1l3Prpy8yT8zN0JYQbdv2iFWm2FIj6oSczM CbTV7VV1sEXAivKJy5fRC5dbREosjqyf4OjBRUjfl2D5UIpleab0fBT8WGukv42SorGjB2 +P1e7tXbPmTX5MPo8EMifxfiC9rrqZ8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EmF0pl3G; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684854831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=neW8xWDF9dDcKsZp/aT07RgnmDTayd37jG9hz6hzonQ=; b=6w3SViTlDMOEYIKUbFA7N541TJrp0GNIrB+P/J8/j5qrrEFH0f3M03/xkcuIC5k21nbzNs heEo/X7Zq7DNUtL4tnNeLjWuuuOtWUyIG1wv2qhYDDgXB3iDf0FeYrVMQWKFH/ILGfSFxa 4xcM5cGYE+mTpO6hRoJD8RmEB0AIwIE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=neW8xWDF9dDcKsZp/aT07RgnmDTayd37jG9hz6hzonQ=; b=EmF0pl3GeWh750bwRO27xgDDcP 6hwKFN8pdjjar3LqX5IyDTRbC8dckdXFqEw1oLFlhTQO6B1kHOmveNM9z6CYqvp570+f6fB37a7Wl jFBr06sVP4Uz2T686HXrHyiRKNb4WjcnLeIewSwA4Av2G1L13ek1buPJgJfMIwA776ME5Ky0Wvx93 mHrdUJo3qK2BTUWIC7RVID9jdtIrYS7j4FDEhiJOxU0P4Ow4b/h6Gi3sWYq9P53mYP0/xF0obNEPT U9iiR0eHUPw+MSIj1HyfGgvDIEy9VC2/LGuRT9CCDVPnk53+vS36P+x5v4RWaqxUkrcfTKUWWh5Ws 13UDhjLg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1Thr-00AbBM-0C; Tue, 23 May 2023 15:13:47 +0000 Date: Tue, 23 May 2023 08:13:47 -0700 From: Christoph Hellwig To: Uladzislau Rezki Cc: Christoph Hellwig , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 4/9] mm: vmalloc: Add a per-CPU-zone infrastructure Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-5-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0B0691C0047 X-Stat-Signature: e3ug7wjhpzybb6hits1ornejkn7pyhy9 X-HE-Tag: 1684854830-964270 X-HE-Meta: U2FsdGVkX18Orw/TwttJZqGtmGdC5vLmlJ+2B5R6tPhsR9zE3wLKqQLu4gq4NcBUvqBj4DGob3Hl8KpdHTLwMZFyr75Awv4LR/bgz8pP2ZczKgjCrAQNN7iSHzNOhV3w8wXd+ZFCrvfFNS070UW6/xL9x8iG4z46bFc7P4dHJ8k0CzUdEO4k0wQbW6oPAx4z8uCiHMfBhwnNHiJnV/dNNvmxjrAWO1mlpSsQp2UY3IGn1tUO4xat3c/qLrjhVlZVHxv87oThxyOxqOrtXNnO2bQZL1HmSooJnfULnWmE6UtiQb6wSRWJpWSW9l26naxdAMa/5XscCecDYq1ik7kHUQq7fZeTneaMqQNzBRqTJYtbD2Ii9G4AxemweHKSTKy3NjirCD9gIri5HZ0TPzMyeM9AzfWAQUFib9paKCbDOsAHyKenUCXOd1ySCRanhJlwPJWl8GP7PW9kqIRgMHV2uUEnzTfRVdIzvwlshdRDRpImorkTIIPPrl/guE1p0NILFPSdpA6uxoH3k2JY+EmVTZFowAqgW0ua26Qjq9X8yrWu40MANNenD3ycuF6uvWUvwlb5a0qqVJokHy1FFUiSs1yrizxRFZBArgBStGW1Y61VN84dkob/MH6tDvVTZ59gXlcmkLLa7kNSrEj/SMcih/mEafSZwTbpA8SBljsr57mfcKchfBsBEOn9aUuVFCQTS8zfgXClx+71jU6YbUmVanrcPki2Fap3BF3RW2jDqJhlq1uEhWQxtR+SFvCXxbtb1JZIZJMfi9KHpHsvZCtYlzoVtx4l1S5/n1pXdREJWM6+s7c10lZJAHS1j4wXO/BKJ2WJwMwq++FM4t0Myt7WqtVF+9YBoTchx4XU+MpCLnVz3PHJ+Kj4UsACKSvRa86G5GBfN1neS5IMwKTw1orW7XFEO/0ylaqQge7VkjSwH2DiBMs1JA4P+l36MO7sRkHw5U0NtYOMSXxxaR/iv8B BkBvi5Fh rhYDreEQo3HHH/DipZOTI0r8l8ljtCvZ8A4OeoutP1KjJNQLGedHhqDueSEmlBCLsuuQYvqjDsE7TNgwSxKybsDMTM8nJpbOyTqdD0REddHKt3dys++fixvYYT3N8PgCgkyvcoy+Zxwhiyetikulk4t/MlyIoMKomGC+iAvvsrImpF/9sWumr8HbYNZsmmkQU+/vT6K9WZz+OKvoMNkt9Gw47m3RkFHEEQuZ7PwMGhD0f+Pkok3sT4rr2ofp9V1KbORkpjVkxfafwIprsQavtQ1qM9PkHRVsP6PG+zK3jFv3StRvnO9CkO9P76D8XPs970mW5eGvMhsHBI0oKTnZzk0eIsXN1XSJpk4d5Xalx3ysXXjycJpYsjaEtqKEvTrwE+PQb+dlQmCJIuwA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 04:53:25PM +0200, Uladzislau Rezki wrote: > > > +#define fbl_lock(z, i) spin_lock(&fbl(z, i, lock)) > > > +#define fbl_unlock(z, i) spin_unlock(&fbl(z, i, lock)) > > > > Even if it is just temporary, I don't think adding these wrappers > > make much sense. > > > If open-coded, it looks like: > > spin_lock(&z->fbl[BUSY].lock); Give the fbl structure a name and you can have a local variable for it, which will make all this a lot more readable. And then unless there is a really good reason to iterate over this as an array just have three of these structs embedded named free, busy and lazy.