From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BAC2C77B75 for ; Tue, 23 May 2023 15:02:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26E3F6B0074; Tue, 23 May 2023 11:02:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21FE8900003; Tue, 23 May 2023 11:02:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E68C900002; Tue, 23 May 2023 11:02:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF13B6B0074 for ; Tue, 23 May 2023 11:02:32 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ECCE616063A for ; Tue, 23 May 2023 15:02:31 +0000 (UTC) X-FDA: 80821836102.22.865B5EA Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf17.hostedemail.com (Postfix) with ESMTP id 852F9400AF for ; Tue, 23 May 2023 15:00:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Rbg31Yrz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684854037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+bI1dsyGUTIty3MU+zkXPgg+upru8yu3Pn2ZYvnI6C4=; b=JabQvSmOTN7DieJHAM8y3j+okCIlYv4EIlzU8OPEc7ZOBQI7N2NeK+IsJHL6fZMG/v35E0 SLnuAXilkf+BSV3+RbHB2CWBqUXRkrPHl7LJKHo5/j84xlby1Hh+Y65qcHRoHHUMGINSqZ ePxsMJ12sCflPWtfUjr53grm7zq7mS0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Rbg31Yrz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684854037; a=rsa-sha256; cv=none; b=r2FRJbjL9iiMIfZOm3DZPLJrbKgqgS/N54T9WkRBjjHDvTukwyKtBg9rWbz4QxpYpdttaK tkAthrviEUclrYSfsd6VporRMnUF7ck5sCTWa5wUoO7uK/xxwJnXHS3hG8ENdxXMhM/G/X /2E6d0aLFkf4VV2UHpS/MucuK6MW90Y= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f3b39cea1eso4415525e87.3 for ; Tue, 23 May 2023 08:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684854034; x=1687446034; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=+bI1dsyGUTIty3MU+zkXPgg+upru8yu3Pn2ZYvnI6C4=; b=Rbg31YrzW/nfnIVkC+VyHJGr0WjR+UfL0YLUdxZlOdp1yuKvdVjAjq/7YL4IP/roVs P5Y+bFK9KCxBaz8sT/t30rl8XvNaN9zEpIvNQ+xojy6clrxsjKHXgZGPwK13Sk7M6MrY PyCiPieag/kwtCC8EH0CTJ+sAG9WuzASDm4JK43soq0ZSHWeOUBilEXyHqgsb+oNNSAr Mawo+1voujfJ/sx2iI3A/FduJO80/MgBO5+plE1HDa9YuE3OTk6aPt/cVftlOLcXFjXs 6novV7fTpm6EoOkgoQXw2z53LqHGNkDJHDy7+ouNBtey3Yg43cRv/RpwKCIvzaCYVu+0 ORqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684854034; x=1687446034; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+bI1dsyGUTIty3MU+zkXPgg+upru8yu3Pn2ZYvnI6C4=; b=Ruugz2ZjZcdladup5l3gXDykGE6pZshCGiuZLc8iFtSVJb/x/7QoryHK4BfOLt+dDk bD8A48XHLbZ7tYRkVVq+b2x2Zj1C1wVdwcHJILGtFfA0pOVYXis4IjdymCA1lk/vchsH I7/6Opu0fW7eC9tRPlZ0BVK1wMXXFQ14mTs7cp2gOE5kwlmfYa1fjRxGhA6ccbSJms75 InjVcGdXUWhle6MvUyYDlVaJTiWLfdRtPgNJrOlG5sixnY6wWlF/DQpqQF0L/8El/2hz 6MhOA7SLtpe0AUInhWcE3t/j5cvMA7vGGKomjzFzpG49eIoYBe/5PKFg8b9CWIa08sW7 fK9Q== X-Gm-Message-State: AC+VfDybux+X+NHEP9OTzs2uZ+oVIMPedOeDtHsnle8xcno4M2685wtn FzInUNUgJbZc21BWCPRi8qQ= X-Google-Smtp-Source: ACHHUZ5MalfVVPuyw5i+e7t92ZK5wn0NHZyUCZjNJcZ3PSZ+TnhHQvdKVGnoQv2r/t6wFYjo2xn9eA== X-Received: by 2002:a05:6512:908:b0:4ef:f11c:f5b0 with SMTP id e8-20020a056512090800b004eff11cf5b0mr4427623lft.54.1684854034234; Tue, 23 May 2023 08:00:34 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id m6-20020a056512014600b004f27cecb68asm1376307lfo.166.2023.05.23.08.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 08:00:33 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 17:00:31 +0200 To: Christoph Hellwig Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 5/9] mm: vmalloc: Insert busy-VA per-cpu zone Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-6-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 852F9400AF X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: i4f6oteyac44sohu55xyjwgphq458ekc X-HE-Tag: 1684854036-110801 X-HE-Meta: U2FsdGVkX1+20bdryB9jmcYJEBkbMgbt0sr4uDKjwLseFYBULy4mgvzRiLZZWzXZoXgVwI7n7wez11Lay4LtTKgajC06INj73crULXgVxl2SdfAdhrIhEONWjaN/fvkIbqXWVAjnrQiG4BvdcWr2t8LpsteJFvkc7kYFreiL8mJEx146Hug9WwNs+MbfSNowiW4+SxaYWE1uCfvOIQqja3euHe/qrzI4u+cj4r/IEQ3MiMaHKKA+t2Fm5KI9+7FYNLbffWpxmz5/RPNsuo6nQs4yXAP6X5si6Y8xpoINf6UpzXVRPOhWRC0wFdviajg8YBqEvz4mGmM5+M7EhrmOfO2vHnxXPgHAxWf9/Ps3J+4cGsBh56o9sPvo1e7lTwWNYe1CNYAADTbeK+2V1VdfUo/9LD0OjhKWt1P8U0BRISryDbn1tNS0ZlGtKBrfLqM2LOkBYuGKCN6SmL9zgfdtrzjXCaoxZ2EOp4sPR0si+U8U0EEVSXoudvvcimmf+B/aTUQv9V5UTvoepeXnORcEfdechC0eWxzKDrm43F1xOamoPMvqFwe3mvlVWgs+QYyTjB78N+T9hN+X1dNCY0d0hggwahTYRVOuJJ/LTG04999/xO3aAvXtitrlW93AQB3IfnjO+oLbqFYEwL7OxpdEcXjPV4V4rCzZhcF23psHdbgWt5Q/+S+sS8CjAaCQ3xDc3rAp1DpsrTpCpK3eHIohhiwmt64IU5AZ46iIi15zbf6ksxoqji6ffD+AmfjDZRajYhmOCNxtN+K3faMSsQx0fwni8byshIwJMgrt53hQHzutQS8sPo0cpFSEH4aBx2tyFqRBr192cgO4h9Q9Nfqp6ZXQWUwKLlQHOaEieg/gPvYMmrpvm/32Jz65Aal9F5pTZP4E5GZhDrtaG4ymiie4uExSkuvcuApSeD6RlySsjHxQBHnu8pt4LURc4CKPUr7ktDVJrBgB9GDxJ0/0p5j GjE07hUI 6Hceav/iA3lNQy53BMCZuG+NYtpq5FnAfc5IZ4YWQKrC7/d5Z+qCleUch3aNI0Bzh74XN4gFP57NxXmFi4UAEfLBN8RwJwPnZ/sIDJJLymncAFi0Xjbbt+vZ5PXxAphHQ2Zfeeudyfto7o1H0j26YFoBLtwa78g99WcIOE0IGZ9XII2Sw2Kdz4EPyB+r1wtaqwDwdtFA4vELq4NnvdaJgbXPKvCYuy8Zg/oYOhfmoW8SGVFws3OEm7tXY7nx1wPDEWDUSyYrdObYmj7Yub4PfL/ua2UoSOaxAixu6+/Ton3UHS/Y+FAJ0Gz7hBQ2bYTpEgbYGhrpSX0EDoItmYrAVCcS6tJ4NyQ05gjmoe9OZQ6Ni6wpt3yGIxJqwpi0P6g4W2FBEGe3+XNNVdohvcbWJqRRIRX0GuBIOmEK8CWR4jMc6/Klg6AJ+rITY03vidvTqSjcbfskCMQvRL+g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 11:12:08PM -0700, Christoph Hellwig wrote: > > /* Look up the first VA which satisfies addr < va_end, NULL if none. */ > > -static struct vmap_area *find_vmap_area_exceed_addr(unsigned long addr) > > +static struct vmap_area *find_vmap_area_exceed_addr(unsigned long addr, struct rb_root *root) > > Please avoid the overly long line. > Will fix it. > > + struct cpu_vmap_zone *z = addr_to_cvz(va->va_start); > > + > > /* > > * Remove from the busy tree/list. > > */ > > - spin_lock(&vmap_area_lock); > > - unlink_va(va, &vmap_area_root); > > - spin_unlock(&vmap_area_lock); > > + fbl_lock(z, BUSY); > > + unlink_va(va, &fbl_root(z, BUSY)); > > + fbl_unlock(z, BUSY); > > I find the BUSY magic here very confusing, and would prefer to > just spell the actual lock reference out. > No problem. I can make it open-coded. What is about an access to tree/list? >> unlink_va(va, &fbl_root(z, BUSY)); I mean this one. -- Uladzislau Rezki