From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF99C77B7A for ; Tue, 23 May 2023 14:12:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19662900005; Tue, 23 May 2023 10:12:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11FB3900002; Tue, 23 May 2023 10:12:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8DAF900005; Tue, 23 May 2023 10:12:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DB524900002 for ; Tue, 23 May 2023 10:12:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA4DF405BC for ; Tue, 23 May 2023 14:12:54 +0000 (UTC) X-FDA: 80821711068.15.FBEB824 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id AFF67C0071 for ; Tue, 23 May 2023 14:11:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684851119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VJZfGK6lX0CKVQ/gq/nUsYMWILeS5aywESydTczNH6o=; b=NTwuevhULbjlirC2e6Jw3m4dLXwhKIVv9pp611CeM2aQQEftC11u6BSWVTM08b8URl/Ie1 Czg9dFjIAJGr9p9elaiNZEw05sIp1e2lP/gtIHtZpjtL4H+MoKlZahovb+dup5JO5ogEOu MOCeo8mwAA7222sns2jLvxnwBMeu6JU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684851119; a=rsa-sha256; cv=none; b=lKlH53HxsB03IWd+anGya6uNvLCY/kyQ4TkZeVDTZj2xigsXaGHF6xidVOPPCapcMFPhMP beZweiGOmrTW239LZeq6hxl+ehuoKX0+P2SqTbk+Mwh9GT0eyfYvbbJxJORFb3lQbORK9R uKI2ct5WIncALQKCBlf8ByXYZ2NAMiE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A2A15632FD; Tue, 23 May 2023 14:11:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3F83C433D2; Tue, 23 May 2023 14:11:55 +0000 (UTC) Date: Tue, 23 May 2023 15:11:52 +0100 From: Catalin Marinas To: Florent Revest Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com Subject: Re: [PATCH v2 3/5] mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long Message-ID: References: <20230517150321.2890206-1-revest@chromium.org> <20230517150321.2890206-4-revest@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517150321.2890206-4-revest@chromium.org> X-Rspamd-Queue-Id: AFF67C0071 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1j5iwabqztpz1w1f5xzaw1p7z6buf5zn X-HE-Tag: 1684851119-192104 X-HE-Meta: U2FsdGVkX1+zOj/qxF2QI7h13uofiWO7C+hhFNbsQqwf7lkLEERdKY+OfiCto+vc7Y1f3lbZAVLW6DjWEnfoH47zGFJFj0KlcVcQ7Gi3uT3S+F07OkKj+nTTZ11IWJIfMP8Jkxw0sf5Q5L8JXD/UTDEUczeKmtbz3uBeI//Tas0K0TYrQkauD2uU2TmXH1+28oP6pRXJpKFikTTpo6lQoxZiMtE35fAMohz2m5lhfYyCH1d0GO7eJNjkwtsUs9V8yrViO4hhxTblolvEFFM5nG//hxbotcsEsyAXZCxXU2RiP44RQEYQ9nUj1DsbSudSuq7JHMVJzUGA6SXlNvvClUlL9GePEcqZLt5zdI2+iNZZ5q8pm3pFTr0b72ZipL1dPkO8JlVyju49dzp+Yo/Xk6+FUuRfUxuzWsBRxat8BX7lK336Fq7WeEwn+Sv2gJBEuLC8FjvBuzxAZo2diZdU/CRNPy9qnxMaKx2x0zEX55DeAq9DGJ6G2kvVISI3uV3r9wB75Cn4TQCEnEOBNjjLpsG1vhw2krvsS7LJoFycNr7B21+FBU7Jx84Yqx2hCMJRw+04WTCY32OibMNIMjJaTlGqg6UXmCAO6yzUefcM39yUonpG+WdyFCZjeSKgUC7towPOHWLdCmxFma9ADw3PqRsaY80kksr7KGS1C8Qe2mUaFX7whQWSAgRB4wF4+UKVvW5k5hzOMNWIELBiMWw0czCfEB5MARoBgHZe0MivtkuKOsthxMMhYUrYyaAT7R3IK+ML3txpYmoo8+KQW0hfXftOr+lA6yGo45ep4pmpzMZqIGMMkDRtcWFYGTFCTNaQ47cQg4NByTKWprdQ6Q+RIjFZ82vc3s6yL14SvuwIwc6jR68d81OfH5TPT0beo5Ai9QZcH4GSiAfNHsT+b0cx/2qL8ehDj71MMj6kah8SvB0WDYCxbmBAiEIVa+yFcdmurAs8yJdpVj7BGNskCYk VuvELebs WAS5jfDjF95q5Qobh6HsRp7YombnUpUgMyH06dTX67A/FdAHUTFBECjgHYEYE+b5GI6Cw0XgZtlUeCZmSKXmI4Wit9DEmQnO+WWiACcVJZzAc4oyPJkUCoEUoTEr3cCQkfZt3o+O4YC7qsC8fWHWI2HEfM+sScgjOz6tSgr8Er9wSquZmbR4lzPY3LZ3iDXIAuDdfmvXFLS+KCclNAYaiFD6OUjwl6QTxcUzOxxwTAiBGFJeY/r+gt0VWY6g7GuCHNECqTv2m4nn6uqSPtyPlCF6FAqEXyosP0EjjjG96ti1kSo0bN9ZMsjxI+3UR/NPQupwsRzIZXhf8E96ErYnrm+TEb3YmPgKxl7kc4ioBQGIM2+KbSkT6UcocYojo55P1YIWVULg+AjX5HMbRWn/5VFSO/TpClJGp4c3x/B/aJWAhR1gBsSAdKfL5Stxx5BEGVBn+lsTx80yMJ5D8om8cd1oHZ0MtHLi2gQ6BWpqYFYHAhRGMjOmEaEgfU8AIJNO3K9JAyDdVJ2RI0OYRkeDJBlDeeB9ipxgOypM0Zi9MocvUAMuR0Vu+Ct1hVA87A078viGWNhG6XML4oz9iMvc7qjB6Nw2Ah2HDW157eY4kdbqAf4/JRxmmKZLIcsqSf1q9BUWTNu3tarqD/xE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 17, 2023 at 05:03:19PM +0200, Florent Revest wrote: > Alexey pointed out that defining a prctl flag as an int is a footgun > because, under some circumstances, when used as a flag to prctl, it can > be casted to long with garbage upper bits which would result in > unexpected behaviors. > > This patch changes the constant to a UL to eliminate these > possibilities. > > Signed-off-by: Florent Revest > Suggested-by: Alexey Izbyshev FWIW, I'm fine with this patch and I don't think it introduces an ABI change. Acked-by: Catalin Marinas