From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1D9C77B75 for ; Tue, 23 May 2023 17:51:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A934E280001; Tue, 23 May 2023 13:51:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1AFC900003; Tue, 23 May 2023 13:51:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 894F7280001; Tue, 23 May 2023 13:51:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 76C88900003 for ; Tue, 23 May 2023 13:51:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 50725C0781 for ; Tue, 23 May 2023 17:51:15 +0000 (UTC) X-FDA: 80822261310.16.E879B3D Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf22.hostedemail.com (Postfix) with ESMTP id CDDD6C0011 for ; Tue, 23 May 2023 17:51:12 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=QTnPbSZP; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684864272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DyI7suR8JHWQaoa+GcJS0SEGDGAR5X7Se8fDVKt5KAc=; b=Hc8xx1hZHX/+FJc60BoBaTtZJAuLd0kKbEaZuYKrsyE9BOi/SiVBihgawLXuhCATldvZUq 19zSRBWo4XZXHhpPM31ka6l5DBKrmfqT1nvYjtMUoBxfq6ijEkvvxtIRTiIAiHww544R0t yALNmHSAyrqGGznetrGhE7Hs2qai87Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684864272; a=rsa-sha256; cv=none; b=d38dqvHTxh7oV0vtlhDhgxQoxryOHaS5SPgGHiHYX9GZv9XRPhYJd6mTJwhXfjT1m+htZJ 6OvkEvE4GtyjU6nFLw+if8kGVIq5UIXimvsbjaBTwdCc5F50MQA+jRNfDeq3vwoe++pso3 qawPZU1Oz7EgL0JHkqetTpv8BfE39nA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=QTnPbSZP; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so176583e87.2 for ; Tue, 23 May 2023 10:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684864271; x=1687456271; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=DyI7suR8JHWQaoa+GcJS0SEGDGAR5X7Se8fDVKt5KAc=; b=QTnPbSZPad58XF4xRaxeq2K9QGG/afjrjtz8T4BVYp+z94Czpec4aE/JkKTHw6mZHH iq4MAOJiquZc+2cWWJCkouHTD0h8rXGHS3ZApsNAAE7f40zwQvEqZrxLYlUzf0QUQXc0 hmZT1Z9l574SANZGf8LESNjtUvB06AB0gd3sQvmlpHlLdK3tVWFpadAsywhtsPfTZ1QN lHLkuqonD9OGkMorVvLaJWkgLvSrSx7TQKD5ii4LHxt6RkdAsEBVTc7m8v+GF192hk4J bZaqog8lxDc/igaRKTWCxL+F4Pn/rBoHSjBQDbQQSNZbx/jPPr+WKf448ChiUjVibOgG z4Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684864271; x=1687456271; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DyI7suR8JHWQaoa+GcJS0SEGDGAR5X7Se8fDVKt5KAc=; b=g3oiQ92jUnwuOAvAO9k6Q7J1gSGUierPB+rOvlSZeNCk84VipPOS7Kmubg8gM3buEG x8vPxCsTmWertzCglWSd4BuCb3X/crue8Escz27Su/cbAPfsNvM22p63PulO4mnDu2QC 6tYGgwmpPHw875dmQJRoIwaQhfr4dFYOf8mUqvsj/cWmwrAVOkWneU7PASMw3RqVEZpS uOF2UW4YCqIIEm9saZHh3VrArun8HIt9EHjZly3PEBB5xLf8tg6T4IGHySaikGtXOnkr mJpnQ/cJQKwhbtQ/wrWhxEF0ULCCNy2xiM1K2C+JPoKIe2WyeMpjgbtHJD3nkC2PHpLe bvPw== X-Gm-Message-State: AC+VfDwlXHFzw+2YZ2eW3GykJFGwqO426S2RqfZcGhpWGztSDLv2fZ8L LCzfH57MzHcLnu/ab9M3XGCCrElN7lLBNA== X-Google-Smtp-Source: ACHHUZ7GEf1YA7Cvyh8VLENsRo7XSL0H/dC8IJtbcv0ULksVtSmLTW5Ak1293mmoSoK5XVXP1mUe6Q== X-Received: by 2002:a05:6512:147:b0:4f3:93d4:2bc7 with SMTP id m7-20020a056512014700b004f393d42bc7mr4840033lfo.36.1684864270847; Tue, 23 May 2023 10:51:10 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id j7-20020ac25507000000b004f2543be9dbsm1413931lfk.5.2023.05.23.10.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 10:51:10 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 19:51:08 +0200 To: Thomas Gleixner Cc: Thomas Gleixner , linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Peter Zijlstra , Baoquan He Subject: Re: [patch 0/6] mm/vmalloc: Assorted fixes and improvements Message-ID: References: <20230523135902.517032811@linutronix.de> <878rdfuf54.ffs@tglx> <875y8jueup.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: ctxy3dszy97h3kpb9gj4uiianz48jojb X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CDDD6C0011 X-Rspam-User: X-HE-Tag: 1684864272-432357 X-HE-Meta: U2FsdGVkX19RiWyKwOYn4cSotc3zA5ZjueYrlTOL2ZVerat8xdouC94jkFfoJpLQoaB5Z0fj4TQUrYT1RCOUrkG+2tW80c/AbJOIdQI2K6UUx6CZ4Jqh3iKN2ER34vylIKpAYaWBNtNxPtV441PVNVv/lBjcFtJwIu6c2qhB+JP73SBdPJ/K8TA1yTRcDeL+FgUyqtqwREdj6RvXPdWQ77SBsmUyswRYn3i9tEcQ2QdvrV9OJTebKfJP1q8oNZ3NdwtpgSCq+KHgTW9aAcU021efoJVhZtXlDA8RGBuXIMtpkHw792w3sm9I+EkiSZiVcwqoS8VKqN6RgM2yUbJ4aM853OGteRl5PS3brHvwececM/xvtHi2qKSShztXwrtGBlhXGH6/5yJ3llRApe5AGkCfaMqKdgiuVBIlGMiscL+dV8oGjRT+uKbVUOHCPS/6AKzDaZXUAPVWC0PTgor8qFIskK/v3DM9ecL0EhicrisHqc3yVsWVFxnww2WrjRDKcyy7Y6Frc6pA5FP8DLKJIO6SWeDJpaxkO4ISFM5Hd9ncwyQIueJQBeHt2FO2Gcevt8VQzweNkxvVKzgn4G5H2QV0M+n63H2FrQ1SMMc4HswxskncznQje4OqeBpZ004XNj/oU+xqXvboTS5l240RT3a9e4bLmrIFCPmw2CWvgnyESgjp4YyT192dVtZOOAyRY43icfguSgU2m8s2N3b1nTbpHM58Oh1Yb6GAK8y10nB0ANrvLnGmenP5qRaLFvA5bAyUrBCltTtMNKc1pK8yvBUnQDoJ8S+iTckHi3O061s5b1Dqy+zJnM1Oq6t54wGBnYSNvdzHvqQsNLsu9+NNn9jUntDHPAmDogYIxIHj3wytR7PTpHG2sSJumofVkvJ3+QBj+uCLKDWd5tk89aS+4q262+5IFchCsHSiRgBjP7EFVpJpoIKUgSik0NkkXm+I6PN3ThGLXYxpDK7xGWP VhK6bdTo l2jYUb/NXWUGhYF23wNQLTxrbH4DYMgxcbs7I5dyBD1E/rOpaAGs8HhK3Xfql45DEZhGqIIEAytqcKcjWfQG9wvuI0MH8TvQo1VOFFgBBpZPqlcM02vuZHfl2Eg2Xjz2XkdR8R92FPpNgVxsIjpQ4Nrrd9rb8z1r27sJiNtoNl7+ykFjuUe0CcX9kWl6GvOpFsB2P83BIgGOgVlSzbYL9G5O6eM5h6uIBCkWYFC2nRgf5mOKv+g2P1lLAhdIKyNmbpbwah//2weDmNGY8Kelg3OHfJdSHruoCzUB62KPenwzhvzqN3oaX1xDzZM1Q7Hanp/h4RZphV0iLemgKY3Xrx1tFLeM1k/zl3hFE53shBlvF4O1v/HUrw4wld2CcpgTwZyyZ3J18x3zv/nTEHbiHnYnnsR+WFctrFVKG+7aZ8St8pag= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 07:48:09PM +0200, Uladzislau Rezki wrote: > On Tue, May 23, 2023 at 07:39:26PM +0200, Thomas Gleixner wrote: > > On Tue, May 23 2023 at 19:33, Thomas Gleixner wrote: > > > > > On Tue, May 23 2023 at 18:24, Uladzislau Rezki wrote: > > >> On Tue, May 23, 2023 at 04:02:09PM +0200, Thomas Gleixner wrote: > > >> mm/vmalloc.c: In function ‘_vm_unmap_aliases’: > > >> mm/vmalloc.c:2220:19: error: ‘struct vmap_block_queue’ has no member named ‘vmap_blocks’ > > >> 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { > > >> | ^~ > > > > > > Duh. I surely had that compile fail fixed before I boot tested that > > > pile. And then I did something stupid obviously. > > > > No. This one not. I only had the one in the last patch (missing > > force_purge argument) > > > > And this one makes me scratch my head: > > > > struct vmap_block_queue { > > spinlock_t lock; > > struct list_head free; > > > > /* > > * An xarray requires an extra memory dynamically to > > * be allocated. If it is an issue, we can use rb-tree > > * instead. > > */ > > struct xarray vmap_blocks; > > }; > > > > > > So how can your compiler complain? > > > > >> mm/vmalloc.c:2220:19: error: ‘struct vmap_block_queue’ has no member named ‘vmap_blocks’ > > >> 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { > > > > Mine does not, but I might be missing something. > > > Right. I have applied your patches on the v6.3 what is not correct. I > thought it should be fine, because that part was not touched quite a > lot of time. Apparently, me, Lorenzo and Baoquan placed the vmap_blocks > under the vmap_block_queue structure. > > So, v6.3 does not contain that patch. I have to use the next instead. > My fault :) -- Uladzislau Rezki