From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05B33C77B75 for ; Tue, 23 May 2023 17:48:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95BD9900003; Tue, 23 May 2023 13:48:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9108E6B007B; Tue, 23 May 2023 13:48:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D365900003; Tue, 23 May 2023 13:48:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6CC8C6B0078 for ; Tue, 23 May 2023 13:48:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2E0431A06EB for ; Tue, 23 May 2023 17:48:16 +0000 (UTC) X-FDA: 80822253792.17.9893FBB Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 2C4DE4000D for ; Tue, 23 May 2023 17:48:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=FFJEuAP2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684864094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wRXfAnuNZobwmPgYXrBcb51y8rxhbFHL4s3+ylm2WCk=; b=E1gsQINHTMlmgyPKR+ahAA+WXaW57UXxBPvZ438n/jCwVaXQkO4paYnn0y+4SBZD98/eRy fwlJdC2b36cctA+qNngOQOafX+RhDniVGVMS17q0mgJw8zqgV2MeXmUUHkV6d2SxPnS26M lhpXosbXGNQ949evw4Q9q8bp8lh2XpE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=FFJEuAP2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684864094; a=rsa-sha256; cv=none; b=JtBuNAXXKeNFYUbIpUvsG3XY9yq9BqjxP/w69KbEYmy2av+rkZ/lQvzWety48en0FN3fxa qw2/rKNoyCLClDghY1b08llhmvKaHjEtiRYqgWKy3dEIb6ptID8jUHrW+6pOMPTWSGMssi zsmGrYzSy5YbIoS2SYRqb24tAnLuJP0= Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-4f380cd1019so158183e87.1 for ; Tue, 23 May 2023 10:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684864092; x=1687456092; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=wRXfAnuNZobwmPgYXrBcb51y8rxhbFHL4s3+ylm2WCk=; b=FFJEuAP2kMNwx6o9M7RPwtWoxLG1HzWJEItvrUOb3V7RGcXlcPQj5kuhgOI/Ym/oPc OHS84ide+clHqU6ewE8KigFVwmm1fdvqWOaNUsH34AiyUcfZxTZF2gnBjS6nCAvSs3cx THWSN8OYhYwCzz2++iCkV4hekDikhGmZ2qs1cmCNqTceFgS5LowBZAe8RfHmy4YfZL77 HeTdY+MZvUB20aWN2dMN+owlmouBG2ZCkTjWd5Qg3xKOo1lAcxtTt3ShudVv2CyMqAjk R/CG6N7hAtFsso9/4ew1vcGLNgzgzK/j91WZdwEtFQPZDaPx9ik+0NDcp86P4f19/HnQ a7VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684864092; x=1687456092; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wRXfAnuNZobwmPgYXrBcb51y8rxhbFHL4s3+ylm2WCk=; b=W1+Hb8A3yEh3THJvIVv/zwGqXjvm5em37j48reouDtC19DdGVCdPOhGjev6Hj1Qtn2 7/r3mJeUMN2+C54/j0VC2gAbKQqvtDWVqyOH2G0XgmIAEySylE2LIWiW0iIORAUR8wT5 uOGX91u6vYWT/MeR1ydKrCR1GVs5rPeLhAwkHb6ozGIrRQ+fCaWxBFybOK0RQVoelmyG KUS+h4mrkrrcJzzpidBz3Sv/6mnG1BO0UoRy0c6Xi/R2pmJx4OKCQ4WHlzvpO1IS/Y7o Fm6wkSaY5IHn9rXVL6oVblfepbOMPwURcPI4Gj/KJWJGkiA4P7De8GOHlrixcpFRZALi zi9A== X-Gm-Message-State: AC+VfDxgdSqMpRMjiulnKmha4ef7ftY0/irB4NtZ3yqgJvBoy/FZf+vG aOyGiZ9w1MMaqDCsw3kfwiQ= X-Google-Smtp-Source: ACHHUZ6S9PeBEI46odxjkCShsJwcW4dnL8WGtg6Kjs852W0lx+MQjUxrMZW8zdewakXJ7/B2wFFw/w== X-Received: by 2002:a19:7405:0:b0:4dd:9f86:859d with SMTP id v5-20020a197405000000b004dd9f86859dmr4497342lfe.13.1684864091946; Tue, 23 May 2023 10:48:11 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id b1-20020a056512024100b004eff3050e24sm1419380lfo.125.2023.05.23.10.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 10:48:11 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 19:48:09 +0200 To: Thomas Gleixner Cc: Uladzislau Rezki , linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Peter Zijlstra , Baoquan He Subject: Re: [patch 0/6] mm/vmalloc: Assorted fixes and improvements Message-ID: References: <20230523135902.517032811@linutronix.de> <878rdfuf54.ffs@tglx> <875y8jueup.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875y8jueup.ffs@tglx> X-Rspamd-Queue-Id: 2C4DE4000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: stmfuazgoxerqz5tod5hdh4tebqz5yz9 X-HE-Tag: 1684864093-494069 X-HE-Meta: U2FsdGVkX18qhtLOXkCR6ihC8iQe+SHnLi447NE0aHuD5Yeq94gxKcOU8hESD8Gb3ODXB3r3+N8fxftZlGbovKMTIgYQmQvKSG5k63LOsPIcF/J5nngIF2RykLSjI4lqDmTeyNpJJUOxdOAhHoFVUeJjQG0CBuPdl8JcHYT25LvTVTOE7xjMmG/lPP9TNWjgVdfBb5+VZGwS+rPtB4jG40thZkYrqNQsSSmH9YN3kbbxGKrQ3qn+W3jNGq4LkxhwM4w+U5ADvIqk3i7vmu7TPDbzw5pSyXlCKy6hi54LnydWuPKJhUk/+Te8gjEKAavmh13UR/vxPNwdazz55kpn25v9dvRKl8XDosRTXC19By9JHUOw/hxMJWsnmRvCUIPllCjT8YQ+CLtgucjtwyI06MuUKyvvWbV7GRjn3bz2obh3ChYTBgYb7v6Znc9DMGy9LM1Q7NY861h2+zv5BN7Nfxajgn0kChS3DxyDpujAA19+189+AbIxjA4uZeQe49El/MMQQOnYRpLXkADVV3/GvD7fNjcXg3duRJnWRyVcdwnz+1IFjCWky1ZoLZJrWfCrxq0BcoiwDoWQ06TmLWtI0QR4AWmFtSbtClVhsoRzf5gJ5m3m6px7YUtS+J310N2b3DuMHEcNF3UmYEhmx/o602AjnUm8feADuFJF/7zyHJ86hPNLkvAKlgQo7+TfEKe3liI2pOsuuzC4x3hemOcEGr0iUrgzYqvCzZmX4yQ3uHVOJuJe6KEoqxv3bGlAN9BcK0L5nKV/SzVZa8x1L89TNs/eJ2lKWj01NymqoKV4yezBW2VbYkz/K0R90sSjsyAIHruOa3UizJgXvyV8cq/VKMpK6pBr4AMUmvfeOI004oqiJHJQnuNiLrrt4SICyPXkiRqe8uvOh3/qf/MTUJ3Kzo0Ao9rRR5aCLYq8ZZy7AKkwJQ3Rp2roQSbjufZON0sS414K+eUDIo2Vhk7n1+L 44x2iqmP RR88D2nUVOeyyO1f3gEpUUnAYWw684zlTq1uBI93KrbQUY2DBT2z2w1As5jhLIwpFwzkpFIMkES3THtwuDGc5xbeuRC53aO4nMZWQ3hew+Zlm1kwY2aAN5UKmu+2tlBe1bMoLkZPCnBrPgiZ2FRBsi0oWfbhj6DX6bUfIFcCtOFxV53YRF+rmu8Mn1AthcByCFJzmH0W3iPyKPmAtTToQujVd84GkXirk0hoJo2D27CItdCTYD+keamSO9pKbe8Ojyd+gfvU4cPshbwj9+U7AREKpekDcsvCe2c4NqRpGhseyUCmPqx3VqpPc0JQTRsLzttQFcV4TgpDBD0Mz+s7dGD1qwN0/CDAJ1atSNf+fp0eeN1JUxKHzkNRq+X1UxP/HiGhnZo17DJDqr9rzRT9juhQNlKHNYyOGRwV7FS7RUt6GooU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 07:39:26PM +0200, Thomas Gleixner wrote: > On Tue, May 23 2023 at 19:33, Thomas Gleixner wrote: > > > On Tue, May 23 2023 at 18:24, Uladzislau Rezki wrote: > >> On Tue, May 23, 2023 at 04:02:09PM +0200, Thomas Gleixner wrote: > >> mm/vmalloc.c: In function ‘_vm_unmap_aliases’: > >> mm/vmalloc.c:2220:19: error: ‘struct vmap_block_queue’ has no member named ‘vmap_blocks’ > >> 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { > >> | ^~ > > > > Duh. I surely had that compile fail fixed before I boot tested that > > pile. And then I did something stupid obviously. > > No. This one not. I only had the one in the last patch (missing > force_purge argument) > > And this one makes me scratch my head: > > struct vmap_block_queue { > spinlock_t lock; > struct list_head free; > > /* > * An xarray requires an extra memory dynamically to > * be allocated. If it is an issue, we can use rb-tree > * instead. > */ > struct xarray vmap_blocks; > }; > > > So how can your compiler complain? > > >> mm/vmalloc.c:2220:19: error: ‘struct vmap_block_queue’ has no member named ‘vmap_blocks’ > >> 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { > > Mine does not, but I might be missing something. > Right. I have applied your patches on the v6.3 what is not correct. I thought it should be fine, because that part was not touched quite a lot of time. Apparently, me, Lorenzo and Baoquan placed the vmap_blocks under the vmap_block_queue structure. So, v6.3 does not contain that patch. I have to use the next instead. -- Uladzislau Rezki