From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 921E2C7EE23 for ; Tue, 23 May 2023 17:55:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CCB2900003; Tue, 23 May 2023 13:55:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02E8F900002; Tue, 23 May 2023 13:55:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E38CA900003; Tue, 23 May 2023 13:55:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D3D43900002 for ; Tue, 23 May 2023 13:55:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9B366A0729 for ; Tue, 23 May 2023 17:55:50 +0000 (UTC) X-FDA: 80822272860.03.6A0CCDE Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf16.hostedemail.com (Postfix) with ESMTP id 6F3EA18001B for ; Tue, 23 May 2023 17:55:48 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=H3vg4ilv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684864548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xhAGMBCQ5K4mn+UF9CvappQAc3K/mln2NOzQ4kAwgnQ=; b=1QhZO443HDhDgY8kBdoRmEgY9nY/CDky5EBDPfvJCu1xAMdNxxlGfbBJEAB53V7uAysTV3 4CpYgXj/7LoqqfxtmLhpTdqG3etWMsRd00DZAETDMcrCfYhhSSzVlzjRgpzGeiFSQvQF35 YqkB/YyKdtWxf/h70dFC7bpfWNXlTP8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=H3vg4ilv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684864548; a=rsa-sha256; cv=none; b=ArHPBLcZ74MWG2onezkPtDjjZlZQrUf3bfjWTQXux+tOYdo1Trmbpkx0qTzADHirROqQZt e/IbVtq0E3mlsmLcjWDguSk/fd/PwY17SKVPXu3Jm9XcNwkHLgkJabmfYYV9u9gEXpME2R hQQblU/wXhodw4HzpOK6a0lYUyPec5Q= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-4f3b9755961so204845e87.0 for ; Tue, 23 May 2023 10:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684864546; x=1687456546; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=xhAGMBCQ5K4mn+UF9CvappQAc3K/mln2NOzQ4kAwgnQ=; b=H3vg4ilvKJ9tnid1fjFgrkuv5xaHT98A7nc+vkKf0Nm20Pw8oI6gCGzq4bFijAiUBC kNzlStS9kPaTwVAages5ElaosmGpxqDuYidMg/Rr9fqRUUDkkw/7e2YsP9lstHkSUyaL d9CtbqzYVsxz75/mC9GxUt2pFSSo5LXXRIpirjUW93+5D8ETHTyKWXC0MP/6dkb2owNF 5LvkVd9/p5wz93mfjDEOPoIKyrN83isi5FoMMF5vkOb/7e6U/fJKhK6rWR7pObivJbt8 vEUxpvo6f/Iev22eHTf3B+d/gMsgrYh3D17wNjNafjn7ScqnSJ6FurQ4x/Hk8uGXgqFr Zy3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684864546; x=1687456546; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xhAGMBCQ5K4mn+UF9CvappQAc3K/mln2NOzQ4kAwgnQ=; b=gnz/3pwEUkwS4GcuIPpMNXt+MCl2x7JjabUN0dFAFQ4XN9trvRxThgyhZs2Tcd8exG CQM/3hmwObfS67NZKqswV2hUxS/n/PD/UrPiBJz/pG1FRjNMjbIPFRAZ7/Z7D8G9ldly eS3V56oLyVZb8ty/y3oQZQ1JVLJwnwPAO2SynNcay0KsartkqOXW349Fef87beu46D94 RRvUQiYO1TgJPEqsdh36PaDsqnPRPhMUxqgetMWOXqgxo3ETsbGXxT7GZVotRuKhOFPa bEWbFvKKKZTO4Hqis75bszNPRctHsTcs+hZFErncM/cpo/8AYGISFxYh2VnZ5RNKKbpc CtCA== X-Gm-Message-State: AC+VfDxRBC9sWxYVewNXs2jObax++qGA2iSyCUYf5hgV1atI3fw3GEMV 8VGu8Qice50J9PCrEm0vM3xl0FiCTxwjVw== X-Google-Smtp-Source: ACHHUZ6tJyTyuI3SzDx9c0zgJBNZDW+bsO7Mn9tKB7uULey1ZZeTf5nEbaqbCAe0Fwrpv1SSS+0O4Q== X-Received: by 2002:ac2:4ad1:0:b0:4f3:8c0d:41c4 with SMTP id m17-20020ac24ad1000000b004f38c0d41c4mr4696404lfp.30.1684864546412; Tue, 23 May 2023 10:55:46 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id j12-20020a2e850c000000b002ac78893a9csm1713964lji.72.2023.05.23.10.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 10:55:46 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 19:55:43 +0200 To: Thomas Gleixner Cc: Thomas Gleixner , linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Peter Zijlstra , Baoquan He Subject: Re: [patch 0/6] mm/vmalloc: Assorted fixes and improvements Message-ID: References: <20230523135902.517032811@linutronix.de> <878rdfuf54.ffs@tglx> <875y8jueup.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 6F3EA18001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ic7re39u3ocxk5nmuszjdesthmptnxhg X-HE-Tag: 1684864548-492656 X-HE-Meta: U2FsdGVkX18de/L8GM2HPEUJcoOou/0cDZib5Nhvb9SXu4+j4RS35/h9/vT+POt847OxlxY3LN+nWAHmzoibYDWO5W77HI+2l+4ipdaJpX4ieN8PtnKmpsB7fz7SXIaJx1BBKcM8oTpjkBxG+C7ijmhvNB28kWsuovhk2I1GfCaFWCaBbdEwwn/hVdRCCk48Pt/1yJIcSLGlxt09btJiy4QEhYU2o1iUxnrT8xvmw/5xRgweQcEAOY3SYhuRzc/ycIF/vABsRpiF7xqUrc5HxC/UzBKutAPiWaeXPTGYSHtzb0KLRfN1Dgq+AXuRY0H29nEc48ZrN9QfzZ9PcGAeH45su82JZro2u12UZd+u4c5eeiNSwIYsP7Rtv3QfJ7nQG/OyxdM012PEOoK+HSNUtHCEP5sWCzkk4UjjcdoizKN6ifKftnZS2r7bdRM1e5g6RrO1wY5wYuj4ozhLnzlFw9Rsa//pmz6xZnNdK2TJnYJ31nla3QwW2K5m3l5JWn4jPphTq7tNYrkoRwayMCc2EVcw6+UBrQG4Zq9l7uaEGjPjFNgSMj+0M9TYXY1Y2HcYJ0DR+WXk8excenpti+l0ybXXgL2yRnMux07kUrmQ7jcQCb4kedGN7m8roh3q78dUTtXg88vhHaMngMd99Rv6N93VQUxEzeI0/wKgDwmQJisA8wDdQFNb/hq86O0ZtlG4hSa7q3xJvloqkY4Y8LBhA4L+llWCJv70ZbtliV8b4ppGSDXlKty9wx9SJDsTxpRl0cIMd98/hQomZpyotvCTNDzvAJbr2/xG0dlt7aVQEzejgMEoUVI+kg2ETmEC3BjytKjEZQttX/jbMrFvcp7uB4lE6tVoAI1tGXSD/v/em0sOuwZ6zXjc0yvMq41qjTgc0qfN/azc6wWd7DFWPf2h37bbQ11OTZn1FUXDdH5BkZLS+ip92KPKNVI1ysfXcUoSwGEnt+5EQftVKQq37b3 mmYNV4Wg 4911SEpsrjnTthGoFTWRsyM3q07YrfS0kzWDMbNLxWj8wkdfuqLpBCaMrENhAihEw2bpJCaIlyCXNLqfS1MiTcr/HJBl/15YNgQIZnQJ7iisK1VqfyXiNZl3omoTGsVxpomnneupZRc1KEA/5vMlNcgOHH+tU0VhBK95mbDbavju/oUNnz/wMlDCN4r3nhGXGRx1uFoFRCozUrhJpxApuJAfFRvXej1VY49/BomGNlycbvSr5+V/gOhOdsH5qPtGp6YG1s4lXWdu0JMoX7Eh4WGRUS1GCdYFJscACcpz2i0n2rkTeCSFw48MBNFL+A8p+4vViML38pbZIULhF9uEraGInguRPHaYc0017+yucAyhOQpBJQV76p/VbLe36Dgu9dZXSuLjw/jW284NMBeub1UJiwk5xp1AZe8pN1fdHY/zipVU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 07:48:09PM +0200, Uladzislau Rezki wrote: > On Tue, May 23, 2023 at 07:39:26PM +0200, Thomas Gleixner wrote: > > On Tue, May 23 2023 at 19:33, Thomas Gleixner wrote: > > > > > On Tue, May 23 2023 at 18:24, Uladzislau Rezki wrote: > > >> On Tue, May 23, 2023 at 04:02:09PM +0200, Thomas Gleixner wrote: > > >> mm/vmalloc.c: In function ‘_vm_unmap_aliases’: > > >> mm/vmalloc.c:2220:19: error: ‘struct vmap_block_queue’ has no member named ‘vmap_blocks’ > > >> 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { > > >> | ^~ > > > > > > Duh. I surely had that compile fail fixed before I boot tested that > > > pile. And then I did something stupid obviously. > > > > No. This one not. I only had the one in the last patch (missing > > force_purge argument) > > > > And this one makes me scratch my head: > > > > struct vmap_block_queue { > > spinlock_t lock; > > struct list_head free; > > > > /* > > * An xarray requires an extra memory dynamically to > > * be allocated. If it is an issue, we can use rb-tree > > * instead. > > */ > > struct xarray vmap_blocks; > > }; > > > > > > So how can your compiler complain? > > > > >> mm/vmalloc.c:2220:19: error: ‘struct vmap_block_queue’ has no member named ‘vmap_blocks’ > > >> 2220 | xa_for_each(&vbq->vmap_blocks, idx, vb) { > > > > Mine does not, but I might be missing something. > > > Right. I have applied your patches on the v6.3 what is not correct. I > thought it should be fine, because that part was not touched quite a > lot of time. Apparently, me, Lorenzo and Baoquan placed the vmap_blocks > under the vmap_block_queue structure. > > So, v6.3 does not contain that patch. I have to use the next instead. > next-20230523: mm/vmalloc.c: In function ‘_vm_unmap_aliases’: mm/vmalloc.c:2280:9: error: too few arguments to function ‘purge_fragmented_block’ 2280 | if (!purge_fragmented_block(vb, vbq, &purge_list) && | ^~~~~~~~~~~~~~~~~~~~~~ mm/vmalloc.c:2095:13: note: declared here 2095 | static bool purge_fragmented_block(struct vmap_block *vb, struct vmap_block_queue *vbq, | ^~~~~~~~~~~~~~~~~~~~~~ CC drivers/acpi/pmic/intel_pmic_bxtwc.o there is only one complain in fact. -- Uladzislau Rezki