From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E58EDC7EE23 for ; Tue, 23 May 2023 10:02:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8865E900004; Tue, 23 May 2023 06:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 835C7900002; Tue, 23 May 2023 06:02:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FE4C900004; Tue, 23 May 2023 06:02:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 626BF900002 for ; Tue, 23 May 2023 06:02:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 72CC01A07D8 for ; Tue, 23 May 2023 10:02:05 +0000 (UTC) X-FDA: 80821079010.12.51231E8 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf27.hostedemail.com (Postfix) with ESMTP id AC72B4001F for ; Tue, 23 May 2023 10:01:58 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=DpfQyv9L; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684836118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nNQVJ3hfapo341FunxfExex277Zhp8AOqeMr7BSJi3A=; b=oisscnS/vS/85fHnfFotyHg5uuQDnpSemtxDmjcuCJCo+2dlTaW+KwPKtliW3wm9dQPK7g jV1AJcT5sVfooiRlD/Q6IECyIytn+DF9oGJL1wPHgHowPjr2D3XoEiOw5fQ8oCWBGvmZE9 7YAS8glAUGfRxZRackCyGh4n1o5OswI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684836118; a=rsa-sha256; cv=none; b=ERKIDeWNzcPHvJ30B7aRMWVlOLSSpWVf+PZuUTQwHRfigNW4QGs4nXOkULww7+x+fBXWHw 78Hm3D4YxY+/ltfuoksw9ePXP8/O4BW4xDEL2cxlq17q7qJnnCf3YD8pD4vpuCieCc3ZHY l3rIX/j2w2d9xkliZNLnwUbsV1KS7JI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=DpfQyv9L; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-4f380cd1019so8078052e87.1 for ; Tue, 23 May 2023 03:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684836117; x=1687428117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=nNQVJ3hfapo341FunxfExex277Zhp8AOqeMr7BSJi3A=; b=DpfQyv9LjpABrMFNZLkTqBOe1d0NIK651tomV1gk59doETORebQ6fh8QDpVbbPEIXG 3t+trILLiyi1zQp6Vcs2aCqc0e4FSZD6F2QWwKpnIESv1YEFlgC21bAMFESW6JmRzdP2 7cRhYmMmIRDmLdIw0gEwy5p9z6a7F+nyP09sZhgJncyIEy84frqsy1eIUcb6pHR2ENuD etIWMxWU/7jjS5gbtLfNKwSyb3TbZGrfd524aQ0C/s+fNV0jKN1xNml4NahsNw+xFuKa t4Iw0dD6dOuhr8VlvZiaU709ts52RnyR5xvMFtUfgFMEczfHs8Tp7m456kQrDpPri8MV Dj8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684836117; x=1687428117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nNQVJ3hfapo341FunxfExex277Zhp8AOqeMr7BSJi3A=; b=NR5dXO82KLFLVar0ASeiE+I9/WjpbU3oLk0C4R/x4zUsshxOTNIDMKhgJDJNJqQwFs 431MY0NX23jZPuNLgAmW/Zuvjmu5AuG4RNQ1oQdg8j3bxYQ23/hTYxdXrTHD6fCBtJsW HBaUDuYPs01qkO/PgDZ0Y5mgq9SJaX9QzapoPvLrv/uM6eTt5WAyMBjdzJ8tUUzZRkx7 JASQsDXSofvlWifDWP7T9338fDvfeASTeLqU5DViSJ7GZTY+BN5Fo6pTL3JhqLG8OKcF jF0Dv7lt/XiYX0PmgjSOG1OmTntTHwLSBIb18oPF28Y7FI/U7A2k0BECfn0VQeUVdEsZ 1iiA== X-Gm-Message-State: AC+VfDw/PJuc/t40FrnnQfqcDXfcvYkvTDdizQyHN9L6MmXFEv27Pc+2 HcM/Jv0y3X5cijMf/Z+o/GQ= X-Google-Smtp-Source: ACHHUZ7gbRP2buKWjCezQBVAhmc8Agm+5TnQRbjtDxRf+Rye18MC3dsyc6ASWaXXejsoiCYbiwpFdw== X-Received: by 2002:ac2:5298:0:b0:4f3:7c24:1025 with SMTP id q24-20020ac25298000000b004f37c241025mr4301335lfm.26.1684836116411; Tue, 23 May 2023 03:01:56 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id a5-20020a19f805000000b004f2b6a203aasm1285696lff.224.2023.05.23.03.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 03:01:56 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 12:01:52 +0200 To: Christoph Hellwig Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 2/9] mm: vmalloc: Rename adjust_va_to_fit_type() function Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: AC72B4001F X-Rspam-User: X-Stat-Signature: h67ptot8cgcn3if7ez9hz1n5ern44c5x X-Rspamd-Server: rspam03 X-HE-Tag: 1684836118-790274 X-HE-Meta: U2FsdGVkX1/JCVM0ZWguDtvn3uDekLkhLrYURDs9+bmil0YjlmYZRB72UZNk0xyi7fj+2/fAzsZc4NSuolxSlCtqElFuwjpAsPqZyfAhj1po+guaV5PBFlx0qDwp6snkENkFFILhk/2A0VVlF8dNKYZVU6Uc6SDBY6rrq/XknQBtTEkIgzNvVJWxRSlP3SuvxmQgc7gN47CAUa6lJnnw+Frf6JJW4ikkSrObvUpahnYJkh90Nxu4ttclW+YNx2QCedyZUi8qomdUOK3FI8D7wjA9l2bfNE4XiZ3XxBZunxsxow5ynX7QDTaQgEvDZk4NmZ8F/Yj/P/pCFa6CEVdoaFYPmAniwcZxZAUWMSIn0OgrBlTgAo5WhGhPpo/u5DsvFK65eSBW+ez0eAucDVN3v+D6LuqIvz/iYhlgEOvXW3rR6aXID8ZLjDzs9Pf93xhiy9q+vRICdap5OW6COCkeJfTh+Zad6AB5qgYZKYaYvgyzW5s+xezLMwzYQO1+OWhupmzZL+4G1UUCTfF6cPryPdIDlYqRmmGHfT4nNxmse/1x+laVuBtZfn/2dXd6m7oxGCBFznDluQuTSwK5UDnPW9FSPWDyV9ArwKLtBYzlJ8x7YNT+z10/9jDAaFAOAcanI8BqrgkCIcyKcK8xGQgZQ6yrzllVte27RKnhi6zRb3IcgrXD+hCeGFogJ43p782Q5dd7JkRhMNBIl9oVwNPFuPXWIMSnKdKQX/6DVStCHfgXO/LiFgvzv/8Abh1adR9u3sSEXrXL9F19jjX4xC8zHLKXBSIPalqD//NnOBRbJ2va8+LbwnMlIVudHiP9ArPecixchub92JKJg04tDmIFahGGoPPbBd0ymuvpw6+mwXutkjAvgJstDgHm6klPygiDpUZirOqLLgdj7fNmWQ5+fro6D1CcO6YhiFgKfPbh0ANNH/vrppeZTgSWSba0Ejtx1yB/6wSAc9j1AJlC8Es LkumZP7C 4V000WPahJfw9pJ0k9n7cjd6jYuJtJ3YZD7OlNIZB6/NIHkUSL9DU7hWtVmAYl8G8ij/5/eX20cTn6YOnhTWh/c6NjdTs0kkjiXqejOxaNV+OwZqFBY+zIDbTdGmushEd3qjCZYWvJFEQkDddpfG8XvRZU7hvyu2KrtMje+cQJRKPhzc6szGiHumeEWVI9mWIXakW0fu+GRBUW1oLkLVMmQfTR4FnH16U3x1/N2VN5K8aThJWcmanfxKWDX2+NRa0VDJG52OJ2ADkmJxzKYP6ku7jDixnGa3CuX0lQCBoAjXGnvP6WP0MuUr7IL3BtCL3cp0qjA5l/JbDPCVKsJeXA04eFKD4rsQSEI0vletw+BD1UW16/paa2PEcZb0qzW0kBiKM/rP6/RrShcSpiIqTDoKTJJMsZKaVta50rZ18/jSzvbLQ6KMCN61dHOcEV7b9ILp4+XytNgHUeo0ZEeuHdkibQYybg8/hU5sG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 11:06:31PM -0700, Christoph Hellwig wrote: > On Mon, May 22, 2023 at 01:08:42PM +0200, Uladzislau Rezki (Sony) wrote: > > static __always_inline int > > -adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > > - struct vmap_area *va, unsigned long nva_start_addr, > > - unsigned long size) > > +va_clip(struct rb_root *root, struct list_head *head, > > + struct vmap_area *va, unsigned long nva_start_addr, > > + unsigned long size) > > Same comment as before, not going to repeat it for futher reviews. > Fixed! > Otherwise looks good: > > Reviewed-by: Christoph Hellwig > Thanks! -- Uladzislau Rezki