From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D663BC77B75 for ; Tue, 23 May 2023 09:57:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F79A900003; Tue, 23 May 2023 05:57:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A883900002; Tue, 23 May 2023 05:57:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0701A900003; Tue, 23 May 2023 05:57:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EC4D6900002 for ; Tue, 23 May 2023 05:57:25 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B4E9E80734 for ; Tue, 23 May 2023 09:57:25 +0000 (UTC) X-FDA: 80821067250.19.1B92244 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf16.hostedemail.com (Postfix) with ESMTP id B33D718000E for ; Tue, 23 May 2023 09:57:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=RUgvWVxB; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684835843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=edwWrDcvxwOBnRngZUhvK+9rBRKB1nAa+UUBR0uzu3Q=; b=zV5zpak7mbGZVs3sn1ZGlRC5XfYcPdzIMceiOtrSPQMQTGxCJ9Uvedh5xeBZBSKbNQ9ddu YzmFSRRvd4zBz9KzTaae/VT8p45TvSO2OTi0EO9X+Ih+/BtVDb04ZG8cXAk5rQ11b1Jarz 76JASogLYvWBbj8CbqZzH2PDXZhcxYs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684835843; a=rsa-sha256; cv=none; b=HOxPXCofiMAF6rDkaw65PhHUMQHX2huq6tpcj6CCuxHgahNRJBjqJWhtRkFbYdlHnSP7DG RX13P8YQksljGAk5v/vfbyblhdrWtsJzl8qv4OrB5k82O2JwlS+RWEI2/mplce132nn6J2 xZt/iUexK3YKiLuq+M7GCCXeqHMruqM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=RUgvWVxB; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2afb2874e83so27883991fa.0 for ; Tue, 23 May 2023 02:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684835842; x=1687427842; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=edwWrDcvxwOBnRngZUhvK+9rBRKB1nAa+UUBR0uzu3Q=; b=RUgvWVxBrN/R6ZuIQbV6wY8ghqqsoVxOK0JTpAYxXpoNZiGgFhP01/NEKe47sBpe8w IMk2y67i1dKZKXfjOSdxtgXfFCdzajrk/ppKMiW3F+3jXU0sNKZECycLCQeDMdBTkKtU XEz8JZ3cad2qCmXkN7B4RDvWuvjQEXj3mXRBB1B3CIDvpDLeZyoaiooHdOZ/lJtPCLWt 7enhUv2Bmxep08dWEWyAIQ/8Q74408iFJ0k53/lra5+kpG3toVn9zbfXn8HggYq/GUPL 1/q8JTtd0UzBcCLpwZxhh38FATr1vF7ShurNLef24X6pu4vfvcYLfhgSWiquVydPs4Xm L7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684835842; x=1687427842; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=edwWrDcvxwOBnRngZUhvK+9rBRKB1nAa+UUBR0uzu3Q=; b=dvE9iv0ExN6i268WhqnkEBdakGVA+7Rj2cNhCurp02mYa+KJdxJkrY7nxubfiXOfBp l8IOaQCjQcR4hqxkDOyZ/5j4tWVP9p2FgsNkqG8eeBgKxEiyQkGiH3AjByax/ONI6cbs yjupjDrAI79gD/eoHjFg5TPODR+/LCk82QZ6b9G4ffOM8RXt2ukYlRE6MTAtvv2ToWDs JU9hnNJs/yQAT5dic8ZuLNIvZBRHGvMVYBYcaJmw1C5Gnvya+OCskjLQE6sZhKCbE3Mp CnuG5A5RD6irlhV7vTM4da/kjPsF82P+yBZn/A4/CN4sGRxuVyYSgUXlDNFZQVtL2zlo ixZQ== X-Gm-Message-State: AC+VfDyiWU1gNQb6V8FqEVVXw7Ob6i16ITvAsVoARhbZW4S0NmXd4XDo 47G4uPseViGM3n5yFyw5Jmo= X-Google-Smtp-Source: ACHHUZ7VKnVl193QCDrumEy5QAvhXE2ODuhaJW6NhWViSdqptbnWYjnWuh7L5mxC1c1ISmdFDZsxow== X-Received: by 2002:a2e:9117:0:b0:2ad:af50:6ecb with SMTP id m23-20020a2e9117000000b002adaf506ecbmr5135063ljg.14.1684835841510; Tue, 23 May 2023 02:57:21 -0700 (PDT) Received: from pc636 (host-90-235-19-70.mobileonline.telia.com. [90.235.19.70]) by smtp.gmail.com with ESMTPSA id q16-20020a2e9150000000b002ac871d0207sm1558123ljg.88.2023.05.23.02.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 02:57:21 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 23 May 2023 11:57:17 +0200 To: Christoph Hellwig Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 1/9] mm: vmalloc: Add va_alloc() helper Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B33D718000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: b9ojuj1aahr471xa8c53bywuyiur9jx4 X-HE-Tag: 1684835843-279595 X-HE-Meta: U2FsdGVkX1+U3h5MtvWaL98ebaSATJ4XsA9wyTLt1KKbbcGqQ5zNW3hLHGaRVqs+pVaR+On2D+flUQUZuKcfYUI+lHyhJJUuKUFjQetAot6Ef+EJJGe+AusNCmUJh5QEA/eOOoj69pcTSOxNhoxlXdlpwuj5BEP/K0JrkIxBOPSmwdYxjEs2Lhw54orNImrRmvRJLePIP8EtUnzKy1CsExHAxqQ5MIs5Z54yIFyyxbSb5F0Akk3RXADKnf9WkupTfJRo5r63U/GeIIhJo+qteZNwkKSwJuNxj+9+A6M5MLAptT/T69KwqXoKIQ6zsHuIiHSK50/ZP2CH5PiiDdY7Y3dHNRhzGfum0Sffq3lbLxBzm5SPUz/rvROY/k/Jtaes5IWUIt/o2ts4YBnMtNfhg4RilgNJRgnZWRaHbpqRmudD7zsSM2EuOOZCbNisCv8mTFbytnfVXMVGp/bSRKJVmDdzd8TQbp65cV0KHWKg9cGKDcLX4ZYPtDgP5Ss74UmVY95y3ou59kMksMy4d3nGLQhKDXMzdsYDy0QU2IRDWaFhW6ugCQ+s9EOTD6dOgPPy/+B0X0bzBtObq4WagpRoICm/QIEiyj2ZwGDDkPZIDVwqXuD296CuXFEXu2wpBXKyXFet1XqGXrNeiFGpoXA2qcZWbEUHcjrliSBaCQ9kHjZyOxmggBXLMigopqSWEp0hR88SyvdvCYYFVK3zVy8gEea4lAk3GfhpM/rSOlk+hgORZ53aC9BwrM/RAweLx7vZewbroC2faTUhlDolYckoeYFe5gf2NVgw/R7omOTZ9nZjKC6rFgzqx6fP4tChp6ZRF5LRx2fLWUIGf+4tS1Bo3+j2zf2EAtF7NLiTD8UimJqCgtgU/UYNgS++C4lKgiUc/I7hhUGKbRH+yLNkDinAiX61S7LC/wow6/hWD0d6gcDGBt+JHsAmczyy4saQ8E6N4cKNtfvD3WdjBiDcmUS RxwfGCeD ZLAiJCLkdF1YVfjllhiLo54GhapTZgDwTrfRWtZcTglR95Zx7Q58+XL3k8MfKFRgahEJiTN5mgLq+yk0fPclww+POSgfSp5cqsZJFGscz06TWvmnu9ue14dFQOLkRauIsgth1FTm+snuMfUeTswlqMcoBUs0FboBRh6ZHNCZ3SjSEAHlsWbOQe0ftNWkDYmT28E7mzVWzd4bKOjYgKrUn1Wvy+s3NCeregvDfHvvA8zv9erpip7hJO7ybAoq3CQz0vor99o/lIJhSakPM3wRn95Tg+aXPthYY3GbTy/Slx33DD5DVW/Oq3NFBY7RNQ7KBznvOzLb+y90FVICgvW1dB89E2v4NZ/07yGD1zE357IFAJJMVdzCGBvlU09rA/UkPl3YMWKjxcbXDRYnhWYCZ0873lPmvmhcbUprTxc6quLwcTQMPY1xnfPr3iwHCSA/VNmonRkYgZvYxfFJGwhRrunnT+hpKKunZAbt97TQuqeZ12p+7sW6BrF3Kzi2OR1lIH0Mc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 11:05:57PM -0700, Christoph Hellwig wrote: > On Mon, May 22, 2023 at 01:08:41PM +0200, Uladzislau Rezki (Sony) wrote: > > Currently __alloc_vmap_area() function contains an open codded > > logic that finds and adjusts a VA based on allocation request. > > > > Introduce a va_alloc() helper that adjusts found VA only. It > > will be used later at least in two places. > > > > There is no a functional change as a result of this patch. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 41 ++++++++++++++++++++++++++++------------- > > 1 file changed, 28 insertions(+), 13 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 31ff782d368b..409285b68a67 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1482,6 +1482,32 @@ adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > > return 0; > > } > > > > +static unsigned long > > +va_alloc(struct vmap_area *va, > > + struct rb_root *root, struct list_head *head, > > + unsigned long size, unsigned long align, > > + unsigned long vstart, unsigned long vend) > > Prototype continuations don't use a single tab indent. Either two > tabs (my preference) or after the opening brace. I.e.: > Will go with two tabs. > static unsigned long > va_alloc(struct vmap_area *va, struct rb_root *root, struct list_head *head, > unsigned long size, unsigned long align, unsigned long vstart, > unsigned long vend) > > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig > Added. Appreciate you look at it! -- Uladizislau Rezki