From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2812EC7EE2D for ; Tue, 23 May 2023 06:40:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F85B6B0074; Tue, 23 May 2023 02:40:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A7E16B0075; Tue, 23 May 2023 02:40:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76FBA900002; Tue, 23 May 2023 02:40:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6724D6B0074 for ; Tue, 23 May 2023 02:40:04 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3734A40649 for ; Tue, 23 May 2023 06:40:04 +0000 (UTC) X-FDA: 80820569928.04.DD4A45B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 3B1CE180010 for ; Tue, 23 May 2023 06:40:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VajJCGfS; spf=none (imf06.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684824002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mhb2D8wxaUdoso9990IdDeANdXYgpQ6YKPHN0xOlZJI=; b=1k3/W6Nq96Hw5o0s2ULEdDf7GzItxH0GAnUHGQhQTrG1/FfkRqZIYwybjmLDA3yDaVyfvC 2DTNFCQ+r7scwV/A6MKBWpfZlDyypqIZJ6De4LJRaiU3fmftZtkaQ8ysNfNlRGl9SJvF3x 2Go2cF0WVfoAVaZNuxUMm3avj8SdPWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684824002; a=rsa-sha256; cv=none; b=7OMWgRIuS9YNM0X+T7Wtb2JDwhsiGGxLPgML9fNTJZYvOCj6miyJul/G7mGIe6tRsX5gRu olg5bUvlliOQB1lcCQQt5ARh+hjZ0aTd027zA6dW81De32Jf4sXWl1yU/O0GH4Xg0ddwmy dzxkWpA1F6Phw10wp4CxMWHOCvw2Dqs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VajJCGfS; spf=none (imf06.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Mhb2D8wxaUdoso9990IdDeANdXYgpQ6YKPHN0xOlZJI=; b=VajJCGfSR+AMMCU+kW3mWkdTex PDTINv6I14VakgdsK3oi8rd8/pOgiQyDnEKAdnmFM+rJfuD7iPd1MV5kBsEZFb89GTYSk/YBr8NwP 2sHVcrDi3gvQlOJU2b6PZ3pFE+ZUDnblCuhSvIN+P/vJcE0x/D3XUzYvAdw0xT8IY5B/gs9ILXKyM e4lmExxZOQXK2uHpddjK8X0F0W+LYs6KCveZ8cnkiTgoIkHBOl/B8XoN+u5KD7777UVAuVnvLtjGk DUseUSJC9jwdHO+SlOiMmPmFbRKnaLphaekqtwqKm3QXPfdYoLXgsj+NS69JNua4FhardcqypLLlI pZB31X3A==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1LgK-0096BI-31; Tue, 23 May 2023 06:39:40 +0000 Date: Mon, 22 May 2023 23:39:40 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v21 0/6] block: Use page pinning Message-ID: References: <20230522205744.2825689-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522205744.2825689-1-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 3B1CE180010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ewry4gx8bzp46ztzfnz31gdufi1968zh X-HE-Tag: 1684824001-29957 X-HE-Meta: U2FsdGVkX18rgUACLdSFg7VP+0RcqhKBRcxCyEVcMG4blhLx38wn3h2HXFrVlozJ/RjWasyRtXfys6KolfMuWrqbaeaMBDlSs+IWLr7l6wUgNh8fEc0I759Ak3KKX5WvHmXWkodjq1MsrGcFAJJwC6hc6B5ZK9ICgST2Ke2QFN6jIf3MHXYhnvJ3zltZkqzMg2j+9+X2HAU9gQCMlheVJn9yy8OZ1S0yI7N7geX64dHOPC4iTcrF/HXKeU4hRTcpUrusH6iFB9drarSKna9iBE/S7ssGl7MbXkEzINWpy992lfpsTCDiyeZGgtAQPBYSdR8KJdvRlG19+o83QH/2lvfJTVFpWS13ZN0cJRtyZcqp+RaR5VPgW9GlVYXyAVWrBCWjbgFvRC5bvX9uidMG7U06+RSv2l5ezbF6PrMgledtzw+d/CZRyAdQYDL16a+7O34W0RjjFVPGdLxvsRhg1a0OQI7O8EQk1cz53OYC+i0oK7P8WFsjS4/pYDigRzeSRCXsKfvLYsw5htf+ePJfYWe/YNTIDToFNAmOA9BqoB5lP+DrP7KI0GEjUA28Bz4IuOEY+nMjzYtVVAFchqBZCv1/KwNprydtbaYqDA+E3yojSSJCeM9br4Q/EZcEVQwvAyG1aSZC990nv/p4Qb4zM+pov4N6wk0cEYzJK1Rgyt2wGLsF2vDwswID+41ZALG8OTraXxgP9YjfUON/SWF1EQLUu9CQ4kOIqJe/x7CrqGqb1jirJa5bCAZCW+Yh7jjvRTCyS7o0qzArVwbybjkSExVHwAoZBnuPF7f2FbDZ+BX+8afrL9JFLdmocOqdS9hwUbqyRb5gu4CpHRH3nhIrzStrpKJ07TwiVY849PDcqZ9dZ1bvbw7QRCToQ48J/+zk3KB7NknFSvywzrYe0K+qjfVT6D8P/Dr1QtdXvb8gmVEyQoA8E/fB9H1+DKNRq4YppwC+V9znHFj3B8b5L/g 1nu2H4TI eWf/G9wlsfunjhiqTlDmepqcXPPGs163oM4FqrHumFqv8v3YEdoA5mg/29Eecnf5CxRz0cytSM5SNw7gHikcVjRxNDu1LyZ3NQ1CUE0ZpjP1IyclzFPUy559ectuYYOmwPEH8juthK0w5CfuWQFfHj6EAE6JRL5ftEH7XLPed74ivJhNevqTaOIuq6Rqd81gRD+Q6yfZyoAFOpT1fa3NtrXINGMu4orZfThULgm/Kp9ASlTZfPmoYI9ceUdGBirKld7IlV2AjiTEvEOhri5GSs0/fQJCir2qLAAt/qiI2xyGard72IW71dSg/7mac+tAFveZMYDeVNTy117WEaRCZ5G+xqRgxALP0lLfYIkLp5jU8KCdhZdEXRTOfdafUMf9gH+ZBNMxSqgR6r1M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 09:57:38PM +0100, David Howells wrote: > Hi Jens, Al, Christoph, > > This patchset rolls page-pinning out to the bio struct and the block layer, > using iov_iter_extract_pages() to get pages and noting with BIO_PAGE_PINNED > if the data pages attached to a bio are pinned. If the data pages come > from a non-user-backed iterator, then the pages are left unpinned and > unref'd, relying on whoever set up the I/O to do the retaining. I think I already review the patches, so nothing new here. But can you please also take care of the legacy direct I/O code? I'd really hate to leave yet another unfinished transition around.