From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0528C7EE23 for ; Tue, 23 May 2023 06:12:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D221900002; Tue, 23 May 2023 02:12:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3819B6B0075; Tue, 23 May 2023 02:12:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 272FD900002; Tue, 23 May 2023 02:12:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 188D36B0074 for ; Tue, 23 May 2023 02:12:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E175EC0674 for ; Tue, 23 May 2023 06:12:12 +0000 (UTC) X-FDA: 80820499704.27.FC5374C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 2C2EC14000E for ; Tue, 23 May 2023 06:12:10 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tAhQb7IT; spf=none (imf09.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684822331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ixn+rZNZqU08FRWrwa4R0S2pNfRR6ks2apgoACPUtP0=; b=mrmjp0K/9JARgPhBqb9/7DHMw8brBcUsORRVvl9tzivZyagRVV4i0L8inlAcQa0vgH9njD HWJ6ZlcztNhr+P0HAal3h52ypeiHk/I098iBbkO+h2vPnjVsWXQbd6xLFWUa9QmA8pPL71 y+41eMCH/V5b9OUAgKiSN3CQn5GuBh4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tAhQb7IT; spf=none (imf09.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684822331; a=rsa-sha256; cv=none; b=WDNkdfKuV70yr1aFlcZu8cce/0QkQHXQtWVvq9m7Ygn8+VLxdBAeyFjKpjV14+EfowjkDx u2txdo+G6uobJdkC1dF4COpO0FMOam6d+K2QXeupt1AIePFtU2k6wuxx1eIpWQEMemlik0 duleNKovOBklNQ7MU0me/ssJLPS3Rjk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ixn+rZNZqU08FRWrwa4R0S2pNfRR6ks2apgoACPUtP0=; b=tAhQb7ITM0IVw8kqDWDG1iI34e 5wjZI67d7Bvjdz3SBtq2hfBj3IX0v0U9et0Xa2nXwb11qNf/Z28zafYPTfJQ5MqxiSDui/7UV4nPi xJpNEiw3eGo0urW7+8oflokdeGO7iHnyykS1a83NHWvc3HicrDNy9WJYDHJX0FXKWEugVZL8+JAlZ F2rFecMK9pkHyfn37sFrHY3p4IVicFmZK74uWcMNJqV5WtV98KxQGb73ihDM1PFhCAyxeHNROsDnx 4WgvAdzyyuJKtDowLfwI92iLZ6riqDOAYXDOTOVfSXB2lQKRNg80Sje1UKwuXKdf5+2JYqgnUOhWL TvivjCng==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1LFg-0092yI-1I; Tue, 23 May 2023 06:12:08 +0000 Date: Mon, 22 May 2023 23:12:08 -0700 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 5/9] mm: vmalloc: Insert busy-VA per-cpu zone Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-6-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522110849.2921-6-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 2C2EC14000E X-Rspam-User: X-Stat-Signature: wcqwg7zdt79i7u8bnkofoawcb9bidiei X-Rspamd-Server: rspam01 X-HE-Tag: 1684822330-839091 X-HE-Meta: U2FsdGVkX18+YoKX6obMMjQnGIHsr+c2HIelYY3ni9Q8abtcaZLzVcxcbbNYL+z0APTf529Kb33KLtugW0gn7W4Croq6myDfXtFjBsBIm6ILPb1XcLwN6rGkaD5hFdRSUv61y1LYbu/QsqH2uLgz6rSsAimX2CAEnViLshFaN49/KrCQ+O+mYVmoKe2NxUdgqh9uchQXpHDWHAmnVC3m4LxPQZcDUImPJiNATryWo5JjJ+dfthSq7HrFGdH5c9p3w2J6SmdEogDSUlhyJ77vvrGSobQ1ikeLb+Uc/KhLaSIGsj4sOO1e6eDP5ohj4hXlm5bFyA7omjzKA7TsZgeMIK+fQLYjIuS6dO93QBk3+qta4W7nfy27EbdElaSw9vHIsRNgmRqCg/15f+DZ7m5xjpHBrENc1SXKb7/XYaPb1d6Lqd07gFukJG4zt6fouvrV02qQ7JzgpMzb7GUytSv1A6643pJAvlmjg39MtrUXRl2t4uTQg5NwJHzoaCuhgpi1TBNblhQYcLniHJs8B4Wxu/ZuUfDKqd3nMo2RIFECfjwn++eQ16o4/RGYlQRcrU6r/TKKxBKyq2qSepup29992xYLceRCCWh3edGD/pbWGykn6WktMOZ5C4Ztssrv944TmXHyT1XdgEuszLLl3PxycaXRGiBGVmDWJ4aWLb9y9X9FK/7EV+41cTNxpF1trPzQP7nRWC3tmWSqzuTAeNZkaKyX9PHqPf6KITU3b4LLHVdq0PGiIreBzuDBVB/TT3mE4hYVhD2qw5fWmj7F71rgzaLGjcpD7T3pxSku9FbTHJZR26Ank9L8/ZJHfiCRZsi0jE0Z2piTqZYJ0SKiKgeVwBa/tmnPWA2vGvxOg1LfOAo3AxltvCtp5WjCkkADNbJEPrXqvJutDEe0U3C4gLUa+aakk/eBnojpItKVcxeKo5oz53Km2V9PtgYnjx1nHnrGGC7ZJPG1DtpjBscTswJ Xa/T90kF tkCb3vdDIgYf/4OT7ZcGEVbGcUgT6fzIzNX5N+WaZanSLJlCHZF/hqMhM5kG8W2AEZFHEZBqyKGE0x/1PWbhMK/1m6z0UJEHIVu9BTb9c6qtVcmCYGNgzg+8ZjQWziSjWZOqzKW46wiMQaZ/ofC1IaDSn2fElAUXmYgitVgt1WW4HFnrpl/rW99h7CW6CNkZ0RF5amRMepnclu1QWXl8FjX2TmJT5LWFZEXoi5zRkQvcjBUGafuSR57jlBJxtrmaM5QvQ+ZGgLbdJkwZXECbqP26vnXRpha2xo+Pf/ptyBE4yQvzlDmqr3ZEh8ettqfl768iKCMRTPbkUaq9fj7tkTNeUP+4azH5OoSvptH4wuz+MjY0BKnAGCh9A+pCc0MEs/93xVVQohaU1BNyw3UpGrsu0/BEPd8OBsVtv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > /* Look up the first VA which satisfies addr < va_end, NULL if none. */ > -static struct vmap_area *find_vmap_area_exceed_addr(unsigned long addr) > +static struct vmap_area *find_vmap_area_exceed_addr(unsigned long addr, struct rb_root *root) Please avoid the overly long line. > + struct cpu_vmap_zone *z = addr_to_cvz(va->va_start); > + > /* > * Remove from the busy tree/list. > */ > - spin_lock(&vmap_area_lock); > - unlink_va(va, &vmap_area_root); > - spin_unlock(&vmap_area_lock); > + fbl_lock(z, BUSY); > + unlink_va(va, &fbl_root(z, BUSY)); > + fbl_unlock(z, BUSY); I find the BUSY magic here very confusing, and would prefer to just spell the actual lock reference out.