From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41741C7EE2D for ; Tue, 23 May 2023 06:08:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B4C06B0074; Tue, 23 May 2023 02:08:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8651A6B0075; Tue, 23 May 2023 02:08:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72CA5900002; Tue, 23 May 2023 02:08:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 601346B0074 for ; Tue, 23 May 2023 02:08:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 39F0D140669 for ; Tue, 23 May 2023 06:08:42 +0000 (UTC) X-FDA: 80820490884.27.4326355 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 872F9120018 for ; Tue, 23 May 2023 06:08:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="RO1JUnR/"; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684822120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=owdq4bOKhiwEwPqay2Uzo5vGXFeLCMdjpZNuyI6GdYE=; b=JaWi4lf28bTwE9XMYuDWo9TzfdIO/lFsd49wEdTDCK6LXYl9cMm1lcCDBva+35wbabf0gg wvchlNytJ8/uWrO1qjZarugm8p2kEzgfUv7Gu7QW0TT4jma6G2ODJ5z0x2GOSFYISKfnQO uphBjzKJlyU0KxqdxwWTRwk5d8lzJHY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="RO1JUnR/"; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684822120; a=rsa-sha256; cv=none; b=smrYFDatrfFaiLdj5bP7KIDkoYNMiQVz1mbLNC+YnaaKE2plRSRmPPjwmNaLjfu7muFT6Q DZjDD4LJaZSKicCK/sBGeR9LbZ+Sfz4FiwEhanxbSuOPuX4OvsQEUXGQSJY3CQ8HwLh2uw lxsjOqir0b1KbGTa1HO07DuMLpAN24s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=owdq4bOKhiwEwPqay2Uzo5vGXFeLCMdjpZNuyI6GdYE=; b=RO1JUnR/Vl76GI5e7oIoVCDMFL 60b7wwVYKzB424v4KXseBhfAmA5NNwHS1YmsBUKY36zoIJrjyTe33ITJ3M+ZmQSqkwXkw/QfjX8uO 10nmEzrSxiMJ+RBjTKUR3U7XE70hf18yDEAn+MzFDrPggztPIX64sBaWvy1O7Leek2wUTZsIjT+gp U7b+laX4uAx3POHayAnl4Imo/QsJeqNrk0mF4NRaFkUS3hvpRh42P7eOuYNaKf3m2MpqWEv/i5qcM Z/4J9NRw41NIllV/SmoCh74hBQeN9uHSVvzoUBzR0UcjgrCHwmKdlJk25H9fptOnLkfUDmC4kPQms bR0NWZkA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1LCI-0092f5-2r; Tue, 23 May 2023 06:08:38 +0000 Date: Mon, 22 May 2023 23:08:38 -0700 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 4/9] mm: vmalloc: Add a per-CPU-zone infrastructure Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-5-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522110849.2921-5-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 872F9120018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: c6u44ky8n5jrq55dqeyuokg5ouokqyiy X-HE-Tag: 1684822120-719299 X-HE-Meta: U2FsdGVkX1+NnpELETplwnWyaVkoeiIJiMshxisF72nwKMP+uM3Z0/xteE+JWrBAiaTtmCDb/J/hqkLpgOT0Ulqleh8Ceji240uKdAc9E7bK9ESEYc/kCnM7Mf5lDbWAVNLrqrxy4JWNCpBt8y9sYqLyh/CqhIZ/Efz807gWKDLwtKkuhaFVZjQSWggLU20VkSIEaZtUGps+ry4zn7pslZqAIiA/8xeyJFw7d7DkpSzRVYh6BkbSITFSupTBMWcbhnmCnX16KaQJp6SVcD0yCUlDMuiziG7gcLQ1pzf4wQqgkXNbYZ5dzgA+Xrw4s7ShUr+G93GA+qQVvCKcW7FrlzONdmoz51TwLV1x1/jHbXAU/EoNulo9RN9hiakxjChbYbNZd0jLQBhis3+g4y1PpGSwoDYgiHDeyCCQDgQg8+B7temirTyymoyztFf1R24ZYTF1DN/+XBlE4PETFf18r2/xw4RUePUqmieXMbc5vYX/5DLmXj52Qv3XZ5KtiMZuklrZHCWsspWbA4xvM7rpFVR1RVPJAiBaBlt3pyN6qLYW913ud6h9H8tP5wdE8tFaId3qzTm1XDwbe2t18mM5/BRNh93KAOHGnjcs8GULmO+7GbrCQXvwLraV0sj4lo3XE7GvnvdM+4uRphg0+q8UADoeKMpShOHLDFOqtfV+wXDUe8KVWfe+Iti9xg1k106/Dexc+jpU4ZnauDuYlKLhkXiqOKunTR1Q+Q5AI2A/TbjJknnarhdZnUhY7LLicvvoyrqW5ktvf8xEeHjKhUIjYnu7q8SU9jF/RqqST6tZw5oqDFvt7pAzd0sRkhAuHPYApEgZtRgfaIjxR5hHkqT0bhJCsOonI7akQiQ8x/tY/y5gm2MQbo0Eq0jOOZfZy0i3VduJGHNLwFKdfPkFZ6DiRwAswOjxetzl4u0RzbDfKW4jMaN3UXZ2XXicHgCfJiUYmmj8/Mhk+3KoQV9pihX 7VyJzZdz LeKEIrBBfqzYITdJiHKLIQCqkFTlCp7SVXFwkin5rb/sCwpCnrTPEqSnjq+IQ5ayzY3rvnKSYMB78Kv8H60994arLl63b4eIGQ+n/imJ1cj6Xvqw6WvHrkZSrzMJFpfW2Mp+aT5Aa3R2oMChHacwU3KuUbMPr2vsA1WhBZUYQyOtWar4S6didBaqSIrNVZ7mcMSN1ZMKFOookthNzRqs7O/agXFqDm6S7QqWHBxDQ4tuNGItBmNcjYloE5cnWSIKTUkd+6DnoP1EaWuWTgYu24ThcNux4ji8YyrAo+Z8FzmXETQhQebR5C8hADIxwQgdnWf0vogQSaJPyeQ/WqGT4wREJQr8QMbRgcE8SCZ0weq2s8IumXNlW8JZOKEVqq+9oUaG6EFCZPvmJB3g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 01:08:44PM +0200, Uladzislau Rezki (Sony) wrote: > +#define fbl(z, i, m) z->fbl[i].m > +#define fbl_root(z, i) fbl(z, i, root) > +#define fbl_head(z, i) fbl(z, i, head) > + > +#define fbl_lock(z, i) spin_lock(&fbl(z, i, lock)) > +#define fbl_unlock(z, i) spin_unlock(&fbl(z, i, lock)) Even if it is just temporary, I don't think adding these wrappers make much sense. > +struct cpu_vmap_zone { > + /* > + * FREE, BUSY, LAZY bookkeeping data of this CPU zone. > + */ > + struct { > + struct rb_root root; > + struct list_head head; > + spinlock_t lock; > + } fbl[NFBL]; Maybe replace NFBL with something longer and more descriptive? But also in general it feels like this should be folded into a patch doing real work. As-is it doesn't look very useful.