From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD8EEC77B75 for ; Tue, 23 May 2023 06:06:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 226B0900002; Tue, 23 May 2023 02:06:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D6CB6B0075; Tue, 23 May 2023 02:06:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C7D8900002; Tue, 23 May 2023 02:06:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F2ECC6B0074 for ; Tue, 23 May 2023 02:06:03 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CB21714062A for ; Tue, 23 May 2023 06:06:03 +0000 (UTC) X-FDA: 80820484206.18.FA6BEF9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id EE51F40002 for ; Tue, 23 May 2023 06:06:01 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=c+Zpz1LY; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684821962; a=rsa-sha256; cv=none; b=dZ0bt6fwh9IH8KaWrIMrg7O9nXBYQ+0PerElPQxuA//szcpDqdWufet5DnwudeFoP9fm9X uZN/mFxH7kc+m10hZpmohDIa/3ju8Z0qwD9fNq/rDBKIzU1Rcm31fWdQb87WsglSa/nt6B 2Bih4u5QhiR5rZr1MmCJCgeyd3G1g5w= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=c+Zpz1LY; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684821962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qCSqRU4a/AsmBcdv6iFySShWfg8XjHUWfeGXvA0y1bo=; b=0wJl4k6w3/nWNr9t+YBpgHwXLiUmtaAR9ybrMpuB1RzxfdWZdjA0yHfxMJuKKjensAoivj M1Gf4Bl2w0u8Ez9jQloWtr9iIKwU8zOHPUV5xW9c36a2nguZj53pc5KBuoeNiyRwpj/hwh NPVgddod3r6p8cTD/QNrQP8teiANvq4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qCSqRU4a/AsmBcdv6iFySShWfg8XjHUWfeGXvA0y1bo=; b=c+Zpz1LY9LjeY59YL09M41TiAD Johlulku37xPjx21Je0nBNT4hTLy0GVlvzREcICEC9Ay0b9XMgFEpLT/5qEhgZl8WwDb07aSxxSGm XN8NCq/Qs5n8fANb+AWvcekDppF0HtwpOnJmS7epKKWKD6yPgNkKezXsSHqauzvs/rQyFEjipBqQo tJZTZ/L2EUqit8LES+1ArPDYX5c1vhlmiQUkMrO5Psk716PS/swRG3D+/N3A5RUz/jcVkilGd64Qz qkTTMvfuSJSjQ1JZrL/sq9FhHWcdoTHNWnYDEYbZumxDfJUZXRjZJfUc863GeIcpXwcamCf0PfH01 QM6pR9Nw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1L9h-0092MO-2U; Tue, 23 May 2023 06:05:57 +0000 Date: Mon, 22 May 2023 23:05:57 -0700 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 1/9] mm: vmalloc: Add va_alloc() helper Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522110849.2921-2-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EE51F40002 X-Stat-Signature: 35pezyk7mdbo4giszeddp96n5z9ugpfo X-HE-Tag: 1684821961-637776 X-HE-Meta: U2FsdGVkX18G0U6vfogRm4CgnHSwk7ie4O4sWsX3M3s566jKs9uwJPsxnFVOis/c0pfIWYwOgYVPhmj92Ca2I5bBepGp9RaQuOc/xRnovifE62HNLlzNdgVc+Sx3/trcLgZoCykhem+Dy4AHcrKSp3UDzKF/26NqY2sUbIgIW1E2IruFrKV3XNYieIDZ0snlnJJuOEi6xItdoxHFPOvMkemvvy42HTTvr6mFthIrEmKFR0zRc9VR3okR9Jt674ZVADTdJUseS+z/JmyX+RZZ9o95HQxyeDII7eE+w1lvgr3dnakwJXojvHpwVYbrFgMbRGT4c+TaaEO18LJrnBPvM1KpFwgQHB4TpglRbmNvXTvf9Mn5OClXWwaLgmnGgGtcqhJ8MGiHeQzHu8cLcYPvIgpu1qafgt3dcM5LZfaM4mzx8Jva+VrEBx7Ajat4gyPJk+3HrDwdKtukLMHncY60uxmN8o6bBFOSJgcwrv5QsWYl8mmaN4RAMaFJCgN6ynfvMIUXSayXGOx00je2IJ5amuboiHFd2XKsVtDd3yyTcDCbQyG+qudSqvMvcE092trUmhQT5zlj0Cn0ljilw0xNa/A6VnvsAWh+Mgx5bp19TrNpCKE5sZxqk+pyhFfULFOexxRukHcVvYem9Wx6aBl937+NBFp6WmSQU0qJT/+kJ2b+whUhf0hBOJu9XKsrwr7uRvx4gDuJti9Qpb+nCyu1Bs8uSiHJXK0MIANjgMwRGd41k7E9+wpGtMFw3uvo+SfCNO5imqJiAZ/+EwYcTicwr3XOJJRL+WEsnrFpOKAmugqZit1S+lTCNwG+WO21VX3v6To/2ag/Me4q8Q40gWGiecXWM5K4ttSbmUqTj8DcyeammXjRogTbTy1KcaCM1yLl1G7Xz+lFE+x4J+3MnRxXs3KJXOWyb277wzmJmEolAyDYH9BNneF5UJcUM0VolgbtodccWsoJr/zbfBvlT+E dxGRDZXJ xoXCVMYY+3+NJj50RaIfymDAhygqlurhFX4C0p82XefOU/kuafMdu5MABHJEkpZdl4+pQyuDn9LiTyB6PV2GGuh0zDwTH+Fv5N696CvsRudxYt2PuJOVelhYE+z6v64QI4c5Be8fdcVy/YC/ceO/wbniAM3EtibNbgVi0ODqIjtmQFCqSAd07jfmWRZXjDeBoXNbJ3H2wi5inhGOmLYd2BWb7Z8INEU9LbbCAvt2N7tNGGFHQ5hYoT4ged22szl7d+LPR1CKeGg+TJmoYOLTBQl34VP4efXBAvohh0k+3X1cveoGH5yiOMeV64y1IJJniSclgqaU0PIx8p09W0RMPf8lUJqkm4D+dowoMFCVlCB0RYjKPBdAlHLfLeZ8yiUHnwJkJfnJUpzFclqMGV02vLq/0kA/6p/Uhje1qUWTzK16pDvv2RtFRyrTh6lQK5cj2jNMVGafUE3j29Dc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 01:08:41PM +0200, Uladzislau Rezki (Sony) wrote: > Currently __alloc_vmap_area() function contains an open codded > logic that finds and adjusts a VA based on allocation request. > > Introduce a va_alloc() helper that adjusts found VA only. It > will be used later at least in two places. > > There is no a functional change as a result of this patch. > > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 41 ++++++++++++++++++++++++++++------------- > 1 file changed, 28 insertions(+), 13 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 31ff782d368b..409285b68a67 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1482,6 +1482,32 @@ adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > return 0; > } > > +static unsigned long > +va_alloc(struct vmap_area *va, > + struct rb_root *root, struct list_head *head, > + unsigned long size, unsigned long align, > + unsigned long vstart, unsigned long vend) Prototype continuations don't use a single tab indent. Either two tabs (my preference) or after the opening brace. I.e.: static unsigned long va_alloc(struct vmap_area *va, struct rb_root *root, struct list_head *head, unsigned long size, unsigned long align, unsigned long vstart, unsigned long vend) Otherwise looks good: Reviewed-by: Christoph Hellwig