From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80491C7EE23 for ; Tue, 23 May 2023 06:06:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02A44900003; Tue, 23 May 2023 02:06:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF5F86B0075; Tue, 23 May 2023 02:06:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9769900003; Tue, 23 May 2023 02:06:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CA5D06B0074 for ; Tue, 23 May 2023 02:06:35 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9429B12069F for ; Tue, 23 May 2023 06:06:35 +0000 (UTC) X-FDA: 80820485550.13.C521F6F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id BCBD7180013 for ; Tue, 23 May 2023 06:06:33 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yqbjnNtx; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684821993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cu3w1DuGiZvnpJp9hA5iYO4+S8ACeWvD7fPOFwTEApY=; b=pUvcMse01Swh27Pqwu16xIVdRFyZSPj6m4TtX3e1FJEiZdLGweM4h4D8ytMQnddJip7nTb Liask1QAtyXb2DiHU1BCUIIz27KddpH2tWgBA70/o+cPfZE63LugewEQqWVjFhSTRRzgcA dfXUmM6bxVxu9krc1pMMEtd83fvK0mI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yqbjnNtx; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94f2cc27045a2f3b6263+7212+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684821993; a=rsa-sha256; cv=none; b=mhHuiO0SKG//ID+U/10IArA3JqY89/p/47DdcEC+SXIZdxyWAY4h4keZ1R6rfTg8eXA4zg Hk9nVhociVq5zuAnu2trL4iUlb8HYBttR1sOpSlfphDaseCDuW/qq0PvY/4w7ldZ9hSLb1 ml9P7z4Bu7CTd3Y33tFHXpqHSK6JpD0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Cu3w1DuGiZvnpJp9hA5iYO4+S8ACeWvD7fPOFwTEApY=; b=yqbjnNtxq4kJd6ZUyHm1A6FgpK f3mEjqf0oiObOjorBNIiMxBafBzrZOcfm9AL5HUs8MSc7h9EFNBoUD/wNNUXDeJKwI2jtFQMbCzRG TNj7ItekEawlS6puU8HbyzgU6az3ABNbb6NNP/zK7mS7nuPDc80N8Xiw9blCTbzt5bS2V1ZyrGSnB l8PREeawaUl8mwsa/G7MeONzthvCiuHyPtR2b5N6nvTkZbW+ZohuqIyRzFHzjmv3B08N8+7JL7Dyi mKugWQjK7DKbKTpmuWW+BK5d0Q5Ajk8wHWfN1etrjwoYH1q/l9u/k7FNdUb9i3apkkNruud7OL4xp vqqFKAzg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1LAF-0092Qc-1T; Tue, 23 May 2023 06:06:31 +0000 Date: Mon, 22 May 2023 23:06:31 -0700 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 2/9] mm: vmalloc: Rename adjust_va_to_fit_type() function Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522110849.2921-3-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BCBD7180013 X-Stat-Signature: jfya7zwyuwjgzind17afwf9c33m36nwj X-Rspam-User: X-HE-Tag: 1684821993-437553 X-HE-Meta: U2FsdGVkX1976Ui4i2B0CdCUvzUUMTLZjb1MPKM27cU5lQvbYDMGPATGR3AIf7nWjAISmSIaRDdV6bPjxYfs0K/kma9kWh7VAxSKTKB8SXuGir73hoFiZcWzKCAL36V+Eu4pSaBkacTtUNyOUmWatY9pG0iSfnSklvh0Y2Ljlu60pt26U/pIwI5G0QwVCwxowE3XDLYDa3BWkCXZuvtvNMIP600pvaKjacb8GO5F4NNO3yuaHASpyZlGitGVO2WmjhW+sdlqdeqVgAtUWLj6kGy/krx0B8C8v5bwt/k0lLyrGjpzifbcPlUVTO1xnTDWP8r+upsnaATmnErdVKYKJ6eBVoG/nI+0asminskL3WSdxm8VaJW+Qc1ZGg1unmcMqOHpGgM38ocPhoC1LiMI1voKiV6BQlQOjq1OVoieJOu1MhqtGuDZibFBRN3/NKIEBkxFmEgAoH5pskwTZJjDbLc5mhhbhSMXRLuItJ9hPZxzaCAyQFCn/V3MLeRJQmB1Ysr3a5cwoLFv5/jujfoMBonhTAW8x9ceb3S0jgG6Dm6AxgUnbcMORmItOZitGr7zIz6kAjWIrAYF3MmUJqs8s43iu91zTYmHfdOXesD6pQXsSlkedVnly6/L8LyGyXWGDh5isyYVB5es/O+UVzyREzagcBAix1y2dMOnt3EFldwdIMAQSQ4MvUVkyIQH4lpuXevEBDHw/HhGJjJnwpEuM0ffvQRFucJfOb6tc8YK5qlWV3x8NbaINA6NtNW4ujMQRDCjvMkJbvX3xO2wF9tpI68BAPbWrsZtgVj0DDHl9VXZSLqx/sYVm5FY7bXXX1kO4hkFS6+lijXCylCTfdmWkyKxPghZ7sFaLAQv11cTWbe3MuIPruMu5Uh1JKxH55UTBdvhFUw6XQNZPGheWgEHKoKn0YrAMD7S1P06dHaF+IRon9FPkVnivdzl2VZiRAMdzwkG5PEPI4ddeWqlV42 XUyjSRkv hGuDkgo56xYYDoX6M5U60YP592eYy7QVeuDqqnCnCn1oiMbYsobyPuIptAh1H53YcE3bdBsz1BVRwJAjTgzvWcbIbqtJXTSh07PGVqTlEZPqIwhfKz6ycsUYNzeAJIXrWdaO7Isw87jk8uWn/j68igIzBjKsIDQbASzteGpgPHG0llHsfwnOoUtFZZuuKwY2YJB1jrgBNqVAarbM+9JzXdCeDIgWGIVbKj0vfnSy/Mbc3xT+cvxbK8V5pUfzbnV9KJdinu9PurYiDrlUui762J3xUE73ScxBkLKd5NU6gAkaZSBoyz7unmWSUM2/vEGTbpfOZqYKDAAzjEFvDn2WUBKP2HB2Kc6Asd7xOnU87vREl8neZrL5/azz844H/qLA2ml+N4BBaU9oou6582CRphLWLE6Se1M0FSNTFneIflOGk4Yy63kJnottUvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 01:08:42PM +0200, Uladzislau Rezki (Sony) wrote: > static __always_inline int > -adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > - struct vmap_area *va, unsigned long nva_start_addr, > - unsigned long size) > +va_clip(struct rb_root *root, struct list_head *head, > + struct vmap_area *va, unsigned long nva_start_addr, > + unsigned long size) Same comment as before, not going to repeat it for futher reviews. Otherwise looks good: Reviewed-by: Christoph Hellwig