From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B667C77B75 for ; Mon, 22 May 2023 15:09:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B6FC900003; Mon, 22 May 2023 11:09:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9674C900002; Mon, 22 May 2023 11:09:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 856AC900003; Mon, 22 May 2023 11:09:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 764CA900002 for ; Mon, 22 May 2023 11:09:57 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3EB8D40354 for ; Mon, 22 May 2023 15:09:57 +0000 (UTC) X-FDA: 80818226034.19.43B62BE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 9634F1C001B for ; Mon, 22 May 2023 15:09:54 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf18.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684768194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q8OzWUZsvflNIb/jtrCNrZDZLowr0ootMQq0jTF5q4A=; b=tY8dw133I+89ai7JV/hoMC+fNG90j3jx+mpyCCkBVYFO06pdBNWPK72rhZzoOSVLqNvfHx qQnNq1idecM84uWUIS2F9QX8toMfNkdrwr4+ginwWwgoj8kuVvYl6x7PGn8vCQcFwXjsTu 2nb4S1DlBKLSj8W6wn77b6UrmCntHlE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf18.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684768194; a=rsa-sha256; cv=none; b=KCS53JfBM+THsJyVFrCXnOFQx+kk2rLmKxSB4jhd+gGszAm/ADJ6uZdLV4/jxNRVQSzdNF qjmluSFgWaqT3gULVM376ZD3RKr8gxBcCl5vsCt/ZGZQoDp4obg30r4/Xc2s9zpNNL2Q+h 5k25iSjp+mXoLqRJlzF5oBSpU7X2stU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A12A61A5A; Mon, 22 May 2023 15:09:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C414C433D2; Mon, 22 May 2023 15:09:50 +0000 (UTC) Date: Mon, 22 May 2023 16:09:47 +0100 From: Catalin Marinas To: Alistair Popple Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, will@kernel.org, nicolinc@nvidia.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, jgg@nvidia.com, John Hubbard Subject: Re: [PATCH] mmu_notifiers: Notify on pte permission upgrades Message-ID: References: <20230522063725.284686-1-apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522063725.284686-1-apopple@nvidia.com> X-Rspam-User: X-Stat-Signature: 334gbowpk6krq6u35c3p1hmzeq9uhtuy X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9634F1C001B X-HE-Tag: 1684768194-298864 X-HE-Meta: U2FsdGVkX1/2Rg/dE51/YwtTMOF3oHtGP1O5Z8tPT8r0KZ6pIYN1rQf3F3lGAIjrtEKnIi8cSr6l9/usyeYsagixcjMmY9xSULnj7B3DuIKThemw7l3fMjptUZAXLtosl61fFaehdsfImynEONdQeA8fyFN5TcS9W4PVI91j0Su37H1jXoXkINGFRw+6W0eLHeG1tIXQca4k9Ymd9oA5o84B9wNQ1VMa0+inDZOBm4+BhsGn8ZUglxp06Os2XI1+2jkFP99OdFFNbs0ysuXSCOEwNAdwpnGIqViBisyAPF774m1uBkdyySTjNV3ePXJ/Ilos022nASlkjRrz/NL+1CxJBIhn/xI0pvfL7JHK5oFZqM7wofDj32u0f6pVFY9w7bO0Cm1QBLztSf7gfPXAZfjGr0VOjkVPXEbnnF30SMPQxYeii5HmkC2ouD1/1r2wKB/4Wc61cmUr4h0p1KtzkOLKk9kIvij1IvxSeRXcnTyNg5INxP5/HnrMXXLDvsZUPbXdOIlLOnqJ8IFNxFTBsUKZXWTBpWsL5jM8YYhnXVNlWkMnvRZaFOdfpcN5P2lmE6iwuBvvuV0G4Z0EKsbHv5vD4p/mBIIF4wn0Gt9HqjqydgS/6x8nNDFYpePPNK2XdQ4/pQBaHSYmY0mJutD6PPOYXCrJGeDqP2/kzZZc+aLOy9cPamm0lOdHBydz6TO0GV2D1ixNptRhR55FJnqIdLE+/iXk1rOvnYbIay/jQNOV4PzrRT/LL88pO/qnOp+coJXAM9wHHAGqUfU5j6cNWyDQlEp3mUC5LIv1DO/K1ZYBZRSpNd/GlA11Ls74vL9l8KrFYQMSk0bTIRp96jTT58k5ZxAxlW4semwdv9RfKZBT+2Ka3Q5y9IcJhxG2pFGiRooht5tkhTJ2WBw4ffdzoWf3mTHW7Yln+A7hhchL1kL+u2bgnI8/dCc263B2XsVk6MISAOlKc3AlE0QrEBW CVCdWV3K i4PHmzipRMSprHutGT8ZdnInMDZFzOEnZzuXxRCtqPTnsYih0IsE6Xr3hjdz2VvnvsAamS5ZgMdimVPOrxLTgA3ZSWRv4hbMnKV0fOWvAbSGJb4MSVnCIu57H+GTiSK3T334mOaUXQ1WBLH1iE+XsVnUwLJrrazz2uhmGpWLa6H8kmMYBmxibplMwyhW0JY90q2X5/HPnUkRZMHJjU+82wiKEdBCwWHQLzEv8OxVKINJLARqeTtantB1qxmdkRnj6jtbPLrQRMyPklMnsa+swtKGstRfCghK64Nbmfr0k/aHC2sKlLVIpdjjTxkKVi4Y1Z2R6G+ecz/0n7wLITs3JpIsd17rEQwI+31vALtWdGxemcXfFLQ/rF/zGcPxDRceuclnzlaQoaDxnC93TuX8tcNsy1rFj50qHfbE8KWL6TpEwQuGnPPzT5x7GUcltKXq2QoQ41s2i5Qlgrh3WV9cBMZxutQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 04:37:25PM +1000, Alistair Popple wrote: > diff --git a/mm/memory.c b/mm/memory.c > index f526b9152bef..0ac78c6a232c 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2098,6 +2098,7 @@ static vm_fault_t insert_pfn(struct vm_area_struct *vma, unsigned long addr, > struct mm_struct *mm = vma->vm_mm; > pte_t *pte, entry; > spinlock_t *ptl; > + bool changed = false; > > pte = get_locked_pte(mm, addr, &ptl); > if (!pte) > @@ -2120,8 +2121,10 @@ static vm_fault_t insert_pfn(struct vm_area_struct *vma, unsigned long addr, > } > entry = pte_mkyoung(*pte); > entry = maybe_mkwrite(pte_mkdirty(entry), vma); > - if (ptep_set_access_flags(vma, addr, pte, entry, 1)) > + if (ptep_set_access_flags(vma, addr, pte, entry, 1)) { > update_mmu_cache(vma, addr, pte); > + changed = true; > + } > } > goto out_unlock; > } I haven't checked all the corner cases but can we not have a ptep_set_access_flags_notify() that handles this (and the huge equivalent)? It matches the other API like ptep_clear_flush_notify(). -- Catalin