From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBFFC77B73 for ; Mon, 22 May 2023 04:08:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EA2E900003; Mon, 22 May 2023 00:08:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99B74900002; Mon, 22 May 2023 00:08:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86231900003; Mon, 22 May 2023 00:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 74635900002 for ; Mon, 22 May 2023 00:08:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 45B70ADD4C for ; Mon, 22 May 2023 04:08:17 +0000 (UTC) X-FDA: 80816558634.01.38D1358 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id E208BC0004 for ; Mon, 22 May 2023 04:08:14 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rtEMEeQl; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684728495; a=rsa-sha256; cv=none; b=EuPw0F2mslV9D56QFqUb40CjNxlVvtq3DEEInauTJQbaeXWlW8cIRr+34chaj+H0bM9tsn adNb5WUaDfvFd6SQGM3FtREzFoPNGifltrsYQWJ3i2QLit4mXhDR18n0IHvZFYjCk/bd6D WC49ec7R795mlNC3eegkvKLuOu/wbgw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rtEMEeQl; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684728495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0/snmGSuIpgVM93/uzUSc6arNhFDyaJVOF59ybeoIhM=; b=bk8BPRgJY9IjN+m5+JmWYQxHW4h4BFU6XTjc5CvWfdZ7glgLEl/7chY8RGbRjDCuGrCM6M g0w89AuRXjzYp+IPS6+Jn0dRzJMqXXWtJ7TibdCZKwZj+bZkza0pYT4jFHM3OO6eG0amZz lH3zuOvQJ1gLDh89Qzu46xjm8MDBZL8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0/snmGSuIpgVM93/uzUSc6arNhFDyaJVOF59ybeoIhM=; b=rtEMEeQlFvw19x+165/zWMjt+1 4pXC2vcvKDZG1H6x8xWBBAbhNyDk8RSnjUivwdVgbtYpSIpiOS9FZ4I3u/pzrl8FzWxfi9gVSNuvw 2D+qNY9EMovdN6SfvIfToN3/pp0ZvzP9x9frTSGbNOEh05pNp9LRgvWMwXgK1S3YNWkM/taSVfdhI 5ioXaxvWspeLaHFIGpcPtXVNjZ+WR2I7fCyRVHitOknBub7dr8SY0AYyjjwdqAzbbRfcHXqpU6INr q4wB0b36VSOfDIDzqoKwMhIjijC6ohcO5DaCYisXfNUq6GTZzo4apCxjFVCGjGEQU9g3mmZ+J95aX UrMxiioA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q0wps-008kKO-1i; Mon, 22 May 2023 04:07:52 +0000 Date: Mon, 22 May 2023 05:07:52 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCHv3] mm: skip CMA pages when they are not available Message-ID: References: <1684724882-22266-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1684724882-22266-1-git-send-email-zhaoyang.huang@unisoc.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E208BC0004 X-Stat-Signature: k1b93abfe6k5449uj1ycf1xhqci1dtim X-HE-Tag: 1684728494-648541 X-HE-Meta: U2FsdGVkX18VicvI07rSIAFZKxWSTFXOXRdB/bGgxCAp9q70TIKiKwDj+PIIgi0GDnDKk3nkVOvFIc396rOUGyRE383LzkuuJHZEZ4zHIe/tGFXY0yywy7rcZCF8Eu2e6vNuxC4nT7h2f5Le25yihcw++PJ+K1othTfxyx6ehn5N97MA6E12Wdr+SxUhLQMavaXqyU2MHJbgxTjfx7VMyXs/anmmSHpyXftdTLeB1Qb4nDHGZcXbvSYwV9vrFX3xXwuvKE0/XzJB20HBrTCyH9+V5VIblSZ0kwtSZd/MuZm4HM5Ztuhuu32OjgybQm35L0yu8IiNi0S7JaUg63456fVJGQnucjV8TW82MspNStsC+vwR5PZcHAG9GgG6d9tfPikpPQtcuCH1DPDJVAihI9YL9H2y9j4dB0ONyX+iVQUlrWFmbtVE7mFeQvqHljKbfeNBmm2uXShbEaGcbxAWiAByKBNIVDV+xOpzEXO5zPymMxfsUct7usiIWn5w6OFoLCnXNIS1zCNekvwr7BKMfqZ0msjeTNZ4bM7UvmcTIQlqTxRoVbyC9ewI/YDRGY6D2wkNOzDw5xP9dpJNLlKa2epuIXTsSWekOQs65lhNB4TT7A5JHa0HWKYloJTOuiLsuKIQj/S39OU8dQi1HZTGw0ONI3MiUCJzlUsgxTmqaIYnufHMQljKje3Pwx7AiK4h2pYsMEdeP8BUII9Q1NYaLyP2/i0f1y2GuViNwYawcxlnRUmmYCY6gFwyyURTA9CdQpBU75WIIkkXLhpLQPorTAlvWRQh6iAGBRoKJKovwgwfUtCs4vceAZD2AuDUK7Obq3Jhew1S98niQ2PeWtV+/THl8OM8P2jxUIyyR2Am3IQOya06y/dYAPCfWmL/LUD9V5JxURwhrHuQzLjr+pO9V174kp757saifaSDH3lrsYBgeIufoJabEhzjbWkxbFRe+nQOkRz7jwV4WEwc2UO GF++2Bla w9E/XPKl6zpA5SYwpU+5IiLYj9Ghsxqht4DVG1FwoDlLsqhL4UxCYBmOO/FOXaaUmtgj+uEqAV5swQfwr4yyof+Je30H+efHVAeGJFCbLAOLWnqZdY0I19YlR0sQtNwATzZdQEKpd6JCaOak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 22, 2023 at 11:08:02AM +0800, zhaoyang.huang wrote: > +static bool skip_cma(struct page *page, struct scan_control *sc) > +{ > + if (!current_is_kswapd() && gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE > + && get_pageblock_migratetype(page) == MIGRATE_CMA) > + return true; Putting the 'return' at the same level of indentation as the second half of the conditional is wrong. It confuses the reader. Also, the && needs to go at the end of the line not the beginning (read the codingstyle documentation!) Also there's no good reason to use such long lines. ie do this instead: if (!current_is_kswapd() && gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE && get_pageblock_migratetype(page) == MIGRATE_CMA) return true; if you prefer, this style of indent is also acceptable: if (!current_is_kswapd() && gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE && get_pageblock_migratetype(page) == MIGRATE_CMA) return true; > @@ -2225,10 +2242,12 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > unsigned long nr_skipped[MAX_NR_ZONES] = { 0, }; > unsigned long skipped = 0; > unsigned long scan, total_scan, nr_pages; > + struct page *page; No, don't do this. > LIST_HEAD(folios_skipped); > > total_scan = 0; > scan = 0; > + Don't add this completely unrelated whitespace change either. > while (scan < nr_to_scan && !list_empty(src)) { > struct list_head *move_to = src; > struct folio *folio; > @@ -2239,12 +2258,14 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > nr_pages = folio_nr_pages(folio); > total_scan += nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx) { > + page = &folio->page; > + > + if (folio_zonenum(folio) > sc->reclaim_idx > + || skip_cma(page, sc)) { Again, this is not where the || goes. And skip_cma() should take a folio, not a page. It's unreasonable to ask you to convert get_pageblock_migratetype(), get_pfnblock_flags_mask(), __get_pfnblock_flags_mask(), etc to use a folio (... although someone looking for a project could do that ...). Instead, you should do the folio->page conversion inside skip_cma(). > nr_skipped[folio_zonenum(folio)] += nr_pages; > move_to = &folios_skipped; > goto move; > } > - No unnecessary whitespace changes.