From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49380C77B73 for ; Sun, 21 May 2023 22:04:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82A4B900004; Sun, 21 May 2023 18:04:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DA5C900003; Sun, 21 May 2023 18:04:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A1B0900004; Sun, 21 May 2023 18:04:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 585B5900003 for ; Sun, 21 May 2023 18:04:49 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 19C591C6F0E for ; Sun, 21 May 2023 22:04:49 +0000 (UTC) X-FDA: 80815642698.14.BDC4697 Received: from out-30.mta1.migadu.com (out-30.mta1.migadu.com [95.215.58.30]) by imf14.hostedemail.com (Postfix) with ESMTP id 177B510000D for ; Sun, 21 May 2023 22:04:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pNlBxYp8; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.30 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684706687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M7SZ4icPM/G1fu0ULdKEsJem1DjVdc2mchXSlwG+/Tc=; b=ZFfmapC/7qfi7D30K6vGorYWCti8Daz+1UhSEzfASe/XpQg8tc/C0YAP2iEDUadxeBQBTF +qjhQvfRz/hJPJydeIt3NR2lnIbOHiUbDXZM2/oMH1fdHFCXJD1zLE2yP6m0ILk9u9lCvo aUghHf8jt2tOk6AYIsPQcfOc1XhDSj4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pNlBxYp8; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.30 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684706687; a=rsa-sha256; cv=none; b=tDe6YmdorUTmtLcruDh+Xmn4p9AtaoEnX8eOQbfmWyfLRTxaGEFJlNMY1YJi7lAs5dHqF+ MvQN3a2EgbgKPzT/Iq+BYOg2AvPZDxpKfYIY75vy1BiOD5S3bfzDmx2VjAAxeuJXhi7bBD hFIxHAIMc/EOAT9QnkmAQFCMx4qiSF4= Date: Sun, 21 May 2023 18:04:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684706684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M7SZ4icPM/G1fu0ULdKEsJem1DjVdc2mchXSlwG+/Tc=; b=pNlBxYp89TaGuI/Pja+cAFNusJ6CcLCYMLeXkpWHfk8wp2qS4mvN3aemgC6BSn2VE2PhUE 4c7qqnVrgpCoGa7/WcHruX+2OboTSsJTjjG+89QTN7Pdm4pbm7qZXRNQvDq/XquaOAJOms epiuAFYuYMDP+Y5scpiuH3SIv0k3qhk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Eric Biggers Cc: Lorenzo Stoakes , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Kent Overstreet , Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Message-ID: References: <20230513015752.GC3033@quark.localdomain> <20230514184325.GB9528@sol.localdomain> <20230515061346.GB15871@sol.localdomain> <20230515071343.GD15871@sol.localdomain> <20230521213334.GA32557@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230521213334.GA32557@sol.localdomain> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 177B510000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: exygm5asrbzf5biaffen77y8cmnpwxcy X-HE-Tag: 1684706686-354395 X-HE-Meta: U2FsdGVkX1/DO0CI71FQ+yj8T7MQGsJqJUQGBFfF8kk9rTmrKNyHI/RbxsLy+Cn/IKSRNajd15PiI59DAf9wiyB5S/p+BGnZrKCd3xZ5Zohh/APAjDtbBebteDOwXdU/+BPZ/JLoBVauD0843Vduydo6XBhYkdZv0RFKr5fxGAQT//EfZeXvF76s6G9cdJpkYWj3TgvdsRsrupbFd5pEiFjWz86HbtDKvvzjqJbeghPLFgrjPif2eZtQaCdTuMDgafrsRo4dyS++hzmafYQyy9kyiYjlyu2GFsm4Gw2fgDu+UG7PhLWyT8W1b/7E6ZVSJWZ2HUwP/f2apemJJVhHKxlRMQ7teWEO/D4Yi9RcFgkZN/GgG7JKtMPMCLpxawUv26qwV5gK7FbPqKLyFvOqu4IMe+cUJ3fLEA9pyfksNUqx1DY939AEEOuTK+2PJtzlwi3bHMWTpvYFEjrFkFU/GNofSQXPnaTVWuLD7S3BWW16H9n6Ts9d0jEfVglTwkOO+RwzVWMJhYg2MFnvC/hDAPk7P4NGgAEBLCXGJVmjL3lZyQijmTQp7Ui1h8aKXXJyuZ76ShQuf5DMPS8T/1IFcLWJun/4AGtWjiwVNpsjzndzXmmVL+sHhUGh7YNdDSLUGWLlMO4joHyd+RXE71pwrYNbgnO9N5Z9Wp6VtvkvbBH6hw5eJq74l71yv1KUgVdi6zRLbnCO6gCVlfBt6tXAj+W8JeQPkZAION037OD1q6mZ0CEZVZhVc2ZHxKD/UgbhwHiuVIAb7oArSR/wcBNFIS/miSvf2vtzXH90jMVTF3vq5B5uXNpR3u2KhoPBB5ibMax3I9LLv/UatEieyr0AqpASVx2Lf8ALJjqZ4wQAgneZy4wwZFDrWUxANd3BJfEmCHPv/MkpxvjGR/tvJ11RUyqNFZGEuVyogT8CPRyEqIRPXAurdw1fY88qTnihnPyr5gNHDslULBRH6cwT/1X oD0zqlYz 0cYPS4r2cTpyGHJJ8dXv69KILmzw6hYAnT292RCSa1+78kAzJMrMiVr+MSuJPtyexWwVtmOpYEBhqmTZ50czRCwBSLiX377M59LAiK0J1pLbXNWu4t6K/BahaooJZXi68jc1aoSc5HqHuKHnFOMcDzkx03i3n9lYtIv2d5yiVCYIZs0o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 21, 2023 at 02:33:34PM -0700, Eric Biggers wrote: > FYI, I had a go with your test framework today, but I ran into too many problems > to really bother with it. In case you want to improve it, these are the > problems I ran into (so far). The command I was trying to run, after having run > './root_image create' as root as the README says to do, was > 'build-test-kernel run -I ~/src/ktest/tests/bcachefs/perf.ktest': Thanks for giving it a shot... > - Error due to ~/src/ktest/tests/bcachefs/bcachefs-tools not existing. Worked > around by cloning the bcachefs-tools repo to this location. (Note, it's not a > git submodule, so updating the git submodules didn't help.) a require-git line was missing, fixed that... > - Error due to "Root image not found". Worked around by recursively chown'ing > /var/lib/ktest from root to my user. (Note, the README says to run > 'root_image create' as root, which results in root ownership.) Not sure about this one - root ownership is supposed to be fine because qemu opens the root image read only, we use qemu's block device in-memory snapshot mode. Was it just not readable by your user? > - Error due to "cannot set up guest memory 'pc.ram': Cannot allocate memory". > Worked around by editing tests/bcachefs/perf.ktest to change config-mem from > 32G to 16G. (I have 32G memory total on this computer.) I think 32G is excessive for the tests that actually need to be in this file, dropping that back to 16G. > - Error due to "failed to open /dev/vfio/10: No such file or directory". > Enabling CONFIG_VFIO and CONFIG_VFIO_PCI in my host kernel didn't help. It > seems the test is hardcoded to expect PCI passthrough to be set up with a > specific device. I'd have expected it to just set up a standard virtual disk. Some of the tests in that file do need a fast device, but the tests we're interested in do not - I'll split that up. I just pushed fixes for everything except the root_image issue if you want to give it another go. Cheers, Kent