From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC6FC77B7D for ; Sat, 20 May 2023 10:34:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA8D1900004; Sat, 20 May 2023 06:34:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C593B900003; Sat, 20 May 2023 06:34:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6ECA900004; Sat, 20 May 2023 06:34:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A8746900003 for ; Sat, 20 May 2023 06:34:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 509F5C0B79 for ; Sat, 20 May 2023 10:34:42 +0000 (UTC) X-FDA: 80810274804.25.BBF7EC6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 5EBA4140018 for ; Sat, 20 May 2023 10:34:40 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf26.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684578880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Z25fjdJFNtyG4uIihNVFa7OieFrZD+prPK263A6/bA=; b=bYkRedbIji7F0DJT4CtN49Zkd9fc4HyuVDesVrD/VXMkVTSdRDDg0aciWUSbOWWkPclWiu 8ue/ZHZOL3LKFNAiYnoPKcc4UPQK7QLwfAyRDCZ0wsI9Uk/m8oyXP5I/MOlqKaBmsyW0Q/ v5U6S6rNlNITcpbGy/t14yYRBUuhZBo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf26.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684578880; a=rsa-sha256; cv=none; b=gazlhjgwGsYtpij7gVUv7a4QObZGTNf91wSAIwrGIbs87LqMqHQUr3B0K/i1R1lPhtwIx/ gHpUdFvM/9ws4qrjFDiehR9lDEI2Zblnp66wEqCPTf5JnoLZugS/e/av70BNh6LagoRrq+ 8kexdsj/eGHFLhtjGvJ8NtlPcHRE33M= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 50CAB60AE4; Sat, 20 May 2023 10:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58CCAC433EF; Sat, 20 May 2023 10:34:35 +0000 (UTC) Date: Sat, 20 May 2023 11:34:32 +0100 From: Catalin Marinas To: Christoph Hellwig Cc: Linus Torvalds , Arnd Bergmann , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Isaac Manjarres , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Robin Murphy , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 02/15] dma: Allow dma_get_cache_alignment() to return the smaller cache_line_size() Message-ID: References: <20230518173403.1150549-1-catalin.marinas@arm.com> <20230518173403.1150549-3-catalin.marinas@arm.com> <20230520054209.GA319@lst.de> <20230520061441.GA1100@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520061441.GA1100@lst.de> X-Rspam-User: X-Stat-Signature: zx9tcdcbpp56jodp51xifuz7zrjpqk3r X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5EBA4140018 X-HE-Tag: 1684578880-801388 X-HE-Meta: U2FsdGVkX1/6HacbkNxrEdoVfkSkox5NrWA3IPGW1GGv5cnlzmXUUo17yX0p1qhLRkrlX4sPZChfw7Z0gdw+oAzJSjFKFIr7qe5amsL+QlAVzRLwKw3o0Z9l4ewWwhRBhrYkla3Tscb72y15p3w9tR6Y1qeHU0vFXxfCjnepgb+KrQ2ocE9DGk0O6qScRCMtqBcuzVr/AXdtFowlA51JsWIE83Mughdl1EDr/D7ARenNGnk95S+jkHdhPuIhpL6D4h9H4bgcPQIZy+SfCUPIjAZSaU122ZdDyK35H2ZP8vebrHkEk3LXqCBmYM4AW+9p8vruuMW//WN3DKq8c/UZt7PAAHuPUCJU8DaZJehMl0xK5ioLx8VWDPY7wg7WBPiTOHrWnAbgUDV6wqvOmUFN3G4p2i7NrY7ty7GIeEcrdULSgP/waNun48IVlntfb9A/1Eenaki1msnWhHyMpwjKDXTAFheIySCfuu57tXSyeM8+Mxeh9z4FSfsIr+lz3zBLTA7EfoKiLLiqh7xhNXhJuq8HgnNFkUO47QC32MUmbf0OJRVS4/aQtvFKc4XJd822wiW6f/Xei78pKMkrwIUVgH6g20vc7Hquws307fTzlN6P52K/XvfhTNXYqZHfjFu+LlueykzqIIfTgRHMBg3K0mfSQgqcsl3SmE5v2fFapGG4E6kXmDzW4EvqgmaWlxepiCw0KPop5hMFhEMS2KUdqyUo0uIx7vK/rElsbbYsO3zJ2wq6OnnEr8zCcn7NLiOkaqNGstoOAWLFDr3zdVSWDVSE1vG2q31IPbtCcTi1CfnoJ4X7kxqeXw3c+9rubAVVl1pP/U2VyA9KIQD+m/qdtlbNxSK8YRSGKWft3HQvsI6AJYxMVqo2FGil+NmFjq5d+7FVTMpa2r0qG8UjDiYu/oBOqMtKlXBda5PMfY/GwYfnRrkesOzanRta/4invBueu7muw20P1N07tFSOCdq 0HoL0SdY xPfQRhWWMe74LeL0T0xM+NKIO0BVgsonV8IU6ZVjup/H+zdpTOdefWPJSCzZAnJYxtdQT9oNspxcRsl1ZShyU/Qm5PvWYCuy2xVv3rBoMPjIiUfU+Taza1p0SKGPIbKJGYRwAzaoqAxe7emc/JGikidOp5Ou7bYldsaAv2EcbqUrek5UDEDOW3JyZMT5HJfmQZChum8d39J1UT75fVyngUK5zHRJMf8sOTlRqQ5Hc60veYBbzca5uMSbFlAt82pbenLlBabTWP3DOMGjzs67j6hb8lu4tXF+rvUC0w2vAFTGv+laml7rsj/IvufNziQv9aAI0QskuR6tE02sL+It9WtbmgDhHl4cqwM655OetL0fEcavxA1jpNlAsC4FYD9yQ5D2tMiH7Ilb0iD5l7UZpROyX58UL/iYI8hkgBMUjpMxCBAujWuFVi51U7e4XUQiafGRnvsCgJrgZNyZ4iI5SrTXy0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 08:14:41AM +0200, Christoph Hellwig wrote: > On Sat, May 20, 2023 at 07:42:09AM +0200, Christoph Hellwig wrote: > > yet another abstraction? That might also be able to repace > > ARCH_DMA_MINALIGN in follow on cleanup. > > Looking at the rest of the series, this part is obviously not going to > work.. ARCH_DMA_MINALIGN needs to remain a constant (taking over from the original ARCH_KMALLOC_MINALIGN). But the dma_get_cache_alignment() can indeed be overridden by the arch code, it's a good idea. -- Catalin