From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0899EC7EE26 for ; Sat, 20 May 2023 05:53:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F77A900004; Sat, 20 May 2023 01:53:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68022900003; Sat, 20 May 2023 01:53:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FA49900004; Sat, 20 May 2023 01:53:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3C50A900003 for ; Sat, 20 May 2023 01:53:01 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0A44E1C7AB9 for ; Sat, 20 May 2023 05:53:01 +0000 (UTC) X-FDA: 80809564962.17.39090CE Received: from out-14.mta0.migadu.com (out-14.mta0.migadu.com [91.218.175.14]) by imf30.hostedemail.com (Postfix) with ESMTP id 00C388000D for ; Sat, 20 May 2023 05:52:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DUhavany; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.14 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684561978; a=rsa-sha256; cv=none; b=mnp7ExJ8HuzmHNltR8+lv91Rs+dpUpS5xo4oL7wJ2YC6wgFk2GsGA+3AAYEVlRqgDNfIpU 6fgOTHYkUG6u7mNiyG1z1uyINU59YrAUEucHvHol7labXxvF2JoRXO83L8v+RwCP7dzG8d /dgOkSfqST4qLm2UJLLPx1+u6+3i6Bo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DUhavany; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.14 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684561978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gfOMCDO+EpRcce+Y4fCgA+EpfItFwpyan/mWDxkdEYM=; b=sMAWmLiVhU4dfyvbaMECjYIGkNsyZKbtbXCoH2tWMXiNTyljSy3gAjRlf1Kw7F/uS0GeIw EMM6PUusr54NW6UhZknRQam2erZcfbOD70WMdplrFjsyXCnw9GtQSn8DmeyqmWcIgN7Jmc 8fScDgSbgzQbqljYO5pd158V+YL+4gc= Date: Sat, 20 May 2023 01:52:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684561975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gfOMCDO+EpRcce+Y4fCgA+EpfItFwpyan/mWDxkdEYM=; b=DUhavanyxeEQh7S9NTewgrT1L3zfybzlnHNbBSEOS/ABVyFaKwC1oOAF/twoAVoC+F0NCp ysKIs8YCQ2e00ythSeGADQjy9yl5qShN8KW5uS3tuX3hMMu0TPXaSeeoTNl16xOW2lliSd sl7iTb7QuUAiRxL3URwO7jI8rl0SHZE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: David Howells , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic Message-ID: References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-30-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 00C388000D X-Stat-Signature: bnpsettp3f1t8g9xo5gcpxpab1i61gne X-HE-Tag: 1684561977-356853 X-HE-Meta: U2FsdGVkX1/jzm9SoQ1J0xz0RIXLMpPYvQLjj//IDJouCDMDNa7PKPnFujVZVSYZlqzHhqbM/FQm2KDPrGCgd6MC+7qRm8o4gWGlosWPoo6xt6+qajGA5N5nbKSbxn9zeS9airI0dKF+j8svowfBjmd4cGNvOxyxn8bUpgSUjZM8mA1wVmGTAHD0HsEw7XHqrJFhqlfnQcnZ8t5a3TDogqZCsuHYa2t3wtPyx6gC/UUH3Q7jyxDgWbt69FgP5/HsBC9sddN3Xo9UzCE0fUdnNUkajDztdHAmFN3lukYlTj9IJ0sH1wkuxUPcb0HbKpc0XLq9XESyMZ/ff4athJqrsBfy9FJC0R1meI3kYtbPitMsN6AVo3bsL/O3zzv1kqXuc6K/wc4TT/87+oWfdlwJ6QxWpDMX+2AwQDffpbVPoD8wG8/X1sGFQaxlZm0brbJyorROxmJYK8fpedx5MkUABZiunRRt5GcvIwsC5zOBH7coIRgt4/AOuHzXWuteBguvRHxF/ahXiue7Z2diRDHNigG045mRKnQJy8fBXstojx0gYfZzh0NfpWcMk9HlaO+hUuyXKAgs1MQJvPDixN0XvKGel3jBodEnE33yQ9lqdNWHDk/tLlqycmFQ8lK4DJ6Pz9rThFByPu195jVhHw5PO3uEllHfAwnalKIpB1tSbvpFcKpHn+FExXfAlG+wfS5LwxcaDdR7MczOLZepfHvAfwYI0qMfsQESpjocg90z8HXy567BOxllhEgWvgWp5neYJsmATA5bg4b+xtx5/+T/jw7rSGB92bLn8uU6s6AcU/L5xjXaX4LzexgqRp7GKZTa+bT6ukLhT3v/v+axgRKbVhMh4dgbvYgy9mruDilEPc1/NGFF0RyiWNJMxPXvlXv0Yjvb25XnadEIdI4IC18XKV4iBiPS1+0RK07KpiG9OQ1HtBs5ICgeO4CGT69OBmhT7rI1xuk8oSJsAtrBsyM sp5SfYND qIUm+gBJhJVKiOEkFQbl1W9PuOwkwYUuqm7VQ7DhoI+c5iUlzoacJt+TzI2tNjd894WhTYghDXN8gnsXUZ0QsbWgJldtMgKgpy/mh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 09:17:43PM -0700, Christoph Hellwig wrote: > On Sat, May 20, 2023 at 12:13:49AM -0400, Kent Overstreet wrote: > > I suppose this way setting it can be done in bio_iov_iter_get_pages() - > > ok yeah, that makes sense. > > > > But it seems like it should be set in bio_iov_iter_get_pages() though, > > and I'm not seeing that? > > It is set in bio_iov_iter_get_pages in this patch. The later gets > replaced with the pinned flag when we bio_iov_iter_get_pages is > changed to pin pages instead. Whoops, missed it. Reviewed-by: Kent Overstreet