From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34C2C77B7A for ; Sat, 20 May 2023 05:04:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EB66900004; Sat, 20 May 2023 01:04:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29B22900003; Sat, 20 May 2023 01:04:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 162D5900004; Sat, 20 May 2023 01:04:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 06E34900003 for ; Sat, 20 May 2023 01:04:47 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C35951C799E for ; Sat, 20 May 2023 05:04:46 +0000 (UTC) X-FDA: 80809443372.24.225EB46 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id D590240008 for ; Sat, 20 May 2023 05:04:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=s7UP4Sx7; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684559084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kyno7uaGol+0Au+jeyK6ifVXccyu7nII+Bbwm/hovJU=; b=M9kMk+Ue0mAjDK9GiHOGC1A6Ubzm9n/uteMWZet9r7027edpyG9sGOKCMFQm8gMXFZRrY0 EDREKt97xeGQFLomDatfnDdcXjzk2ZnPB654+HGib7H6tV3crGci4ApPzE6BcuxsURbT8X g2PRgfG8gu+tLVe/IfC/e6joxqLRzyU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=s7UP4Sx7; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684559084; a=rsa-sha256; cv=none; b=gB21woFDmLCpaABtnSB9U2F52xsrBrPmMxXlu2oVACw/y5kw1gvf5AIbzKWQy+/sG2HQtw itoHFw61XbV2Av2tJO8Yt25mloBao/mXmsZnoHH2nJmahkrbcXNfZHhUnCJisUfB+Vkwhb Ehi3pbcYeE9njJXmwMyZhy/ILTIGj2k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kyno7uaGol+0Au+jeyK6ifVXccyu7nII+Bbwm/hovJU=; b=s7UP4Sx7JFz6PF8XhGe3p/f0aQ 2HHxn/9xS3MpXXSgWN2Aw8vUybKc87OsnzpwHYyHpCwiFaKdvrs1h8u8c0yJJ0hxloX9XVBrDfbZ9 L7y6hSznUFJK8I7ZAx4x3tmnrDwrx9ElsRHn5Cya5odTKRqHa6nRBvQnpbMkbN3VV01mh5LZN2P0W pONzrYAHEDCUtLpUxD9d9fJMiRJOZtXAcLcPEzoPaxnX7iHb9uj25vOoxaX9I0tzjUPBeLEO8Nvh8 ORXsXdIsyjvCkOZkvKcpcS95zsw7CvW2pKYujFxNKsFZK0OssXoFItZouzDjTYMbnGVFPKnT01ynT HqtudESw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Elh-000jwN-0t; Sat, 20 May 2023 05:04:37 +0000 Date: Fri, 19 May 2023 22:04:37 -0700 From: Christoph Hellwig To: Baoquan He Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-15-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D590240008 X-Stat-Signature: dzcmyy5u99j8gtooq4im3w6dtbj7b6p8 X-Rspam-User: X-HE-Tag: 1684559083-221699 X-HE-Meta: U2FsdGVkX18YC0RX2LwASU+8wjkl4vYlm+wnRWUlPoCPoScgzSrF8gdyXeYbFBxjCzNBNmQqqaJDk3R1KNeCWUGCWuASrlQEIbfnoeRZe306gaL+SrqgF8jp0ozn2elLPbiMkCSCGVV5Hd0fBWpybYqHpuPv96pbl21yHTjCj8zvMggNHhUTX2JP4lY8Iwu8EsaJobnGFTjejiootJ8CwYMPZWJ0kNAbUFxjBWwhaupdo1tNDsEJee7esJ5npwFCc0j7bvtDM0OvlGEvVNEQ+vY46MaleL62ayOjGBzwpghC+hqKdJe6jmXkBWiVhUFSjNMEAGFrOtPXvxXxBJfspO/XGkXzFpINkibwIt7owjl8MP8SJAExuYGV3QY85Rr7baKD+tvJPOCV3rc2DT1+9v2HdPQVMHAmt0g1UA+9vFGb6gSIHyISXD1b6d+9KuHylvP7PP29fDJ1YHIzNwVlViDmT+fVXDFbMUMSk8jIS1dLwvTNpOoZjjcaBJXNR0RXMnq40ckA6jQE6WOf8c5schg4cgrsitP8LOpCDbVfu5BKchMWbzG08DTA2zU2ne9C8rGKsbvt3EMX+QrZ9a2nV8EfilqvK0oUSfUJ0ZglpNbQoDUqjSKsjreuHE+HrHgbjJ96mx3M5cqGUchQpV6gz7aAntNhN/GiVxVhqqT9Q/6v36zF+zi/Bpd92WknphfVDvIoZ/tCQmPTGCh4cWyJoBRVpUFnzMnfMAkLINNGmsa5oRcDiAzUTXZwwAQju5W681rrPMAt5H+eh0mlb5TvA9GlcTyIXMqo4pKOTTA4jr4wUPMBnzIU1rFLCHPt4qzkcnqoBOYADYa44jGNBSKyITMLKVOovYMJqOFbfWAbAHgXj06uEbu+ys7U9jyRrGcRmFD43EfL3C2CiyNNR+1zG2oICK2oy2tUxt4646cJxa+XY2W1Bw2gq1A0GFzK+pIIFZv19zRxyXk1OjtgKm5 M7kDU7p8 NZbd7ShiSw1/OOePx3wnJx6KIvvbyPZGUGNKKNWP0ecqLEoXfQ7RN3xxcmo3lJ7lnswg8AmBWGIuagSv29Yxwn14bXq6VrDMFpittbmJCnU2G8VJhm7ADK69w8/16YHNoc9mH/q/zqeudSQszW38B6/bw+xQKcq4xyidNjxFe1LJKTOjhxm7kPoyOSFh7yXO4cbGsgwgBbGz12XiT4N1BK58QCWc4OKxJT23rhQne4SV0YgsKvbzg0veFRSgb2EmUvX7R+yBKBnIxDIDFrm67IF7qrmLYj9ucGxJDUSRJLVZampqYABIik4UTDSuawNf4eACrACz3IbKt2udjB2u+gf4m4pfcImcz6otUTlyv/dgGH9dshdcdFbczq4cWzGGkL6VBK0twNYzLyyQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 11:31:04AM +0800, Baoquan He wrote: > > > Together with a little comment that ioremap often, but not always > > > uses the generic vmalloc area. > > > > .. and with that we can also simply is_ioremap_addr by moving it > > to ioremap.c and making it always operate on the IOREMAP constants. > > Great idea too, will do. Put this into a separate patch? Yes.