From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48557C77B7D for ; Sat, 20 May 2023 04:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8559280002; Sat, 20 May 2023 00:14:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D645B280001; Sat, 20 May 2023 00:14:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4C2D280002; Sat, 20 May 2023 00:14:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B4DE4280001 for ; Sat, 20 May 2023 00:14:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8E9671204B1 for ; Sat, 20 May 2023 04:14:32 +0000 (UTC) X-FDA: 80809316784.28.BF8174A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 02DB8140005 for ; Sat, 20 May 2023 04:14:30 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HCNO0Qev; spf=none (imf09.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684556071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=2Ci+GfuNnjAJJotWm1KjbHOP95xCyognCbrwNiWqE0QtX50aVBVZErElZ1cwW0vr6koOG+ 47RgU899896c25iDL1gSlhwK1ztCcP5ftgoUHzaStA7XekH26u+RTPrNW1KNui1CEDHYNI 7VGQTswU9PCNbFL/U+BsZhNgqrFqEQU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HCNO0Qev; spf=none (imf09.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684556071; a=rsa-sha256; cv=none; b=m0p3IP8dz956VfISO76aE4451Ku+MKypDgbqzX4CV9tFQza/Zv7cXmq9P9JSzUTCTqIX6s UXIm9pzyiC4DVBfjm0BtdtBY7iTXsr/sgCwLmV2KH2RWvNMFSdR0MNzqUYbDoCPlzDg3Ju 6Y9zlkO/14MQ1uY5Ym1brK/z2844iDE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=HCNO0Qev4nVL+W9xKFrU4PibZb IcaAcK9i9X4vJjRSUQ721fUyShcqGf+4BuaBVkY5JuWCF5xnPZNuGczkpCnOyC3u/oNhZj3YVqihg eAHwTAfmv3861SCg9vJn6BjMd8h4NXrTtSxyGRZOwzNY1aoJ01g1NUXB8FkruyISSh6OPDKCkwSl9 Bl89cZXaP8E+hp0wTvO1TOrjQLC2yj3CR7Nweq8d4e1dVq1nqQ0HEnlnqzLg4vCJqpoZIU4ALduBh ok7WQmNhl7xMvJzCYh4fD/98rF18aWxW8RT0Lr0OKpZFT7Tpyotjv/+NrqHF1sBI6NI6BgnTXZWih XvZYcHnw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Dz3-000dqF-3C; Sat, 20 May 2023 04:14:21 +0000 Date: Fri, 19 May 2023 21:14:21 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v21 28/30] splice: Use filemap_splice_read() instead of generic_file_splice_read() Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-29-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-29-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 02DB8140005 X-Rspam-User: X-Stat-Signature: gcby1b3yd8fs6ejwekrdr6k4xg6onhw8 X-Rspamd-Server: rspam01 X-HE-Tag: 1684556070-174194 X-HE-Meta: U2FsdGVkX1+3LuvsMLZxtcxfvsYl0NOTsTUZlZyWW12E9ryjR9X3kEnKblg2q5xY6zN2oBO/0Dg4BalgEha26gOeBofpMZdLlc7sxveFIWms3jrmxKA5RR8ORlwehdcsQ3cio0c2b0JfHIMNOvb1FT7HpugANYNrJbnX0ooqIdBfUAkpLMaLrZae+J9maSxM3IuhAFI2MRg/izxC7vCo0YoeZG016vBuDD5SsZUHxUgzL9MLJzrKgQ8cl1ertPZzTu8/WcUE4FAEtDmzZm1EsFuYOzzhlD9/MaUDj5oUMzGN1bPXq27Jxza59Keaww2tEcI971wezcr7Sppkugdnsv61PAc2dK3HK2aDKnw29PVvZORuRlbA4LYlvlRNT+9I/1Xtvo8eU21AxR1KMicYKKxTlULcOxdSR+RiZxcOXKc/8iWeryeNrRVAFVl3+ZvxBcBdzFyblNR1VLo1T4YsrqEvojG25TxinjJcC6YyVw87j0f3rb29+w7Iyr68U9+ig+ZpeVjR9kR8VVz4vIchLYlHFpGN3h1GUe2UEil8e26AhYW6F6vkRwh3IvivKaIF6X1mF1EhMMY8gsm3PcnlIZ9RI7QohP92PC6yQoD9Fh/kuAnfCOL+eZ+/ahNK8lJMLADC2K7fr7V7+MJ6klBy3ml77MFqboZMGezW2FM/xA7gL0x0XOoXjGy2sOAlYT5xPboQ7NjOlX4xkqH9hofHrXwovvJf1IOj18gDeaf/k2CVyzkCzaZpDYdkIELmWo9huZoMvltwWPYBEWsrnX5t4Eicpjlmudj8sxm7NQg6FDMPQr40W4PlJbysRCTyO3K0fx7aEHMbZVbpDMireGfNEjCkUVUzEM6SmIK9akKzn4k3TPN8/Obre5TqTADO1HBai+DqiSlhZ5jKL8GiFAucHOMkrvzM6dD+D0zWUQkeVAS42pAnZAt2oud3png8XGJY8hSoIxk5JzUvCaMUI9Z dE6mIGU1 Hjum5MDb7fPzffC+y4ymeFTvHZUQ16Ol1kWyosyQoNv4Z8ed3gkko+rmY16Uc1xRGp0Tqvy2zfF0DE9ux4vk683YGi7Bm5CJ2p+Pk7KxqP+qEm0UPoc/+5p7CAPP3bS79GDv/n3vW0rBW425q150/tE1HUTBD4GwL2RXhiFh4kmNhHz3OjzIKSg9TzxPM3TXpdRBNMz3tcvurrGLnIwx1KFVkp9Z5EA/xpNFXvEIjcq8dRTLDRdv12S76nzX0rgPynJIN7WPQDB5y0SovOGa51EH3kEh6PvruzlGMxSl9xHSeqZILk3XEbGyLxp+P4gFyzTgS96CYc9QGkByV+5UJ5+i0UMSMDDu7rXxOtZ24j2ngwcpyByxxW+edv6oASg1SOA7sbHhddCWK4KveasdpwwO6BsONz6vUPF8QXLyTC/Gwg4LMHYkCg9RELIOl74dFETDrEprsQTEU5mtu+mMdf5ahrXszSO2SK6Z/fiXY8YXZP/7ppmfluFLQOGEf5ZeYSNvzS8EqKTtxT3vhGt5uip7WV9MUip/6mQtL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Looks good: Reviewed-by: Christoph Hellwig