From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65562C7EE29 for ; Sat, 20 May 2023 04:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE2D8900004; Sat, 20 May 2023 00:17:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6C86900003; Sat, 20 May 2023 00:17:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0CAB900004; Sat, 20 May 2023 00:17:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B3C98900003 for ; Sat, 20 May 2023 00:17:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 842CA1605BC for ; Sat, 20 May 2023 04:17:57 +0000 (UTC) X-FDA: 80809325394.03.1C1448B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id DA7B5C0004 for ; Sat, 20 May 2023 04:17:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sTcrSxZY; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684556275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dsyjoGECg28DSVqb1cNtIsHN/IJsbEQcxsUvVj7A8EI=; b=YQwkHgrtQOW2W1x03wfq+6CNE8L1m43++qVlJITwcCle8scaZC8lb07iXButdZmdEVNF0I Ajy2XumX67RUg+bkVj4gRjSSHXJJuuAxhxDjskN9ruVIqNIL+PuJR6S1Ya6FfZNW1xeCoR ZxKJcP1ILDlKNlWntVTx1PTwjrX+ysc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sTcrSxZY; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684556275; a=rsa-sha256; cv=none; b=wOFDnpMXPD5Ls7BFjponB6FWkGecYglxr67DKNMQU5fwbOEQF+ew6AtRD1Z/dCAKfC4kZ4 gfoBTonaV0SSIz122wl8S5q5KzANqAwSSnYLqeKD1CEAKsBGFdA/AUjaIDqUnUHjp349YU z/+D+nYFdc212c+LTfKDu4f5+vy2GE0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dsyjoGECg28DSVqb1cNtIsHN/IJsbEQcxsUvVj7A8EI=; b=sTcrSxZYlWK3Y/NgXpynqtVLXh to0rnGVN3Ln9J04YoqNw98DR3Tn94U/XUFBGGljJJWBjZa7LH01Od/86j9HV1/invC+x8vDdBfFFA YK5J7T1yqfrNknelINVye+ufub827/voITPOwyWzW/TBWVvd07oAOGDAF/lN/HsDtXLG7X+IrLl5F wlSFXNRgGK+J/QqmJrneHhpTNcjpYwu10v8FcpSCpXsNJWBsmMvTY8uSruqCOmWvBvdw+ErOE49EE YGgjAvPwkmFY47vKY1fJXW59JBCso09XnoXAywA6A6WHwU/gunckEHFpFAG4uxa//Ao0KChJiRRK0 XdGrXhyw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0E2K-000eBj-04; Sat, 20 May 2023 04:17:44 +0000 Date: Fri, 19 May 2023 21:17:43 -0700 From: Christoph Hellwig To: Kent Overstreet Cc: Christoph Hellwig , David Howells , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic Message-ID: References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-30-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DA7B5C0004 X-Stat-Signature: 4c8axy77zw7rmappsnrbntf69fxtw7yj X-HE-Tag: 1684556275-16547 X-HE-Meta: U2FsdGVkX19Rx5fWKv1/n4s7aMcN9kMOzivrMiMSUFZOGRe3ipZWhzeHwA1RKVxyArZ9j6Gp4DM/2hR10c39oHp1k86WKAoSSpHCNVO+5erLyN3eDmTBg2c10LX128JV6U3q3/yvN8rt1+F8VAb1FvSEsaTKDSfOEZ2w/67SFqM/aaory4Onxc1KRK4A7/BGy2cTYCdnZJpXLyoS4x1Zdw9ycWnlO3oNn3V7oBvczQkh/EF/oLAPdcOY8uI4PB8RFeG2yz5XhMk9GTe3QcYWJxoZGtBX88wDou9MYrn58CpO1YffFhBJe7+y9MpjAbpCj27TsByCpb/bmGQRphzYqleOPGlqvfy7LUc4uULSEqGr8kRJTfws14K6HiAFh9I/XgMh4unErhUo5sbiS7DfpCPkOIzSFjo51XuPbfGqgXuuDBWk9UFwbKX2mwGWmCLKAJlF3UuivarmZ/upROuSO1yBaQNvZeqC3Ms+KmpsVb7Gj1pBqyDDdzllnzByltCYPDiGNQCnMYAj1kHbPxbsot9vVXQPWatSkhXfd4M6jTfYtQ+9khaKlP/0QuSvOtUTJidlT+41GIeS+gtl4MrAzdOTzfErQj/Lj5aGmi5Xs3D08MHMa3FWUMgIk4NZOhBS6NwJ0S8rvHROAu9ALJYooBCwqPniyXeTJZDIMxL2Sfmj52/xnsmdj0cNlqop8r0Aj7Lpb0aBVb6MOzAFzBrJznXWI6roR2ewKeQn7xQn+8UEeQd8a0RYLewcMPeciFLb23rZArHfP82tIWyPGYeqgtH1C5lFOXw8nh5TeIGaEjWuNg9Xru8Srbtf3D4+2lPhfS17y+HgPVmf/yKO+jv0zcZ3f3h4X1OkNhZ9kyj/WIxg8IQqw+aO+KTqOKZV+SuaDftnICsAT5KB4e5Ymq2PxbWbdzB1sZ88JysnE00MJrBLoBc8i6Zwz2MYeMLKO+CLOeSRr4+TmsOElTbP+TS JXBurngY 0riR6YPt4IyVIwQYu8/eZ5TrcCUKMp/UK3R2dsX//zLPAu5vTQt2hcBI66umiQ3r4Paydc7v6Y/ecfClcRdOeEIwEjQ0iFBTifWb/pUcytpKOD/ZzHTtUOv0yq0b9enOjcLNFUr8RvHQQztSn3esgReBtH1od04AEbjW3Y/iYFvU7cUYodfi/HRF6Lc6cPuT7iRkQnHNXpzHC8nD9idYb0jRL0oBwQZCSWg9OEn0UtAcWKn1lWHXOyM9OIYcsvb9FmLEUL+tDqiZ2U3rUunaDdBcacGIE+e75sTHbEXz8f24XxwrT+xmLF1X1ofYDBqnDn+VfPfovSzln5b6YBrzpWU7Vw8rtHPdZf0DkPVIoIbdIg6ZvG/6G9vcoq7EtAq1oorwKPTbHIFP9n3V4bkLvX6uA87mg48XMzi5H4HgIx2Yei7SEKCTg8ORkww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 12:13:49AM -0400, Kent Overstreet wrote: > I suppose this way setting it can be done in bio_iov_iter_get_pages() - > ok yeah, that makes sense. > > But it seems like it should be set in bio_iov_iter_get_pages() though, > and I'm not seeing that? It is set in bio_iov_iter_get_pages in this patch. The later gets replaced with the pinned flag when we bio_iov_iter_get_pages is changed to pin pages instead.