From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20BBC77B7D for ; Sat, 20 May 2023 04:12:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E86D280002; Sat, 20 May 2023 00:12:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3986C900003; Sat, 20 May 2023 00:12:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 260BA280002; Sat, 20 May 2023 00:12:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0FA41900003 for ; Sat, 20 May 2023 00:12:36 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D4802AE679 for ; Sat, 20 May 2023 04:12:35 +0000 (UTC) X-FDA: 80809311870.27.7303641 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 32F8540005 for ; Sat, 20 May 2023 04:12:33 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wYBYJCsc; spf=none (imf12.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684555954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CmsksxXD+n4C0QHv7Zr+S4D+BO8Q1gfodWsSUUJZRcs=; b=lpecpuqZZkOurjOuuLzWLKM5kFaRaHPWA+WJOQjeYLZ4PT6vRd9lT+TnAOynIzF3B6vefM ERWu9yyxpvGWl2DxqJhYDpicFZWFIvnfTGGQRl3ZP1ULo4AgSwQ7TDuaOIxCKFknrpqEqi 3bLvdfzh88YPVDQ4UxqManKX0ytyf2c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684555954; a=rsa-sha256; cv=none; b=r4auKf4khyYEDa7BGS0LMgz9nDSW2Is2Hy8jgJTFwV97Jb5Cjxr22wv2GHHMRgJxnvmdPj eFxZmP1YmQXEhebCyRf5bLR/U762IOPYNVtdoavrrCpkB8li7NzJatBZAtpXfmE/OQQB0V 9CmZvthO/RM0SFqmWnh24u8+TW5+OEs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wYBYJCsc; spf=none (imf12.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CmsksxXD+n4C0QHv7Zr+S4D+BO8Q1gfodWsSUUJZRcs=; b=wYBYJCsc9X5cOzCe7Siycq+sm4 JN0IA6hxZMgTuCVKWEpoKYrifkBMr0lWDMJSliRS83pvDqAMRzSEcIoE30caFN3f0l0Wnhj6TXJR4 hiyhP8Q94fnYNIzKFJ0ohLNCPB78puv9ksyLcaKPTITe+x+BewZc+oc2uDW0phzAEJ68Aj8FgdbJc HR1Y0l3w8gjGXTTg8lmV/SJ0NzR3kMvVYQo7UDE/zUSwRbMduraWcnVaKN8Tg5eCSXYEy2Zqz1xRW ubQnDeOPaapafV9c1oAHb8WqsUFEC+DnlcaPgNTtPiRbXnjFUAXxqJGQmxc71ODO1WV+qC49LD9w1 zSA8V69Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Dx7-000dWG-23; Sat, 20 May 2023 04:12:21 +0000 Date: Fri, 19 May 2023 21:12:21 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Theodore Ts'o , Andreas Dilger , linux-ext4@vger.kernel.org Subject: Re: [PATCH v21 18/30] ext4: Provide a splice-read stub Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-19-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-19-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 32F8540005 X-Rspam-User: X-Stat-Signature: coo8ah6mihafmty7zzmfggb9ufq7dqxf X-Rspamd-Server: rspam03 X-HE-Tag: 1684555953-790693 X-HE-Meta: U2FsdGVkX1+sIPKV0fONc6cI324xvQXFNkycrVex2h4Ee/NgGlMh7V48W+u6d/WA/lCIH3mIJ69SH3gs60AlPSMGkQOFv2/6JuV0lWIRg95NeSKpvwhwjere+nlPsqbRgSU9dCSGiAdtTrLLs4vkIr2IPUdj41nXVHh5/b3s8WgiaPyKAS7V1dNZdJjy9/djeeQWSflO81O3mAeETrKgtxyQjAWoOkDvUjohIloyBlc0Y3butByAT9k5DMPgRtvaCftm5qJBuFSdLJopvLhdV7MgKBaQBTz8wDT5deyoffKNSqvgowndCnvFdUl4Tb8jVjrlCuvGsXIJlFj6/R0+V9sH8veA4Ao9fxSEqFrOblgLc1sFOf3uDiXSRu8JAJqpUF2+6c1NVFeGppWV7wNpPd2qh/rBaVwGlETiui9efspwpFmWABokIHtrOXGruiYxUSfbYiJdShJMhYWN41mzRDv1j8LMVQlEEyuIWK11MCWw6a1gBAZSXyl3xAiylJ79k+N4Msy2nG9VAEzuUZwN/W7uSipj+A1BNmuvse4zJUuOQixRsEz7+gVgUkf7gu2hzifK+pZck2qyKzAdidSO8gCrIDvz/BLEQNS3Hu+BbdwVVE6jIT5vjBdvfietyXHQbwrq4+XqcweHiFvTeo/1LJmrVaPizhbUD7MiAYEm6MAzHFawg2Ixie84bRE4EBC9fuX6YESfhg7BwVZ3I/kcPpKvr84/T0eAxRHnghAvovH3RtMgiTAHNzaAh4L9s1Xfdcki7LJAVBPmPiJghGn80zsgZG2qZWl9rS2WF8aYP7dWImQw4zphHmsTXUGWsDeTYFRf5vFrDSF+gtbhwsR8lwYccS38BHw/UUSQsjPQ4KQIkkd2sphb+obuuoZW7tg13+QoMHKr4NZ3zFUvNhNFohNGDeh/JogiZOmuYlIzNN10GCnFB2EOpKNJkRhO8PKIfm/Pq0W8ICu1Qj5dpI8 YIwIH6Yp JNXEauW3LCqFXUmKlbZzFc9zdTfYkv2kSqyiXSueoGo/E3SrRP8q5NoafLUDg6rvidxRNKIh2tAxjsxKlrTl6vHS+rZMQf5UGwu0wgX5prBGTPIoEJRjCFD1WXxgii40to7yK3xWbFQ7FditbhXYE2jK0K82CiHA4pQvDeXvTinLNFuI5+CVEgpeZaeCkrNumGcHX/o1jvved4SRA+UnGvQADpWZ95T6fs2EosCfggu6zO06iqslWljeQZaf3Zv8hCDLqrZKYyREHr9laV+Zvf6T+L4/9IivMF3ne+mStD784vBWZ9UHPMGRVEREwvSNbHVcS+5XfdAhPWEmOoN8N/Lm3GFGYLmO9ia7QFHRTbGhDivNCe57YflxntUiINGW8sH9cuKrWyJXBANc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 01:00:37AM +0100, David Howells wrote: > Provide a splice_read stub for Ext4. This does the inode shutdown check > before proceeding. Splicing from DAX files and O_DIRECT fds is handled by > the caller. Not sure I'd call this a stub, but then again I'm not a native speaker. The patch itself looks good: Reviewed-by: Christoph Hellwig