From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29CE0C7EE2A for ; Sat, 20 May 2023 04:11:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB12B900005; Sat, 20 May 2023 00:11:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6144900003; Sat, 20 May 2023 00:11:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2900900005; Sat, 20 May 2023 00:11:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 91509900003 for ; Sat, 20 May 2023 00:11:26 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D16E8A09CD for ; Sat, 20 May 2023 04:11:25 +0000 (UTC) X-FDA: 80809308930.06.8D7B5DD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 32C86C0004 for ; Sat, 20 May 2023 04:11:22 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Pt+PQf6v; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684555883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=p7XC/63oFjQxoHF7t2fhfQk86znxqJDj1/vHmSjNFlgRg58ISdrGE+vBT+OVzKBO502fGH tAuqUVGcbhVXzLMlroOrkkMUb1VX6trqM23Oioa/Wrb2ooVsA9KGHSFlW6kdv1sIdRA8fP np3F0fHEqPoBMml0PdPzg0s2iF0Xvg0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Pt+PQf6v; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684555883; a=rsa-sha256; cv=none; b=wKU9XGrY0ylx4soZNvOUxXhRmN4IEbkJ5jXfbD+o8gzmsOJfkz2grCHBCm/uXgZs1AjMNj P1Zchv0v+sQT/fuEpjmMvhRWFLc7dyk4iVqPZAVrXYFOUTgnav/BDeFnF94eZGa5LPgaQb 790VIi+KXfIBZuvxHgFXS5KbEr1uhcc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=Pt+PQf6v4zSblP55GrOTDhqctX Mp+y8puOTxwgbvkh7yzi1Zxb6L8eqHWgOmYIBki8oDPw15gwj5EZb9c65zH+dlVlCZsH1VD26uc++ 74cwKZW/BY2tuoIklce27ktMnMX5BxQt+a383yYp98C2Czps/vEC9j7q3RypCqBy8KidJp61DwbED M5iG5GV+kwcuUjYl+78htXNTchWV8SOynSeNQNAS2ttnxFtx3rG6PG+IIJXONB8yg+qtLDL/bjgi+ MlIOl0NJdXEkCANBg4WFNPIs32TnoVar+smRiyVs2irvReXw7RqLKpI85m38mf6Mk3FOte47LIBx0 4sSz2vyQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Dvz-000dLD-12; Sat, 20 May 2023 04:11:11 +0000 Date: Fri, 19 May 2023 21:11:11 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v21 07/30] splice: Make splice from an O_DIRECT fd use copy_splice_read() Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-8-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-8-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 32C86C0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 51ehosk4uagius6zc15eug7xnszrzeqc X-HE-Tag: 1684555882-786024 X-HE-Meta: U2FsdGVkX19OFzwMKrrS59gl3fD9XLNa/UpG3+zu2jA9KOfIGLziZMjx8vxm3Ds1Df6Kj/Sk0WoyDmor9wYzHoN0xxVa6kvk8+qIDzkCd22WzFeez/CMIu5jx+TOKs0pOwxbi2Ukg9/tD8Qy02cyHQs5w57WEie8wLhvMUYk3lv7bKEV2XG7hRp+38adoPm5NVHSFkBQTC5k/0RxE+EMaZSaxokcnbVXJVv7J/w19MjlJWLzd5FdxhLC+3ykxcknTvhsfjIIerYgEMxOZr8Fd2iLwi9Bryk3TKxazSI7oW737MIaN+e/sHSrkDZ4sNOjSUrKnCA7pypQc6NwlORpKVgirt4EopZ7/MVmEH1c/OoktvCo0/RxDDmXiwRF5qvqHCfOwuxB1cZIcpTa13P5z+drZgtwegqBRGqjJBfw0l6E/0rjpBW0HCZOvbMGk3dsHLBdgOqpmSFSSQ8LKXQiOGtmEpQ5yhpvAnEDAJiLQrqYHulDpvpkSgc5Qyd7NG4boQLTrWKd9ii1hIQ3GSM+KTbVKxwN8vNCQgUxL2lVN1t2h96MHxb5roFFblYX/zpBo45rsBVY/eIgHyNTo69ZwnwJfgDq3Ij8hr2A5sv6wWd/3eSGuJF3r+7XBbal2o2bmbGoaZLT4FpU2ofKO/b1HTE98PuvFUs4KESz6BfxL2xX6ZsdnIHDXUfGSbUK6UvLdDDIssNF+IP4ozj2BXE/Dn+31BqB1icoNCH5rCwZyapG55adtZ4HiUEdN4kiOLgsjaUybBqfW80HjGEWReCJ2B1SfQ7y6MMN+KwbeZ9REcvIERyka1w7fr8/G4Apcizk9ox5aedPorRaOOPUv4ZktF2GzlqE3GF9qnkoRs5PjHal56dUl/6L9qwgzq7ec1BJCjlL8UeXtRwpUMihe3koD1Y3A8ri3zu3OGD10UBSInTgDfxiwwpKZ1EyXgewrwvKWzTBiU74FtUqR/VZA3m IktdFSTh ZD2TqQlIXrifr+h0uGsEcRoI8SKIOmRYuE/H/B2QEviu4U2BV2Kh05Oyo9RbqfniQnlrLW+tdLOzQ2QI+n+9uDD3+bFu11O0vtbDdgxbvfgU0Cy/Bc8WJcWmUlVxiTttnENxUlqjafUwxZe3ZFke1g39a+Zw974PyUEypzvTSJCd+D1A8Ns/bEJjnN201nW2oGn9QhQ+1Xnm8xKbjoBoFZsDyeJ/fA4YH5tU/EP5t/zv3i4EPRl//qr44pLY1SmV9b5SRv6TO3rQ/jOr7AEEEHLUNAxmRy40U+zNiLGGCOGQAX+RwHKGWU5mQPTGZ1dc7eTdHYKOXAocijNBGtV040Cge5TqBSPQH+Dc4YEnfj94Cx9IFFPN4z5tO+nzhIqxsDN85vyWIz9uFSDRSxnpHZybg4oPkfbFRjN4LyGom+H5w4NUwNt8amDsWYpkUt1hxnWtPH8Rc2zcXFd968xQVKw6eTWuXXBBguafc53R0KiqQaF2fV831+69qDWs6K7jDQoQ36lvK5xDQuVYu/vmfkOX8Cchtm5u/QFyT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Looks good: Reviewed-by: Christoph Hellwig