From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B51C7EE2D for ; Sat, 20 May 2023 04:13:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9736280001; Sat, 20 May 2023 00:13:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4691900003; Sat, 20 May 2023 00:13:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5DA2280001; Sat, 20 May 2023 00:13:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C8FED900003 for ; Sat, 20 May 2023 00:13:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 02417C0A20 for ; Sat, 20 May 2023 04:13:53 +0000 (UTC) X-FDA: 80809315188.08.F9D748C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 5BBA11C000A for ; Sat, 20 May 2023 04:13:52 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=w3ZGmsdU; spf=none (imf21.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684556032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xi4OUwMjj6B5meDIABpjuRK4Kr+q2y1yEM0f2xLNo2w=; b=bwrfNDJ65+EJypUK9blqpkcl+MNLqDxv9mjWOIkBhGcjKHuhRNpWs0eR3m0jDy7RbE6xVD vq74lW3hsXENe66XWwoh/RCLNL/0pil5pg37iokot/lwpLNQn8dRw1Of/BZlDnxdbECihf TUS9OEjJF3uhlS7MdwCaGZsKqe0Ly1A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684556032; a=rsa-sha256; cv=none; b=psAJjph2OTVdqkfVNE9vp93FU5UgXsy7fHnR2OXNDLRIgAiPC296pUD4rAlnpVnhQmJUeb jcYbCTGlh3Fnctu+/Y3jSRlNScfkCplLrPy+3ayiOD8ZpUV233SRPSHRlc9Fjvb3n4Ae/3 VfZ8LKlzpz5wX8EZvA/J2XqCJYZLMys= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=w3ZGmsdU; spf=none (imf21.hostedemail.com: domain of BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2d90232fd80ffab3c8b5+7209+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xi4OUwMjj6B5meDIABpjuRK4Kr+q2y1yEM0f2xLNo2w=; b=w3ZGmsdU8hhe/7c+F8CRKXYNfw HhUo290wLcW0X+8ICvnQxtdMgPwpdGPH94AWRSZbCcEYiunEnXAdq8yIO71PNcxyf2aM2I4h07E/Y n1z9k6gW52OG/wtRTNmIm3iHqjvM10Y4XqmuF93RrnWf2IFKfJUWRj8NCzgAsSCmKEcyQD/AiFsbj K4l07RhpT3hk2C8/G89ne1NO2mAlvTK7bWPHFGMwnLzM8MA00YNd0XVAFOJ/HRb6GHIBjboyNCZJ8 gMrpPzrylB7vG3yRmmKvsL507SXFpiYJy4pmPl/OWzpWgIDmEQhhi3b+j1hoqDmATrLPuWc0Tlaiw lQzoY4rA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0DyQ-000dg9-0X; Sat, 20 May 2023 04:13:42 +0000 Date: Fri, 19 May 2023 21:13:42 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH v21 24/30] xfs: Provide a splice-read stub Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-25-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-25-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 5BBA11C000A X-Rspam-User: X-Stat-Signature: onoak19ur39yaieqw33ea3p4qykjg7g7 X-Rspamd-Server: rspam03 X-HE-Tag: 1684556032-386221 X-HE-Meta: U2FsdGVkX1+ZKy3VFUvu2KU1lCeWf8NJp28PNpJo863vkS0gl2v8RNfaUi3K4XylNS4D1m+Ha9siSxIsqclCZyrim6vcBddWxFJNE1J3XVzjpy4fNSS65fHK7s0YvJbjSjYrcEO0F/o2OTLsQWCm8V0uyHWJSK0a1XBObogy7NpszzvAPWGHz3xsZrr3lPUFzGn7Cg3T3py9sCQBNcMB+890di+9hXRiFGJ8/OQLf2qzYSNzINzX7GZTGrPlLLBYvuG3wUz4kn9QBKI+oqemFBRSnmRRmYHKfjnaJL5VkHSjyxa+xJ+qAkNOuHU/2flbTIXvoxc5aJPrRAd1s3M7OLou5jQlQq5cVbAHGUrdXY7o04m88vFMIvseeQj8Yn+t8NQkVaqvnHSl/iOZbsofOuvW0GBmJE5QKuu3AUh1rT5Ksp2gGHvH6cvCbA6lasTpQDR3YJkI8tbINsfOQ2rFNzkbt8L4xfs6YdpNGIcdddMNFf3bkjfUaBIBz+XtAAqpGjrYITUO+zvYmXGVLZvXV50WfIDnzC7YXxYIs51MiWfDSU5cEKzhbMgWJLtDXDeh+mZmXWSYD9GEa660cZSUYriSM9xHroMUj56rpNzHU3Vk6qa8ygvZGLHvvIKtSCcR5zGLCfZaYkp6iEG3u/xCMU2paaY+M3X8kDH4oEOrXTgJgDnVXycZGFiTMcQNxqd4c9CrcXDLA4ZWvXrvEyRWJReH/rRZR9Ox81oWXd7WrpNlHoU90K3oqeDYizNSnOyATiDZcAJX3uEdRAGJ5ApKkG2VqAZUeTmUPjfUZMHS53mAIYd0cpzQtP0Xub2Xnw/Kjh/+hoUaGZj4Cf6BG7EMqoeffQOFFc3IirYQNAC+s/W8vJKkOiTa16QYbElgIc53PEUL8gNkv8i4loXaEhGSVPz1EpQFZV3PDBQANjsA37GvK5d7rooYFmUfV56Meco8BfGuwHY95MhsTeDcHoH aa5duJok eCG1UaKVIkjXyRWA4hQtW/1T9OfHi/rwdi8hmK+g7KiyUFdSFMcGcMndA7bw5UwKv8809At3Pz+tezXOJ9iKkAz4DrItn1XESbYfyhIKjcVzKgZI47sGShMvPQVKxiRYNM0m8+w+qomEWqRdFqG88YdfygnuOAqOh3PVzNdN48ccow0sr2gcEPFXq7g/XexYm/dWVzHEy3PXBS808L0MzfrWZXFf8Qoxj1KGUO8kSpbXYiINvM8prlSicGbLuykjmP12znNY9+bjO9/Go8ogrh52+cdg503urutKvfI1a1n5UUqPbkvM6MbLUr5LRI6UqpwNM6IxAoUfVSbcjJKzZHx1xMHfkdQmFtznSkbwb4nWYFi1Aj2cpoArrttAOTbqyPPRQudtrbrPGYZ35eps0nQC6zatMqdO9DJgq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Same comment about stub sounding a bit weird as for ext4 and various patches not in my area, but the changes themselves looks good: Reviewed-by: Christoph Hellwig