From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF474C77B7A for ; Sat, 20 May 2023 04:13:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76BBE900003; Sat, 20 May 2023 00:13:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71AAA280002; Sat, 20 May 2023 00:13:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 609B8900006; Sat, 20 May 2023 00:13:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 53034900003 for ; Sat, 20 May 2023 00:13:59 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2833F1609C0 for ; Sat, 20 May 2023 04:13:59 +0000 (UTC) X-FDA: 80809315398.07.529EC94 Received: from out-10.mta1.migadu.com (out-10.mta1.migadu.com [95.215.58.10]) by imf08.hostedemail.com (Postfix) with ESMTP id 2AA28160015 for ; Sat, 20 May 2023 04:13:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=e83hTXYM; spf=pass (imf08.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.10 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684556037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SqsoafzfPV4IjLE2ZLifRoMd5Uqk59FpqAOq5GWnoQM=; b=CUAtzOcvDh53cRS2o/6v/Rmf4m9CGO/XkRhwmIh3LQylBqGvkzoarcJNW+wBXPazwJw/pj gPjTuXhpM1adyQ+Lc0lhJWZObzhKyNJo235MSIUqzmooHgcb7amIi9X0WIzUSk0Aixp9Be j49Eis0umbUrSPGuS2HRvv/F1nbo+IA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684556037; a=rsa-sha256; cv=none; b=T0vYl8WNb85x3iKSwc8ULw7WfM1VWXtFue3ycS1P0p2k1EW+J8yaYRTdds2+zvP3CGeIdY kGfneOlzHQquMW+mhpVEmDUniBkHBFF1elIf+bFO261L7AOMqi4kUWnPlC6ejZ6T0g3xOU pvCiz7F+ovF7+3rMu68Yz68uIIRi1bI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=e83hTXYM; spf=pass (imf08.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.10 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Sat, 20 May 2023 00:13:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684556034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SqsoafzfPV4IjLE2ZLifRoMd5Uqk59FpqAOq5GWnoQM=; b=e83hTXYMTjZ/kGkbHdu7QBK20JnL+nV9RtMDsHlg28URjNMcntI70K8uqwcw5eQ3Ld1ydi TB7rGni/vKo4lvCEPpV1/beRn7aqjBmnhfTv2E1LfUAP2+rEvrxOgoC/2VlqaZzFM9Ml79 vcAh3oHBldDEBGbnW9lVw2yfE5x2be8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: David Howells , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic Message-ID: References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-30-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: ez7f6ub7b8h7fgsbtkimzcp1osgcuygh X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2AA28160015 X-Rspam-User: X-HE-Tag: 1684556036-579931 X-HE-Meta: U2FsdGVkX18n6g6nPNSAdAv9PfbbACCrjtymuCXHN7WDXGQtmeS5w8lus+osELGdxqLh2h1Ow+mF1TLZmZXt/4J+rYpv5NkOvrbTneHzS7Z4U4XNWLMUAVifbUnb0Hx9zsUQkRbByVO4lrU05O2141JM8hwEGtk8PIAdA1InSz07Ewb08oOmbE16jprFtzC7nmm+v7Ruc5iz2h17WoUlw3K0C7mH2fhvk9zIoTx0tqPPd3mSs6048X5xvecrECnEsyfKkn7bGkxixuVwDj6uBT0ywG7KqtLtwxOUDvq2sKrEFKMWf+n34+GMqzeqNJrWDfHcDqWZrzoHSupwj5gnPMoIfBVLW78e5syOo+nNMYFzIT/wmoDuTfH6zTVH58MS/EsDz6Kb34VjDUKuFoIFJaPxz799NS9JDvRVJOsVEaLZEOZ8j13SwtAXU6Kepkoao0swJHfqVdm6shRR7fblET2TYjVir3wRV1T0JtFCLTuvCXQhYgUKPvmh5P7fvnsIo69ZU1n0POw0dWgphjvWqh/XYN4poX9QOIhgq6q7nXreXcd5d5wC+CKYVQYDmpwwjd8Kyjcuq+bWAUcDgjNhQdgPJmggsiSHNnWcNC29RY2OlHu+PqS83edd4KjuGQ0SufVaScZcpAlZTCkOC0pQgFL5wyK5l0n28KXNMN9OPGfxcYPG55ywCitpFrjyjsc2/Rh4PaJJT5WbO+oL6icmd080QiAPZf7T5pGZtIRKa+AvB5qSQHPQoxt9MmltdNVQKYbJuIgVuuDPoWlrUox4VzLrV83d6bmkRM6wBDNdgy4GJQsugXBYwm75ibVG4ah3puAxdtaJtIfRqlHyOkKkmafFkoyGuNVjxQX9uEUfKbbXqKzmSK60qLjr5400GODHfwMQ44vLNu3jy4NU3CI8+m3is7ShSNVEx2C4UbMUTR3jLipfJSlR85rkqKIOsEinSymcXY/FfSgH6U7rUbH H3Jdhjl7 9B6fj8E2QYUfdU+EPwpHqbBbizAcTbQUtb6dQVGC/bYf069Xnaj8W9goYVjgbjX770yEEfieBcsDq5GWKxFTolMdFmMSGVxChPtqX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 08:56:56PM -0700, Christoph Hellwig wrote: > On Fri, May 19, 2023 at 09:26:07PM -0400, Kent Overstreet wrote: > > On Fri, May 19, 2023 at 08:40:44AM +0100, David Howells wrote: > > > From: Christoph Hellwig > > > > > > Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted > > > meaning is only set when a page reference has been acquired that needs to > > > be released by bio_release_pages(). > > > > What was the motivation for this patch? > > So that is only is set when we need to release a page, instead telling > code to not release it when it otherwise would, where otherwise would > is implicit and undocumented and changes in this series. I suppose this way setting it can be done in bio_iov_iter_get_pages() - ok yeah, that makes sense. But it seems like it should be set in bio_iov_iter_get_pages() though, and I'm not seeing that?